| Message ID | 20240530022634.2062084-2-pengfei.li_1@nxp.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: freescale: Add i.MX91 11x11 EVK basic support | expand |
On Wed, May 29, 2024 at 07:26:30PM -0700, Pengfei Li wrote: > i.MX91 has similar Clock Control Module(CCM) design as i.MX93. > Add a new compatible string for i.MX91. > > Signed-off-by: Pengfei Li <pengfei.li_1@nxp.com> > Reviewed-by: Frank Li <Frank.Li@nxp.com> > --- > Documentation/devicetree/bindings/clock/imx93-clock.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/clock/imx93-clock.yaml b/Documentation/devicetree/bindings/clock/imx93-clock.yaml > index ccb53c6b96c1..98c0800732ef 100644 > --- a/Documentation/devicetree/bindings/clock/imx93-clock.yaml > +++ b/Documentation/devicetree/bindings/clock/imx93-clock.yaml > @@ -16,6 +16,7 @@ description: | > properties: > compatible: > enum: > + - fsl,imx91-ccm > - fsl,imx93-ccm Should fallback to fsl,imx93-ccm? Being a superset should be ok because your DT should never use the non-existent clocks. If not, where is the driver change? Rob
On 06/06/2024 01:59, Pengfei Li wrote: > On Tue, Jun 04, 2024 at 10:03:06AM -0500, Rob Herring wrote: >> On Wed, May 29, 2024 at 07:26:30PM -0700, Pengfei Li wrote: >>> i.MX91 has similar Clock Control Module(CCM) design as i.MX93. >>> Add a new compatible string for i.MX91. >>> >>> Signed-off-by: Pengfei Li <pengfei.li_1@nxp.com> >>> Reviewed-by: Frank Li <Frank.Li@nxp.com> >>> --- >>> Documentation/devicetree/bindings/clock/imx93-clock.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/clock/imx93-clock.yaml b/Documentation/devicetree/bindings/clock/imx93-clock.yaml >>> index ccb53c6b96c1..98c0800732ef 100644 >>> --- a/Documentation/devicetree/bindings/clock/imx93-clock.yaml >>> +++ b/Documentation/devicetree/bindings/clock/imx93-clock.yaml >>> @@ -16,6 +16,7 @@ description: | >>> properties: >>> compatible: >>> enum: >>> + - fsl,imx91-ccm >>> - fsl,imx93-ccm >> >> Should fallback to fsl,imx93-ccm? Being a superset should be ok because >> your DT should never use the non-existent clocks. If not, where is the >> driver change? >> >> Rob >> > > Hi Rob Herring, > > Due to the different maintainers of the CCM framework and DTS, I have separated > the CCM driver patch and plan to send the DTS patch first before sending the > CCM driver patch. If that's possible, could you help merge this patch first? If > this is not allowed, I can also send out the CCM driver patch at the same time. Binding goes with the driver, not DTS. Best regards, Krzysztof
On Tue, Jun 04, 2024 at 10:03:06AM -0500, Rob Herring wrote: > On Wed, May 29, 2024 at 07:26:30PM -0700, Pengfei Li wrote: > > i.MX91 has similar Clock Control Module(CCM) design as i.MX93. > > Add a new compatible string for i.MX91. > > > > Signed-off-by: Pengfei Li <pengfei.li_1@nxp.com> > > Reviewed-by: Frank Li <Frank.Li@nxp.com> > > --- > > Documentation/devicetree/bindings/clock/imx93-clock.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/clock/imx93-clock.yaml b/Documentation/devicetree/bindings/clock/imx93-clock.yaml > > index ccb53c6b96c1..98c0800732ef 100644 > > --- a/Documentation/devicetree/bindings/clock/imx93-clock.yaml > > +++ b/Documentation/devicetree/bindings/clock/imx93-clock.yaml > > @@ -16,6 +16,7 @@ description: | > > properties: > > compatible: > > enum: > > + - fsl,imx91-ccm > > - fsl,imx93-ccm > > Should fallback to fsl,imx93-ccm? Being a superset should be ok because > your DT should never use the non-existent clocks. If not, where is the > driver change? > > Rob > Hi Rob Herring, Due to the different maintainers of the CCM framework and DTS, I have separated the CCM driver patch and plan to send the DTS patch first before sending the CCM driver patch. If that's possible, could you help merge this patch first? If this is not allowed, I can also send out the CCM driver patch at the same time. BR, Pengfei Li
diff --git a/Documentation/devicetree/bindings/clock/imx93-clock.yaml b/Documentation/devicetree/bindings/clock/imx93-clock.yaml index ccb53c6b96c1..98c0800732ef 100644 --- a/Documentation/devicetree/bindings/clock/imx93-clock.yaml +++ b/Documentation/devicetree/bindings/clock/imx93-clock.yaml @@ -16,6 +16,7 @@ description: | properties: compatible: enum: + - fsl,imx91-ccm - fsl,imx93-ccm reg: