diff mbox series

[net-next] net: allow rps/rfs related configs to be switched

Message ID 20240531164440.13292-1-kerneljasonxing@gmail.com (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series [net-next] net: allow rps/rfs related configs to be switched | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 8 this patch: 8
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 4 of 4 maintainers
netdev/build_clang success Errors and warnings before: 8 this patch: 8
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 8 this patch: 8
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 22 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-06-04--18-00 (tests: 1045)

Commit Message

Jason Xing May 31, 2024, 4:44 p.m. UTC 
From: Jason Xing <kernelxing@tencent.com>

After John Sperbeck reported a compile error if the CONFIG_RFS_ACCEL
is off, I found that I cannot easily enable/disable the config
because of lack of the prompt when using 'make menuconfig'. Therefore,
I decided to change rps/rfc related configs altogether.

Signed-off-by: Jason Xing <kernelxing@tencent.com>
---
 net/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Simon Horman June 4, 2024, 5:03 p.m. UTC | #1 
On Sat, Jun 01, 2024 at 12:44:40AM +0800, Jason Xing wrote:
> From: Jason Xing <kernelxing@tencent.com>
> 
> After John Sperbeck reported a compile error if the CONFIG_RFS_ACCEL
> is off, I found that I cannot easily enable/disable the config
> because of lack of the prompt when using 'make menuconfig'. Therefore,
> I decided to change rps/rfc related configs altogether.
> 
> Signed-off-by: Jason Xing <kernelxing@tencent.com>

Hi Jason,

FWIIW, I think it would be appropriate to also add help text for each option.
And I would drop "Enable", modeling Kdoc on, f.e. CONFIG_CGROUP_NET_CLASSID.

Likewise for CONFIG_BQL, although that isn't strictly related to this
patch.

...
Jason Xing June 5, 2024, 12:54 a.m. UTC | #2 
Hello Simon,

On Wed, Jun 5, 2024 at 1:04 AM Simon Horman <horms@kernel.org> wrote:
>
> On Sat, Jun 01, 2024 at 12:44:40AM +0800, Jason Xing wrote:
> > From: Jason Xing <kernelxing@tencent.com>
> >
> > After John Sperbeck reported a compile error if the CONFIG_RFS_ACCEL
> > is off, I found that I cannot easily enable/disable the config
> > because of lack of the prompt when using 'make menuconfig'. Therefore,
> > I decided to change rps/rfc related configs altogether.
> >
> > Signed-off-by: Jason Xing <kernelxing@tencent.com>
>
> Hi Jason,
>
> FWIIW, I think it would be appropriate to also add help text for each option.
> And I would drop "Enable", modeling Kdoc on, f.e. CONFIG_CGROUP_NET_CLASSID.

Thanks for your review.

I will adjust as you suggest in the next submission.

>
> Likewise for CONFIG_BQL, although that isn't strictly related to this
> patch.

Yes, I can see. I think I could write another patch to do this since
currently I would like to submit a rps/rfs related patch.

Thanks,
Jason
Simon Horman June 5, 2024, 7:54 p.m. UTC | #3 
On Wed, Jun 05, 2024 at 08:54:03AM +0800, Jason Xing wrote:
> Hello Simon,
> 
> On Wed, Jun 5, 2024 at 1:04 AM Simon Horman <horms@kernel.org> wrote:
> >
> > On Sat, Jun 01, 2024 at 12:44:40AM +0800, Jason Xing wrote:
> > > From: Jason Xing <kernelxing@tencent.com>
> > >
> > > After John Sperbeck reported a compile error if the CONFIG_RFS_ACCEL
> > > is off, I found that I cannot easily enable/disable the config
> > > because of lack of the prompt when using 'make menuconfig'. Therefore,
> > > I decided to change rps/rfc related configs altogether.
> > >
> > > Signed-off-by: Jason Xing <kernelxing@tencent.com>
> >
> > Hi Jason,
> >
> > FWIIW, I think it would be appropriate to also add help text for each option.
> > And I would drop "Enable", modeling Kdoc on, f.e. CONFIG_CGROUP_NET_CLASSID.
> 
> Thanks for your review.
> 
> I will adjust as you suggest in the next submission.

Thanks.

> > Likewise for CONFIG_BQL, although that isn't strictly related to this
> > patch.
> 
> Yes, I can see. I think I could write another patch to do this since
> currently I would like to submit a rps/rfs related patch.

Yes, of course.
It's a separate issue.
diff mbox series

Patch

diff --git a/net/Kconfig b/net/Kconfig
index f0a8692496ff..cea38fc2e2ef 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -290,12 +290,12 @@  config MAX_SKB_FRAGS
 	  If unsure, say 17.
 
 config RPS
-	bool
+	bool "Enable receive packet steering"
 	depends on SMP && SYSFS
 	default y
 
 config RFS_ACCEL
-	bool
+	bool "Enable hardware acceleration of RFS"
 	depends on RPS
 	select CPU_RMAP
 	default y
@@ -351,7 +351,7 @@  config BPF_STREAM_PARSER
 	  BPF_MAP_TYPE_SOCKMAP.
 
 config NET_FLOW_LIMIT
-	bool
+	bool "Enable net flow limit"
 	depends on RPS
 	default y
 	help