diff mbox series

[v4,1/4] target/hexagon: idef-parser remove unused defines

Message ID 20240523125901.27797-2-anjo@rev.ng (mailing list archive)
State New, archived
Headers show
Series target/hexagon: Minor idef-parser cleanup | expand

Commit Message

Anton Johansson May 23, 2024, 12:58 p.m. UTC 
Before switching to GArray/g_string_printf we used fixed size arrays for
output buffers and instructions arguments among other things.

Macros defining the sizes of these buffers were left behind, remove
them.

Signed-off-by: Anton Johansson <anjo@rev.ng>
Reviewed-by: Taylor Simpson <ltaylorsimpson@gmail.com>
Reviewed-by: Brian Cain <bcain@quicinc.com>
---
 target/hexagon/idef-parser/idef-parser.h | 10 ----------
 1 file changed, 10 deletions(-)

Comments

Brian Cain June 6, 2024, 3:14 a.m. UTC | #1 
On 5/23/2024 7:58 AM, Anton Johansson via wrote:
> Before switching to GArray/g_string_printf we used fixed size arrays for
> output buffers and instructions arguments among other things.
>
> Macros defining the sizes of these buffers were left behind, remove
> them.
>
> Signed-off-by: Anton Johansson <anjo@rev.ng>
> Reviewed-by: Taylor Simpson <ltaylorsimpson@gmail.com>
> Reviewed-by: Brian Cain <bcain@quicinc.com>
> ---

Queued -- at https://github.com/quic/qemu/tree/hex.next


>   target/hexagon/idef-parser/idef-parser.h | 10 ----------
>   1 file changed, 10 deletions(-)
>
> diff --git a/target/hexagon/idef-parser/idef-parser.h b/target/hexagon/idef-parser/idef-parser.h
> index 3faa1deecd..8594cbe3a2 100644
> --- a/target/hexagon/idef-parser/idef-parser.h
> +++ b/target/hexagon/idef-parser/idef-parser.h
> @@ -23,16 +23,6 @@
>   #include <stdbool.h>
>   #include <glib.h>
>   
> -#define TCGV_NAME_SIZE 7
> -#define MAX_WRITTEN_REGS 32
> -#define OFFSET_STR_LEN 32
> -#define ALLOC_LIST_LEN 32
> -#define ALLOC_NAME_SIZE 32
> -#define INIT_LIST_LEN 32
> -#define OUT_BUF_LEN (1024 * 1024)
> -#define SIGNATURE_BUF_LEN (128 * 1024)
> -#define HEADER_BUF_LEN (128 * 1024)
> -
>   /* Variadic macros to wrap the buffer printing functions */
>   #define EMIT(c, ...)                                                           \
>       do {                                                                       \
diff mbox series

Patch

diff --git a/target/hexagon/idef-parser/idef-parser.h b/target/hexagon/idef-parser/idef-parser.h
index 3faa1deecd..8594cbe3a2 100644
--- a/target/hexagon/idef-parser/idef-parser.h
+++ b/target/hexagon/idef-parser/idef-parser.h
@@ -23,16 +23,6 @@ 
 #include <stdbool.h>
 #include <glib.h>
 
-#define TCGV_NAME_SIZE 7
-#define MAX_WRITTEN_REGS 32
-#define OFFSET_STR_LEN 32
-#define ALLOC_LIST_LEN 32
-#define ALLOC_NAME_SIZE 32
-#define INIT_LIST_LEN 32
-#define OUT_BUF_LEN (1024 * 1024)
-#define SIGNATURE_BUF_LEN (128 * 1024)
-#define HEADER_BUF_LEN (128 * 1024)
-
 /* Variadic macros to wrap the buffer printing functions */
 #define EMIT(c, ...)                                                           \
     do {                                                                       \