diff mbox series

[net-next,v1,1/1] net: dsa: hellcreek: Replace kernel.h with what is used

Message ID 20240606161549.2987587-1-andriy.shevchenko@linux.intel.com (mailing list archive)
State Accepted
Commit c917b26e1686b99f18a3c9fbce508a7c264c6706
Delegated to: Netdev Maintainers
Headers show
Series [net-next,v1,1/1] net: dsa: hellcreek: Replace kernel.h with what is used | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 901 this patch: 901
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 8 of 8 maintainers
netdev/build_clang success Errors and warnings before: 905 this patch: 905
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 905 this patch: 905
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 19 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-06-07--09-00 (tests: 1041)

Commit Message

Andy Shevchenko June 6, 2024, 4:15 p.m. UTC
kernel.h is included solely for some other existing headers.
Include them directly and get rid of kernel.h.

While at it, sort headers alphabetically for easier maintenance.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/net/dsa/hirschmann/hellcreek.h | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

Comments

Kurt Kanzenbach June 6, 2024, 5:11 p.m. UTC | #1
On Thu Jun 06 2024, Andy Shevchenko wrote:
> kernel.h is included solely for some other existing headers.
> Include them directly and get rid of kernel.h.
>
> While at it, sort headers alphabetically for easier maintenance.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Thanks!

Reviewed-by: Kurt Kanzenbach <kurt@linutronix.de>
patchwork-bot+netdevbpf@kernel.org June 10, 2024, 12:20 p.m. UTC | #2
Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Thu,  6 Jun 2024 19:15:49 +0300 you wrote:
> kernel.h is included solely for some other existing headers.
> Include them directly and get rid of kernel.h.
> 
> While at it, sort headers alphabetically for easier maintenance.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> [...]

Here is the summary with links:
  - [net-next,v1,1/1] net: dsa: hellcreek: Replace kernel.h with what is used
    https://git.kernel.org/netdev/net-next/c/c917b26e1686

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/dsa/hirschmann/hellcreek.h b/drivers/net/dsa/hirschmann/hellcreek.h
index 6874cb9dc361..9c2ed2ba79da 100644
--- a/drivers/net/dsa/hirschmann/hellcreek.h
+++ b/drivers/net/dsa/hirschmann/hellcreek.h
@@ -12,14 +12,16 @@ 
 
 #include <linux/bitmap.h>
 #include <linux/bitops.h>
+#include <linux/container_of.h>
 #include <linux/device.h>
-#include <linux/kernel.h>
-#include <linux/mutex.h>
-#include <linux/workqueue.h>
 #include <linux/leds.h>
+#include <linux/mutex.h>
 #include <linux/platform_data/hirschmann-hellcreek.h>
 #include <linux/ptp_clock_kernel.h>
 #include <linux/timecounter.h>
+#include <linux/types.h>
+#include <linux/workqueue.h>
+
 #include <net/dsa.h>
 #include <net/pkt_sched.h>