Message ID | 20240606161549.2987587-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
---|---|
State | Accepted |
Commit | c917b26e1686b99f18a3c9fbce508a7c264c6706 |
Delegated to: | Netdev Maintainers |
Headers | show |
Series | [net-next,v1,1/1] net: dsa: hellcreek: Replace kernel.h with what is used | expand |
On Thu Jun 06 2024, Andy Shevchenko wrote: > kernel.h is included solely for some other existing headers. > Include them directly and get rid of kernel.h. > > While at it, sort headers alphabetically for easier maintenance. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Thanks! Reviewed-by: Kurt Kanzenbach <kurt@linutronix.de>
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Thu, 6 Jun 2024 19:15:49 +0300 you wrote: > kernel.h is included solely for some other existing headers. > Include them directly and get rid of kernel.h. > > While at it, sort headers alphabetically for easier maintenance. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > [...] Here is the summary with links: - [net-next,v1,1/1] net: dsa: hellcreek: Replace kernel.h with what is used https://git.kernel.org/netdev/net-next/c/c917b26e1686 You are awesome, thank you!
diff --git a/drivers/net/dsa/hirschmann/hellcreek.h b/drivers/net/dsa/hirschmann/hellcreek.h index 6874cb9dc361..9c2ed2ba79da 100644 --- a/drivers/net/dsa/hirschmann/hellcreek.h +++ b/drivers/net/dsa/hirschmann/hellcreek.h @@ -12,14 +12,16 @@ #include <linux/bitmap.h> #include <linux/bitops.h> +#include <linux/container_of.h> #include <linux/device.h> -#include <linux/kernel.h> -#include <linux/mutex.h> -#include <linux/workqueue.h> #include <linux/leds.h> +#include <linux/mutex.h> #include <linux/platform_data/hirschmann-hellcreek.h> #include <linux/ptp_clock_kernel.h> #include <linux/timecounter.h> +#include <linux/types.h> +#include <linux/workqueue.h> + #include <net/dsa.h> #include <net/pkt_sched.h>
kernel.h is included solely for some other existing headers. Include them directly and get rid of kernel.h. While at it, sort headers alphabetically for easier maintenance. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/net/dsa/hirschmann/hellcreek.h | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)