| Message ID | 20240603192254.2441025-1-heiko@sntech.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: rockchip: set correct pwm0 pinctrl on rk3588-tiger | expand |
Hi Heiko, On 6/3/24 9:22 PM, Heiko Stuebner wrote: > From: Heiko Stuebner <heiko.stuebner@cherry.de> > > PWM0 on rk3588-tiger is connected to the BLT_CTRL pin of the Q7 connector > meant as the name implies to control a backlight device. > If not used for backlight, it can be used as a General Purpose PWM Output according to the Qseven standard as well. > Therefore set the correct M1 pinctrl variant for it. The M0 variant > cannot ever be used because that pin is routed to a connector pin on the > Q7 connector that is reserved for CAN use and the pin reachable by the M2 > variant is reserved for the embedded MCU on the SoM. > > Fixes: 6173ef24b35b ("arm64: dts: rockchip: add RK3588-Q7 (Tiger) SoM") > Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de> Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de> Thanks! Quentin
On Mon, 3 Jun 2024 21:22:54 +0200, Heiko Stuebner wrote: > From: Heiko Stuebner <heiko.stuebner@cherry.de> > > PWM0 on rk3588-tiger is connected to the BLT_CTRL pin of the Q7 connector > meant as the name implies to control a backlight device. > > Therefore set the correct M1 pinctrl variant for it. The M0 variant > cannot ever be used because that pin is routed to a connector pin on the > Q7 connector that is reserved for CAN use and the pin reachable by the M2 > variant is reserved for the embedded MCU on the SoM. > > [...] Applied, thanks! [1/1] arm64: dts: rockchip: set correct pwm0 pinctrl on rk3588-tiger commit: a21d2cc2f9039023105bf9f9bf1acf324d5ebf9d Best regards,
diff --git a/arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi index 0c1115cdee22c..f870f84da1e6d 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi @@ -352,6 +352,11 @@ usb3_id: usb3-id { }; }; +&pwm0 { + pinctrl-0 = <&pwm0m1_pins>; + pinctrl-names = "default"; +}; + &saradc { vref-supply = <&vcc_1v8_s0>; status = "okay";