| Message ID | 20240607122357.115423-2-david@redhat.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | fs/proc: move page_mapcount() to fs/proc/internal.h | expand |
On Fri, Jun 07, 2024 at 02:23:52PM +0200, David Hildenbrand wrote: > Looks like we never taught pagemap_pmd_range() about the existence of > PMD-mapped file THPs. Seems to date back to the times when we first added > support for non-anon THPs in the form of shmem THP. > > Fixes: 800d8c63b2e9 ("shmem: add huge pages support") > Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> > Signed-off-by: David Hildenbrand <david@redhat.com> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
On Fri, Jun 7, 2024 at 8:24 PM David Hildenbrand <david@redhat.com> wrote: > > Looks like we never taught pagemap_pmd_range() about the existence of > PMD-mapped file THPs. Seems to date back to the times when we first added > support for non-anon THPs in the form of shmem THP. > > Fixes: 800d8c63b2e9 ("shmem: add huge pages support") > Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> > Signed-off-by: David Hildenbrand <david@redhat.com> LGTM. Feel free to add: Reviewed-by: Lance Yang <ioworker0@gmail.com> Thanks, Lance > --- > fs/proc/task_mmu.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > index 5aceb3db7565e..08465b904ced5 100644 > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -1522,6 +1522,8 @@ static int pagemap_pmd_range(pmd_t *pmdp, unsigned long addr, unsigned long end, > } > #endif > > + if (page && !PageAnon(page)) > + flags |= PM_FILE; > if (page && !migration && page_mapcount(page) == 1) > flags |= PM_MMAP_EXCLUSIVE; > > -- > 2.45.2 > >
On Fri, Jun 07, 2024 at 02:23:52PM +0200, David Hildenbrand wrote: > Looks like we never taught pagemap_pmd_range() about the existence of > PMD-mapped file THPs. Seems to date back to the times when we first added > support for non-anon THPs in the form of shmem THP. > > Fixes: 800d8c63b2e9 ("shmem: add huge pages support") > Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> > Signed-off-by: David Hildenbrand <david@redhat.com> Reviewed-by: Oscar Salvador <osalvador@suse.de> > --- > fs/proc/task_mmu.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > index 5aceb3db7565e..08465b904ced5 100644 > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -1522,6 +1522,8 @@ static int pagemap_pmd_range(pmd_t *pmdp, unsigned long addr, unsigned long end, > } > #endif > > + if (page && !PageAnon(page)) > + flags |= PM_FILE; > if (page && !migration && page_mapcount(page) == 1) > flags |= PM_MMAP_EXCLUSIVE; > > -- > 2.45.2 > >
diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index 5aceb3db7565e..08465b904ced5 100644 --- a/fs/proc/task_mmu.c +++ b/fs/proc/task_mmu.c @@ -1522,6 +1522,8 @@ static int pagemap_pmd_range(pmd_t *pmdp, unsigned long addr, unsigned long end, } #endif + if (page && !PageAnon(page)) + flags |= PM_FILE; if (page && !migration && page_mapcount(page) == 1) flags |= PM_MMAP_EXCLUSIVE;
Looks like we never taught pagemap_pmd_range() about the existence of PMD-mapped file THPs. Seems to date back to the times when we first added support for non-anon THPs in the form of shmem THP. Fixes: 800d8c63b2e9 ("shmem: add huge pages support") Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> Signed-off-by: David Hildenbrand <david@redhat.com> --- fs/proc/task_mmu.c | 2 ++ 1 file changed, 2 insertions(+)