[v6,0/3] arm64: dts: add i.MX95 and EVK board

Message

Peng Fan (OSS) June 5, 2024, 1:22 a.m. UTC

Add a minimal i.MX95 dtsi and EVK board dts.
i.MX95 has a M33 running SCMI firmware that supports
pinctrl/power/perf/clock and etc.

imx95-pinfunc.h will trigger checkpatch error, that is expected and same
as other i.MX platforms.

In v6, I added back a dependency on pinctrl, because [1] has got A-b/R-b
from Maintainers, so it would be soon got merged.

There will be dtbs_check error before [1] got landed. With [1] merged,
there will be no dtbs_check error.

[1] https://lore.kernel.org/all/[e-mail]/

This patchset is just a minimal support for i.MX95. After this patchset
is accepted, a following patchset will include more nodes and features.

Signed-off-by: Peng Fan <[e-mail]>
---
Changes in v6:
- Add pinctrl nodes and pin settings
- Add imx95-pinfunc.h
- Drop fsl,cd-gpio-disable-wakeup which is downstream property
- Per i.MX M33 SCMI firmware, drop unused PERF entries in imx95-power.h
- Rebased to next-20240604
- Link to v5: https://lore.kernel.org/r/[e-mail]

Changes in v5:
- Drop unused regulator and alias for now.
- Fix CHECK_DTB warning.
- Link to v4: https://lore.kernel.org/r/[e-mail]

Changes in v4:
- Sort nodes by address
- Drop coresight nodes
- Align clock rates for SDHC1-3
- Drop wdog3 board specific property
- Link to v3: https://lore.kernel.org/r/[e-mail]

Changes in v3:
- Drop irqsteer node because binding not accepted
- Pass dtbs_check
- Link to v2: https://lore.kernel.org/r/[e-mail]

Changes in v2:
- Addressed Rob and Krzysztof's comments, and fix dts_check issue
  To pass the dtbs_check, need apply:
  https://lore.kernel.org/all/[e-mail]/
  https://lore.kernel.org/all/[e-mail]/
  https://lore.kernel.org/all/[e-mail]/
  https://lore.kernel.org/all/[e-mail]/
  https://lore.kernel.org/all/[e-mail]/

- Link to v1: https://lore.kernel.org/r/[e-mail]

---
Peng Fan (3):
      dt-bindings: arm: fsl: add i.MX95 19x19 EVK board
      arm64: dts: freescale: add i.MX95 basic dtsi
      arm64: dts: freescale: add i.MX95 19x19 EVK minimal board dts

 Documentation/devicetree/bindings/arm/fsl.yaml    |    6 +
 arch/arm64/boot/dts/freescale/Makefile            |    1 +
 arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts |  200 ++++
 arch/arm64/boot/dts/freescale/imx95-clock.h       |  187 ++++
 arch/arm64/boot/dts/freescale/imx95-pinfunc.h     |  865 +++++++++++++++++
 arch/arm64/boot/dts/freescale/imx95-power.h       |   47 +
 arch/arm64/boot/dts/freescale/imx95.dtsi          | 1063 +++++++++++++++++++++
 7 files changed, 2369 insertions(+)
---
base-commit: a1bede4830147a5a29ea6443724837ee0b126fd9
change-id: 20240428-imx95-dts-v3-bee59f0e559b

Best regards,

Comments

Rob Herring (Arm) June 5, 2024, 1:11 p.m. UTC | #1

On Wed, 05 Jun 2024 09:22:47 +0800, Peng Fan (OSS) wrote:
> Add a minimal i.MX95 dtsi and EVK board dts.
> i.MX95 has a M33 running SCMI firmware that supports
> pinctrl/power/perf/clock and etc.
> 
> imx95-pinfunc.h will trigger checkpatch error, that is expected and same
> as other i.MX platforms.
> 
> In v6, I added back a dependency on pinctrl, because [1] has got A-b/R-b
> from Maintainers, so it would be soon got merged.
> 
> There will be dtbs_check error before [1] got landed. With [1] merged,
> there will be no dtbs_check error.
> 
> [1] https://lore.kernel.org/all/[e-mail]/
> 
> This patchset is just a minimal support for i.MX95. After this patchset
> is accepted, a following patchset will include more nodes and features.
> 
> Signed-off-by: Peng Fan <[e-mail]>
> ---
> Changes in v6:
> - Add pinctrl nodes and pin settings
> - Add imx95-pinfunc.h
> - Drop fsl,cd-gpio-disable-wakeup which is downstream property
> - Per i.MX M33 SCMI firmware, drop unused PERF entries in imx95-power.h
> - Rebased to next-20240604
> - Link to v5: https://lore.kernel.org/r/[e-mail]
> 
> Changes in v5:
> - Drop unused regulator and alias for now.
> - Fix CHECK_DTB warning.
> - Link to v4: https://lore.kernel.org/r/[e-mail]
> 
> Changes in v4:
> - Sort nodes by address
> - Drop coresight nodes
> - Align clock rates for SDHC1-3
> - Drop wdog3 board specific property
> - Link to v3: https://lore.kernel.org/r/[e-mail]
> 
> Changes in v3:
> - Drop irqsteer node because binding not accepted
> - Pass dtbs_check
> - Link to v2: https://lore.kernel.org/r/[e-mail]
> 
> Changes in v2:
> - Addressed Rob and Krzysztof's comments, and fix dts_check issue
>   To pass the dtbs_check, need apply:
>   https://lore.kernel.org/all/[e-mail]/
>   https://lore.kernel.org/all/[e-mail]/
>   https://lore.kernel.org/all/[e-mail]/
>   https://lore.kernel.org/all/[e-mail]/
>   https://lore.kernel.org/all/[e-mail]/
> 
> - Link to v1: https://lore.kernel.org/r/[e-mail]
> 
> ---
> Peng Fan (3):
>       dt-bindings: arm: fsl: add i.MX95 19x19 EVK board
>       arm64: dts: freescale: add i.MX95 basic dtsi
>       arm64: dts: freescale: add i.MX95 19x19 EVK minimal board dts
> 
>  Documentation/devicetree/bindings/arm/fsl.yaml    |    6 +
>  arch/arm64/boot/dts/freescale/Makefile            |    1 +
>  arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts |  200 ++++
>  arch/arm64/boot/dts/freescale/imx95-clock.h       |  187 ++++
>  arch/arm64/boot/dts/freescale/imx95-pinfunc.h     |  865 +++++++++++++++++
>  arch/arm64/boot/dts/freescale/imx95-power.h       |   47 +
>  arch/arm64/boot/dts/freescale/imx95.dtsi          | 1063 +++++++++++++++++++++
>  7 files changed, 2369 insertions(+)
> ---
> base-commit: a1bede4830147a5a29ea6443724837ee0b126fd9
> change-id: 20240428-imx95-dts-v3-bee59f0e559b
> 
> Best regards,
> --
> Peng Fan <[e-mail]>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y freescale/imx95-19x19-evk.dtb' for [e-mail]:

arch/arm64/boot/dts/freescale/imx95-19x19-evk.dtb: scmi: protocol@19: Unevaluated properties are not allowed ('regusdhc2vmmcgrp', 'uart1grp', 'usdhc1-100mhzgrp', 'usdhc1-200mhzgrp', 'usdhc1grp', 'usdhc2-100mhzgrp', 'usdhc2-200mhzgrp', 'usdhc2gpiogrp', 'usdhc2grp' were unexpected)
	from schema $id: http://devicetree.org/schemas/firmware/arm,scmi.yaml#

Peng Fan June 11, 2024, 3:32 a.m. UTC | #2

Hi Rob, Shawn

> Subject: Re: [PATCH v6 0/3] arm64: dts: add i.MX95 and EVK board
> 
> 
> On Wed, 05 Jun 2024 09:22:47 +0800, Peng Fan (OSS) wrote:
> > Add a minimal i.MX95 dtsi and EVK board dts.
> > i.MX95 has a M33 running SCMI firmware that supports
> > pinctrl/power/perf/clock and etc.
> >
> > imx95-pinfunc.h will trigger checkpatch error, that is expected and
> > same as other i.MX platforms.
> >
> > In v6, I added back a dependency on pinctrl, because [1] has got
> > A-b/R-b from Maintainers, so it would be soon got merged.
> >
> > There will be dtbs_check error before [1] got landed. With [1] merged,
> > there will be no dtbs_check error.
> >

....
> >
> >
> >
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform maintainer
> whether these warnings are acceptable or not. No need to reply unless the
> platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then make sure dt-
> schema is up to date:
> 
>   pip3 install dtschema --upgrade
> 
> 
> New warnings running 'make CHECK_DTBS=y freescale/imx95-19x19-evk.dtb'
> for [e-mail]:
> 
> arch/arm64/boot/dts/freescale/imx95-19x19-evk.dtb: scmi: protocol@19:
> Unevaluated properties are not allowed ('regusdhc2vmmcgrp', 'uart1grp',
> 'usdhc1-100mhzgrp', 'usdhc1-200mhzgrp', 'usdhc1grp', 'usdhc2-100mhzgrp',
> 'usdhc2-200mhzgrp', 'usdhc2gpiogrp', 'usdhc2grp' were unexpected)
> 	from schema $id:

Since Linus has applied the pinctrl patchset[1], the check will pass.

[1] https://lore.kernel.org/all/CACRpkdbpL=HUXj0hFAo+JNki_R
A9aix2sW1cg13g9=[e-mail]/

Shawn,
In patch 3, there is one minor comment, do you expect me to send v7
or you could help update it?

Thanks,
Peng.
> 
> 
>