| Message ID | 171811265627.85078.16897867213512435822.stgit@devnote2 (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3eddb031965ae9a95ba098ae6eb81b082e024c65 |
| Headers | show |
| Series | tracing: Fix some selftest issues | expand |
On Tue, 11 Jun 2024 22:30:56 +0900 "Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote: > From: Masami Hiramatsu (Google) <mhiramat@kernel.org> > > This cleanup all kprobe events code is not related to the selftest > itself, and it can fail by the reason unrelated to this test. > If the test is successful, the generated events are cleaned up. > And if not, we cannot guarantee that the kprobe events will work > correctly. So, anyway, there is no need to clean it up. > > Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org> Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org> -- Steve > --- > kernel/trace/trace_kprobe.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c > index 8c5816c04bd2..7fd0f8576e4c 100644 > --- a/kernel/trace/trace_kprobe.c > +++ b/kernel/trace/trace_kprobe.c > @@ -2114,10 +2114,6 @@ static __init int kprobe_trace_self_tests_init(void) > > > end: > - ret = dyn_events_release_all(&trace_kprobe_ops); > - if (WARN_ONCE(ret, "error on cleaning up probes.")) > - warn++; > - > /* > * Wait for the optimizer work to finish. Otherwise it might fiddle > * with probes in already freed __init text.
On Tue, 11 Jun 2024 10:25:00 -0400 Steven Rostedt <rostedt@goodmis.org> wrote: > On Tue, 11 Jun 2024 22:30:56 +0900 > "Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote: > > > From: Masami Hiramatsu (Google) <mhiramat@kernel.org> > > > > This cleanup all kprobe events code is not related to the selftest > > itself, and it can fail by the reason unrelated to this test. > > If the test is successful, the generated events are cleaned up. > > And if not, we cannot guarantee that the kprobe events will work > > correctly. So, anyway, there is no need to clean it up. > > > > Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org> > > Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org> Thanks for review! > > -- Steve > > > --- > > kernel/trace/trace_kprobe.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c > > index 8c5816c04bd2..7fd0f8576e4c 100644 > > --- a/kernel/trace/trace_kprobe.c > > +++ b/kernel/trace/trace_kprobe.c > > @@ -2114,10 +2114,6 @@ static __init int kprobe_trace_self_tests_init(void) > > > > > > end: > > - ret = dyn_events_release_all(&trace_kprobe_ops); > > - if (WARN_ONCE(ret, "error on cleaning up probes.")) > > - warn++; > > - > > /* > > * Wait for the optimizer work to finish. Otherwise it might fiddle > > * with probes in already freed __init text. > >
diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c index 8c5816c04bd2..7fd0f8576e4c 100644 --- a/kernel/trace/trace_kprobe.c +++ b/kernel/trace/trace_kprobe.c @@ -2114,10 +2114,6 @@ static __init int kprobe_trace_self_tests_init(void) end: - ret = dyn_events_release_all(&trace_kprobe_ops); - if (WARN_ONCE(ret, "error on cleaning up probes.")) - warn++; - /* * Wait for the optimizer work to finish. Otherwise it might fiddle * with probes in already freed __init text.