diff mbox series

[v3] drm/i915/mtl: Update workaround 14018575942

Message ID 20240524173349.89123-1-angus.chen@intel.com (mailing list archive)
State New, archived
Headers show
Series [v3] drm/i915/mtl: Update workaround 14018575942 | expand

Commit Message

Chen, Angus May 24, 2024, 5:33 p.m. UTC
The WA should be extended to cover VDBOX engine. We found that
28-channels 1080p VP9 encoding may hit this issue.

v3: update the WA number and explain the reason why
    this workaround is needed
v2: add WA number
v1: initial version

Signed-off-by: Chen, Angus <angus.chen@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_workarounds.c | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Andi Shyti May 27, 2024, 10:38 a.m. UTC | #1
Hi Angus,

On Fri, May 24, 2024 at 05:33:49PM +0000, Chen, Angus wrote:
> The WA should be extended to cover VDBOX engine. We found that
> 28-channels 1080p VP9 encoding may hit this issue.
> 
> v3: update the WA number and explain the reason why
>     this workaround is needed
> v2: add WA number
> v1: initial version
> 
> Signed-off-by: Chen, Angus <angus.chen@intel.com>

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

Thanks Matt for your feedback!

Andi
Andi Shyti June 11, 2024, 2:28 p.m. UTC | #2
Hi Angus,

On Fri, May 24, 2024 at 05:33:49PM +0000, Chen, Angus wrote:
> The WA should be extended to cover VDBOX engine. We found that
> 28-channels 1080p VP9 encoding may hit this issue.
> 
> v3: update the WA number and explain the reason why
>     this workaround is needed
> v2: add WA number
> v1: initial version
> 
> Signed-off-by: Chen, Angus <angus.chen@intel.com>

I had to do some manual work here, including the name/surname
reordring, because patchwork couldn't handle the --in-reply-to.

In any case, merged to drm-intel-gt-next.

Thanks,
Andi
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index d1ab560fcdfc..05d56103ddab 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -1586,6 +1586,14 @@  xelpmp_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal)
 	 */
 	wa_write_or(wal, XELPMP_GSC_MOD_CTRL, FORCE_MISS_FTLB);
 
+	/*
+	 * Wa_14018575942
+	 *
+	 * Issue is seen on media KPI test running on VDBOX engine
+	 * especially VP9 encoding WLs
+	 */
+	wa_write_or(wal, XELPMP_VDBX_MOD_CTRL, FORCE_MISS_FTLB);
+
 	/* Wa_22016670082 */
 	wa_write_or(wal, GEN12_SQCNT1, GEN12_STRICT_RAR_ENABLE);