| Message ID | 20240528120424.3353880-1-arnd@kernel.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: dsa: realtek: add LEDS_CLASS dependency | expand |
On Tue, May 28, 2024 at 2:04 PM Arnd Bergmann <arnd@kernel.org> wrote: > From: Arnd Bergmann <arnd@arndb.de> > > This driver fails to link when LED support is disabled: > > ERROR: modpost: "led_init_default_state_get" [drivers/net/dsa/realtek/rtl8366.ko] undefined! > ERROR: modpost: "devm_led_classdev_register_ext" [drivers/net/dsa/realtek/rtl8366.ko] undefined! > > Add a dependency that prevents this configuration. > > Fixes: 32d617005475 ("net: dsa: realtek: add LED drivers for rtl8366rb") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> The QCA driver in drivers/net/dsa/qca/* instead makes the feature optional on LED class, so it is in a separate file with stubs if the LED class is not selected. Luiz do you wanna try this or should I make a patch like that? Yours, Linus Walleij
> On Tue, May 28, 2024 at 2:04 PM Arnd Bergmann <arnd@kernel.org> wrote: > > > From: Arnd Bergmann <arnd@arndb.de> > > > > This driver fails to link when LED support is disabled: > > > > ERROR: modpost: "led_init_default_state_get" [drivers/net/dsa/realtek/rtl8366.ko] undefined! > > ERROR: modpost: "devm_led_classdev_register_ext" [drivers/net/dsa/realtek/rtl8366.ko] undefined! > > > > Add a dependency that prevents this configuration. > > > > Fixes: 32d617005475 ("net: dsa: realtek: add LED drivers for rtl8366rb") > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > The QCA driver in drivers/net/dsa/qca/* instead makes the feature > optional on LED class, so it is in a separate file with stubs if the > LED class is not selected. That would be great. > Luiz do you wanna try this or should I make a patch like that? You can do it. I'm a bit away from programming these days. Thanks. > Yours, > Linus Walleij Regards, Luiz
On Tue, May 28, 2024 at 2:04 PM Arnd Bergmann <arnd@kernel.org> wrote: > From: Arnd Bergmann <arnd@arndb.de> > > This driver fails to link when LED support is disabled: > > ERROR: modpost: "led_init_default_state_get" [drivers/net/dsa/realtek/rtl8366.ko] undefined! > ERROR: modpost: "devm_led_classdev_register_ext" [drivers/net/dsa/realtek/rtl8366.ko] undefined! > > Add a dependency that prevents this configuration. > > Fixes: 32d617005475 ("net: dsa: realtek: add LED drivers for rtl8366rb") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> I tried to create a separate .c file for the leds and stubbed functions for the LED stuff, but it ended up having to create a set of headers just to share things between the different parts of the drivers and it was so messy that it's not worth it. Yours, Linus Walleij
> On Tue, May 28, 2024 at 2:04 PM Arnd Bergmann <arnd@kernel.org> wrote: > > > From: Arnd Bergmann <arnd@arndb.de> > > > > This driver fails to link when LED support is disabled: > > > > ERROR: modpost: "led_init_default_state_get" [drivers/net/dsa/realtek/rtl8366.ko] undefined! > > ERROR: modpost: "devm_led_classdev_register_ext" [drivers/net/dsa/realtek/rtl8366.ko] undefined! > > > > Add a dependency that prevents this configuration. Thank you, Arnd. > > > > Fixes: 32d617005475 ("net: dsa: realtek: add LED drivers for rtl8366rb") > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > I tried to create a separate .c file for the leds and stubbed functions > for the LED stuff, but it ended up having to create a set of headers > just to share things between the different parts of the drivers and > it was so messy that it's not worth it. Thanks, Linus. I'll give it a try next month. For now, the fixed dependency is not a big deal as this switch was designed for small routers, which normally have LEDs. > > Yours, > Linus Walleij Reviewed-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Hi David/Jakub, On Tue, May 28, 2024 at 2:04 PM Arnd Bergmann <arnd@kernel.org> wrote: > From: Arnd Bergmann <arnd@arndb.de> > > This driver fails to link when LED support is disabled: > > ERROR: modpost: "led_init_default_state_get" [drivers/net/dsa/realtek/rtl8366.ko] undefined! > ERROR: modpost: "devm_led_classdev_register_ext" [drivers/net/dsa/realtek/rtl8366.ko] undefined! > > Add a dependency that prevents this configuration. > > Fixes: 32d617005475 ("net: dsa: realtek: add LED drivers for rtl8366rb") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Can you please apply this patch, the buildbots keep complaining about this, and we agreed (I think) to take this dependency approach for now. Yours, Linus Walleij
diff --git a/drivers/net/dsa/realtek/Kconfig b/drivers/net/dsa/realtek/Kconfig index 6989972eebc3..6c90a83c71da 100644 --- a/drivers/net/dsa/realtek/Kconfig +++ b/drivers/net/dsa/realtek/Kconfig @@ -39,6 +39,7 @@ config NET_DSA_REALTEK_RTL8365MB config NET_DSA_REALTEK_RTL8366RB tristate "Realtek RTL8366RB switch driver" depends on NET_DSA_REALTEK_SMI || NET_DSA_REALTEK_MDIO + depends on LEDS_CLASS select NET_DSA_TAG_RTL4_A help Select to enable support for Realtek RTL8366RB.