| Message ID | 20240611-apol-ina2xx-fix-v4-0-8df1d2282fc5@axis.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | hwmon: (ina2xx):Add Suppor for passing alert polarity from device tree to driver | expand |
On 11/06/2024 11:36, Amna Waseem wrote: > The INA230 has alert polarity bit in Mask/Enable register which can be > configured to be active high or active low depending upon the requirements > of the hardware using this chip. The patches in this series adds the support > for passing alert polarity value from device tree to the driver. Alert polarity > property is added device tree bindings and the driver is modified to read > this property and set the Alert polarity (APOL) bit value in Mask/Enable register > of INA230. > > Signed-off-by: Amna Waseem <Amna.Waseem@axis.com> > --- > Changes in v4: > - Remove unnecessary checks while setting alert polarity bit > - Link to v3: https://lore.kernel.org/r/20240603-apol-ina2xx-fix-v3-0-b9eff3158e4e@axis.com <form letter> This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 If a tag was not added on purpose, please state why and what changed. </form letter> Missing this is really odd, considering you are using b4. Please read the b4 guide. Best regards, Krzysztof
On 6/11/24 14:49, Krzysztof Kozlowski wrote: > On 11/06/2024 11:36, Amna Waseem wrote: >> The INA230 has alert polarity bit in Mask/Enable register which can be >> configured to be active high or active low depending upon the requirements >> of the hardware using this chip. The patches in this series adds the support >> for passing alert polarity value from device tree to the driver. Alert polarity >> property is added device tree bindings and the driver is modified to read >> this property and set the Alert polarity (APOL) bit value in Mask/Enable register >> of INA230. >> >> Signed-off-by: Amna Waseem <Amna.Waseem@axis.com> >> --- >> Changes in v4: >> - Remove unnecessary checks while setting alert polarity bit >> - Link to v3: https://lore.kernel.org/r/20240603-apol-ina2xx-fix-v3-0-b9eff3158e4e@axis.com > <form letter> > This is a friendly reminder during the review process. > > It looks like you received a tag and forgot to add it. > > If you do not know the process, here is a short explanation: > Please add Acked-by/Reviewed-by/Tested-by tags when posting new > versions, under or above your Signed-off-by tag. Tag is "received", when > provided in a message replied to you on the mailing list. Tools like b4 > can help here. However, there's no need to repost patches *only* to add > the tags. The upstream maintainer will do that for tags received on the > version they apply. > > https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 > > If a tag was not added on purpose, please state why and what changed. > </form letter> > > Missing this is really odd, considering you are using b4. Please read > the b4 guide. > > Best regards, > Krzysztof > Thanks Krzysztof for the information. I have read the documentation in the link you provided and I will keep it in mind next time if I submit patches. Regards Amna
On 12/06/2024 08:18, Amna Waseem wrote: > On 6/11/24 14:49, Krzysztof Kozlowski wrote: >> On 11/06/2024 11:36, Amna Waseem wrote: >>> The INA230 has alert polarity bit in Mask/Enable register which can be >>> configured to be active high or active low depending upon the requirements >>> of the hardware using this chip. The patches in this series adds the support >>> for passing alert polarity value from device tree to the driver. Alert polarity >>> property is added device tree bindings and the driver is modified to read >>> this property and set the Alert polarity (APOL) bit value in Mask/Enable register >>> of INA230. >>> >>> Signed-off-by: Amna Waseem <Amna.Waseem@axis.com> >>> --- >>> Changes in v4: >>> - Remove unnecessary checks while setting alert polarity bit >>> - Link to v3: https://lore.kernel.org/r/20240603-apol-ina2xx-fix-v3-0-b9eff3158e4e@axis.com >> <form letter> >> This is a friendly reminder during the review process. >> >> It looks like you received a tag and forgot to add it. >> >> If you do not know the process, here is a short explanation: >> Please add Acked-by/Reviewed-by/Tested-by tags when posting new >> versions, under or above your Signed-off-by tag. Tag is "received", when >> provided in a message replied to you on the mailing list. Tools like b4 >> can help here. However, there's no need to repost patches *only* to add >> the tags. The upstream maintainer will do that for tags received on the >> version they apply. >> >> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 >> >> If a tag was not added on purpose, please state why and what changed. >> </form letter> >> >> Missing this is really odd, considering you are using b4. Please read >> the b4 guide. >> >> Best regards, >> Krzysztof >> > Thanks Krzysztof for the information. I have read the documentation in > the link you provided and I will keep it in mind next time if I submit > patches. > So you require someone to re-review? Best regards, Krzysztof
On 6/12/24 08:20, Krzysztof Kozlowski wrote:
> So you require someone to re-review?
Yes that will be great if someone re-review.
Regards
Amna
On 12/06/2024 08:37, Amna Waseem wrote: > On 6/12/24 08:20, Krzysztof Kozlowski wrote: >> So you require someone to re-review? > > Yes that will be great if someone re-review. You are joking, right? We have hundreds of other patches to take care of and you ignore review tag, so you get duplicated work from the same reviewer? That's huge waste of time and actually quite disrespectful to our time. Best regards, Krzysztof
On 6/12/24 08:44, Krzysztof Kozlowski wrote: > On 12/06/2024 08:37, Amna Waseem wrote: >> On 6/12/24 08:20, Krzysztof Kozlowski wrote: >>> So you require someone to re-review? >> Yes that will be great if someone re-review. > You are joking, right? We have hundreds of other patches to take care of > and you ignore review tag, so you get duplicated work from the same > reviewer? That's huge waste of time and actually quite disrespectful to > our time. > > Best regards, > Krzysztof > I donot mean to be disrespectful to the reviewers. Please ignore my re-review request. If the patches needs further changes in the code, I will add the tag in the next submission. Regards Amna
On 6/11/24 23:44, Krzysztof Kozlowski wrote: > On 12/06/2024 08:37, Amna Waseem wrote: >> On 6/12/24 08:20, Krzysztof Kozlowski wrote: >>> So you require someone to re-review? >> >> Yes that will be great if someone re-review. > > You are joking, right? We have hundreds of other patches to take care of > and you ignore review tag, so you get duplicated work from the same > reviewer? That's huge waste of time and actually quite disrespectful to > our time. > I applied v3 of the devicetree patch (after comparing the two to make sure there are no changes). Amna, I would suggest to run checkpatch on your patches in the future to find problems such as the following. ERROR: trailing whitespace #178: FILE: Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml:74: + the alert polarity to active-high. $ Thanks, Guenter
The INA230 has alert polarity bit in Mask/Enable register which can be configured to be active high or active low depending upon the requirements of the hardware using this chip. The patches in this series adds the support for passing alert polarity value from device tree to the driver. Alert polarity property is added device tree bindings and the driver is modified to read this property and set the Alert polarity (APOL) bit value in Mask/Enable register of INA230. Signed-off-by: Amna Waseem <Amna.Waseem@axis.com> --- Changes in v4: - Remove unnecessary checks while setting alert polarity bit - Link to v3: https://lore.kernel.org/r/20240603-apol-ina2xx-fix-v3-0-b9eff3158e4e@axis.com Changes in v3: - Convert the alert polarity property in dt bindings to be a flag - Set alert polarity depending upon on the presence of flag in device tree. Otherwise, default value is set - Make setting of alert polarity to be chip specific since only ina226,ina230 and ina231 supports alert polarity setting. - Link to v2: https://lore.kernel.org/r/20240529-apol-ina2xx-fix-v2-0-ee2d76142de2@axis.com Changes in v2: - Add vendor specific prefix to alert polarity property in binding. - Minor improvement in description of alert polarity binding property - Remove usage of mutex while setting alert polarity in Mask/Enable register - Correct indentation - Link to v1: https://lore.kernel.org/r/20240529-apol-ina2xx-fix-v1-0-77b4b382190f@axis.com --- Amna Waseem (2): dt-bindings: hwmon: ti,ina2xx: Add ti,alert-polarity-active-high property hwmon: (ina2xx) Add device tree support to pass alert polarity .../devicetree/bindings/hwmon/ti,ina2xx.yaml | 9 ++++++ drivers/hwmon/ina2xx.c | 32 ++++++++++++++++++++++ 2 files changed, 41 insertions(+) --- base-commit: a38297e3fb012ddfa7ce0321a7e5a8daeb1872b6 change-id: 20240524-apol-ina2xx-fix-34e76346cb26 Best regards,