| Message ID | 20240607110227.49848-2-ryan@testtoast.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: sunxi: support Allwinner Display Engine 3 IP block for H616/H700 | expand |
On Fri, Jun 07, 2024 at 10:59:57PM +1200, Ryan Walklin wrote: > The Allwinner H616 and variants have a new display engine revision > (DE33). > > Add display engine bus, clock and mixer bindings for the DE33. > > Signed-off-by: Ryan Walklin <ryan@testtoast.com> > --- > .../devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml | 1 + > .../devicetree/bindings/clock/allwinner,sun8i-a83t-de2-clk.yaml | 1 + > .../bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml | 1 + > 3 files changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml b/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml > index 9845a187bdf65..65f4522e79879 100644 > --- a/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml > +++ b/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml > @@ -25,6 +25,7 @@ properties: > - const: allwinner,sun50i-a64-de2 > - items: > - const: allwinner,sun50i-h6-de3 > + - const: allwinner,sun50i-h616-de33 > - const: allwinner,sun50i-a64-de2 This does not do what you think it does! It needs to be items: - enum: - h6 - h616 - const: a64 > > reg: > diff --git a/Documentation/devicetree/bindings/clock/allwinner,sun8i-a83t-de2-clk.yaml b/Documentation/devicetree/bindings/clock/allwinner,sun8i-a83t-de2-clk.yaml > index 70369bd633e40..7fcd55d468d49 100644 > --- a/Documentation/devicetree/bindings/clock/allwinner,sun8i-a83t-de2-clk.yaml > +++ b/Documentation/devicetree/bindings/clock/allwinner,sun8i-a83t-de2-clk.yaml > @@ -25,6 +25,7 @@ properties: > - const: allwinner,sun50i-a64-de2-clk > - const: allwinner,sun50i-h5-de2-clk > - const: allwinner,sun50i-h6-de3-clk > + - const: allwinner,sun50i-h616-de33-clk I think this is not right, as a corresponding driver change is missing. Either you're missing a clock driver patch or you didn't test your dts. Given the bus binding, I suspect that latter. > - items: > - const: allwinner,sun8i-r40-de2-clk > - const: allwinner,sun8i-h3-de2-clk > diff --git a/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml b/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml > index b75c1ec686ad2..c37eb8ae1b8ee 100644 > --- a/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml > +++ b/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml > @@ -24,6 +24,7 @@ properties: > - allwinner,sun50i-a64-de2-mixer-0 > - allwinner,sun50i-a64-de2-mixer-1 > - allwinner,sun50i-h6-de3-mixer-0 > + - allwinner,sun50i-h616-de33-mixer-0 Your commit message should mention why a fallback is not suitable here. Thanks, Conor.
On Sat, 8 Jun 2024, at 2:23 AM, Conor Dooley wrote: Thanks for the review! >> --- a/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml >> +++ b/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml >> @@ -25,6 +25,7 @@ properties: >> - const: allwinner,sun50i-a64-de2 >> - items: >> - const: allwinner,sun50i-h6-de3 >> + - const: allwinner,sun50i-h616-de33 >> - const: allwinner,sun50i-a64-de2 > > This does not do what you think it does! > It needs to be > items: > - enum: > - h6 > - h616 > - const: a64 > Thanks, will correct in v2. >> + - const: allwinner,sun50i-h616-de33-clk > > I think this is not right, as a corresponding driver change is missing. > Either you're missing a clock driver patch or you didn't test your dts. The clock driver patch with this compatible string is in patch 8/8. >> - allwinner,sun50i-h6-de3-mixer-0 >> + - allwinner,sun50i-h616-de33-mixer-0 > > Your commit message should mention why a fallback is not suitable here. Will do, thanks. > > Thanks, > Conor. > Regards, Ryan
On Sun, Jun 09, 2024 at 03:19:55PM +1200, Ryan Walklin wrote: > On Sat, 8 Jun 2024, at 2:23 AM, Conor Dooley wrote: > >> + - const: allwinner,sun50i-h616-de33-clk > > > > I think this is not right, as a corresponding driver change is missing. > > Either you're missing a clock driver patch or you didn't test your dts. > > The clock driver patch with this compatible string is in patch 8/8. Ahh, I didn't notice that " drm: sun4i: add Display Engine 3.3 (DE33) support" had a clk driver. That needs to go into a patch of its own.
> On 11 Jun 2024, at 4:32 AM, Conor Dooley <conor@kernel.org> wrote: > Ahh, I didn't notice that " drm: sun4i: add Display Engine 3.3 (DE33) > support" had a clk driver. > That needs to go into a patch of its own. Thanks, can certainly split that out. Regards, Ryan
diff --git a/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml b/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml index 9845a187bdf65..65f4522e79879 100644 --- a/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml +++ b/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml @@ -25,6 +25,7 @@ properties: - const: allwinner,sun50i-a64-de2 - items: - const: allwinner,sun50i-h6-de3 + - const: allwinner,sun50i-h616-de33 - const: allwinner,sun50i-a64-de2 reg: diff --git a/Documentation/devicetree/bindings/clock/allwinner,sun8i-a83t-de2-clk.yaml b/Documentation/devicetree/bindings/clock/allwinner,sun8i-a83t-de2-clk.yaml index 70369bd633e40..7fcd55d468d49 100644 --- a/Documentation/devicetree/bindings/clock/allwinner,sun8i-a83t-de2-clk.yaml +++ b/Documentation/devicetree/bindings/clock/allwinner,sun8i-a83t-de2-clk.yaml @@ -25,6 +25,7 @@ properties: - const: allwinner,sun50i-a64-de2-clk - const: allwinner,sun50i-h5-de2-clk - const: allwinner,sun50i-h6-de3-clk + - const: allwinner,sun50i-h616-de33-clk - items: - const: allwinner,sun8i-r40-de2-clk - const: allwinner,sun8i-h3-de2-clk diff --git a/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml b/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml index b75c1ec686ad2..c37eb8ae1b8ee 100644 --- a/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml +++ b/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml @@ -24,6 +24,7 @@ properties: - allwinner,sun50i-a64-de2-mixer-0 - allwinner,sun50i-a64-de2-mixer-1 - allwinner,sun50i-h6-de3-mixer-0 + - allwinner,sun50i-h616-de33-mixer-0 reg: maxItems: 1
The Allwinner H616 and variants have a new display engine revision (DE33). Add display engine bus, clock and mixer bindings for the DE33. Signed-off-by: Ryan Walklin <ryan@testtoast.com> --- .../devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml | 1 + .../devicetree/bindings/clock/allwinner,sun8i-a83t-de2-clk.yaml | 1 + .../bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml | 1 + 3 files changed, 3 insertions(+)