[0/5] ALSA: some driver fixes for control input validations

Message

Takashi Iwai June 14, 2024, 12:47 p.m. UTC

Hi,

this is a patch set as a follow up of the thread about the errors
reported by kselftest mixer-test.  It changes HD-audio and vmaster
control behavior to return -EINVAL for invalid input values.

There is a change in kselftest itself to skip the write tests for
volatile controls, too.  It's for the channel map controls that can't
hold the stable values.


Takashi

===

Takashi Iwai (5):
  ALSA: vmaster: Return error for invalid input values
  ALSA: hda: Return -EINVAL for invalid volume/switch inputs
  ALSA: control: Apply sanity check of input values for user elements
  kselftest/alsa: mixer-test: Skip write tests for volatile controls
  ALSA: chmap: Mark Channel Map controls as volatile

 sound/core/control.c                      |  3 ++-
 sound/core/pcm_lib.c                      |  1 +
 sound/core/vmaster.c                      |  8 ++++++++
 sound/pci/hda/hda_codec.c                 | 23 ++++++++++++++++++-----
 tools/testing/selftests/alsa/mixer-test.c | 21 +++++++++++++++++++++
 5 files changed, 50 insertions(+), 6 deletions(-)

Comments

Jaroslav Kysela June 14, 2024, 1:06 p.m. UTC | #1

On 14. 06. 24 14:47, Takashi Iwai wrote:
> Hi,
> 
> this is a patch set as a follow up of the thread about the errors
> reported by kselftest mixer-test.  It changes HD-audio and vmaster
> control behavior to return -EINVAL for invalid input values.
> 
> There is a change in kselftest itself to skip the write tests for
> volatile controls, too.  It's for the channel map controls that can't
> hold the stable values.

Thanks.

Reviewed-by: Jaroslav Kysela <[e-mail]>