[BlueZ,1/1] src/adapter: Check if device is connected before clean up

Commit Message

Vlad Pruteanu June 17, 2024, 7:59 a.m. UTC

Broadcast sources are currently deleted on the clean up triggered
by turning scan off. Thix fix prevents the removal of sources to
which we are synced by also checking if the device that will be
removed is connected (sources to which we are synced are already
marked as connected).
---
 src/adapter.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

[e-mail] June 17, 2024, 9:44 a.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=862501

---Test result---

Test Summary:
CheckPatch                    PASS      0.27 seconds
GitLint                       PASS      0.20 seconds
BuildEll                      PASS      24.35 seconds
BluezMake                     PASS      1735.49 seconds
MakeCheck                     PASS      12.98 seconds
MakeDistcheck                 PASS      184.47 seconds
CheckValgrind                 PASS      250.09 seconds
CheckSmatch                   PASS      351.15 seconds
bluezmakeextell               PASS      118.87 seconds
IncrementalBuild              PASS      1436.67 seconds
ScanBuild                     PASS      975.58 seconds



---
Regards,
Linux Bluetooth

Patch

diff --git a/src/adapter.c b/src/adapter.c
index 821d94592..bdc5bf920 100644
--- a/src/adapter.c
+++ b/src/adapter.c
@@ -1730,7 +1730,8 @@  static void discovery_cleanup(struct btd_adapter *adapter, int timeout)
 
 		next = g_slist_next(l);
 
-		if (device_is_temporary(dev) && !device_is_connectable(dev))
+		if (device_is_temporary(dev) && !device_is_connectable(dev)
+			&& !btd_device_is_connected(dev))
 			btd_adapter_remove_device(adapter, dev);
 	}
 }