Bluetooth: btrtl: Set MSFT_EXT_ADDRESS_FILTER quirk for RTL8852B

Commit Message

Hilda Wu June 17, 2024, 10:50 a.m. UTC

Set HCI_QUIRK_USE_MSFT_EXT_ADDRESS_FILTER quirk for RTL8852B.

Signed-off-by: Hilda Wu <[e-mail]>
---
 drivers/bluetooth/btrtl.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Paul Menzel June 17, 2024, 11:04 a.m. UTC | #1

Dear Hilda,


Am 17.06.24 um 12:50 schrieb Hilda Wu:
> Set HCI_QUIRK_USE_MSFT_EXT_ADDRESS_FILTER quirk for RTL8852B.

Is that documented in some errata? If so, can you please reference it?

It’d be great, if you also documented your test setup.

> Signed-off-by: Hilda Wu <[e-mail]>
> ---
>   drivers/bluetooth/btrtl.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
> index f2f37143c454..baa0c6119b51 100644
> --- a/drivers/bluetooth/btrtl.c
> +++ b/drivers/bluetooth/btrtl.c
> @@ -1297,6 +1297,7 @@ void btrtl_set_quirks(struct hci_dev *hdev, struct btrtl_device_info *btrtl_dev)
>   			btrealtek_set_flag(hdev, REALTEK_ALT6_CONTINUOUS_TX_CHIP);
>   
>   		if (btrtl_dev->project_id == CHIP_ID_8852A ||
> +		    btrtl_dev->project_id == CHIP_ID_8852B ||
>   		    btrtl_dev->project_id == CHIP_ID_8852C)
>   			set_bit(HCI_QUIRK_USE_MSFT_EXT_ADDRESS_FILTER, &hdev->quirks);


Kind regards,

Paul

[e-mail] June 17, 2024, 11:33 a.m. UTC | #2

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=862570

---Test result---

Test Summary:
CheckPatch                    PASS      0.52 seconds
GitLint                       PASS      0.24 seconds
SubjectPrefix                 PASS      0.08 seconds
BuildKernel                   PASS      29.71 seconds
CheckAllWarning               PASS      33.77 seconds
CheckSparse                   PASS      38.63 seconds
CheckSmatch                   PASS      102.31 seconds
BuildKernel32                 PASS      30.54 seconds
TestRunnerSetup               PASS      524.16 seconds
TestRunner_l2cap-tester       PASS      18.87 seconds
TestRunner_iso-tester         FAIL      32.99 seconds
TestRunner_bnep-tester        PASS      5.05 seconds
TestRunner_mgmt-tester        PASS      112.10 seconds
TestRunner_rfcomm-tester      PASS      7.41 seconds
TestRunner_sco-tester         PASS      17.08 seconds
TestRunner_ioctl-tester       PASS      7.94 seconds
TestRunner_mesh-tester        PASS      6.27 seconds
TestRunner_smp-tester         PASS      6.98 seconds
TestRunner_userchan-tester    PASS      5.02 seconds
IncrementalBuild              PASS      30.26 seconds

Details
##############################
Test: TestRunner_iso-tester - FAIL
Desc: Run iso-tester with test-runner
Output:
Total: 122, Passed: 117 (95.9%), Failed: 1, Not Run: 4

Failed Test Cases
ISO Connect Suspend - Success                        Failed       4.169 seconds


---
Regards,
Linux Bluetooth

Patch

diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
index f2f37143c454..baa0c6119b51 100644
--- a/drivers/bluetooth/btrtl.c
+++ b/drivers/bluetooth/btrtl.c
@@ -1297,6 +1297,7 @@  void btrtl_set_quirks(struct hci_dev *hdev, struct btrtl_device_info *btrtl_dev)
 			btrealtek_set_flag(hdev, REALTEK_ALT6_CONTINUOUS_TX_CHIP);
 
 		if (btrtl_dev->project_id == CHIP_ID_8852A ||
+		    btrtl_dev->project_id == CHIP_ID_8852B ||
 		    btrtl_dev->project_id == CHIP_ID_8852C)
 			set_bit(HCI_QUIRK_USE_MSFT_EXT_ADDRESS_FILTER, &hdev->quirks);