| Message ID | 8dded7c01676b68e3042dbd0021e97c198a03b49.1718643571.git.pav@iki.fi (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 52bda9d45572ab4629bf2f686616c0398f489dad |
| Headers | show |
| Series | [BlueZ,v2] shared/bap: make BT_BAP_* direction defines valid bitmasks | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=862686 ---Test result--- Test Summary: CheckPatch PASS 0.28 seconds GitLint PASS 0.21 seconds BuildEll PASS 25.54 seconds BluezMake PASS 1745.05 seconds MakeCheck PASS 13.08 seconds MakeDistcheck PASS 180.54 seconds CheckValgrind PASS 254.51 seconds CheckSmatch PASS 354.05 seconds bluezmakeextell PASS 120.31 seconds IncrementalBuild PASS 1474.31 seconds ScanBuild PASS 1047.81 seconds --- Regards, Linux Bluetooth
Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Mon, 17 Jun 2024 19:59:40 +0300 you wrote: > The directions appear to be intended as bitmasks, as > bt_bap_stream_io_dir() will bitwise or linked stream directions. > > Fix the defines to be separate bits. > > Fixes confusion due to BT_BAP_BCAST_SOURCE == BT_BAP_SINK|BT_BAP_SOURCE, > which causes e.g. unicast transports to be in PENDING state after QoS > although this does not make sense for BAP unicast Client. > > [...] Here is the summary with links: - [BlueZ,v2] shared/bap: make BT_BAP_* direction defines valid bitmasks https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=52bda9d45572 You are awesome, thank you!
diff --git a/src/shared/bap-defs.h b/src/shared/bap-defs.h index 2467e816f..27fefa34f 100644 --- a/src/shared/bap-defs.h +++ b/src/shared/bap-defs.h @@ -15,10 +15,10 @@ #define __packed __attribute__((packed)) #endif -#define BT_BAP_SINK 0x01 -#define BT_BAP_SOURCE 0x02 -#define BT_BAP_BCAST_SOURCE 0x03 -#define BT_BAP_BCAST_SINK 0x04 +#define BT_BAP_SINK BIT(0) +#define BT_BAP_SOURCE BIT(1) +#define BT_BAP_BCAST_SOURCE BIT(2) +#define BT_BAP_BCAST_SINK BIT(3) #define BT_BAP_STREAM_TYPE_UCAST 0x01 #define BT_BAP_STREAM_TYPE_BCAST 0x02
The directions appear to be intended as bitmasks, as bt_bap_stream_io_dir() will bitwise or linked stream directions. Fix the defines to be separate bits. Fixes confusion due to BT_BAP_BCAST_SOURCE == BT_BAP_SINK|BT_BAP_SOURCE, which causes e.g. unicast transports to be in PENDING state after QoS although this does not make sense for BAP unicast Client. --- Notes: v2: use BIT macro src/shared/bap-defs.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)