mbox series

[isar-cip-core,v2,0/3] Split Gitlab test jobs

Message ID 20240618045008.1765300-1-Sai.Sathujoda@toshiba-tsip.com (mailing list archive)
Headers show
Series Split Gitlab test jobs | expand

Message

Sai.Sathujoda@toshiba-tsip.com June 18, 2024, 4:50 a.m. UTC
From: sai ashrith sathujoda <sai.sathujoda@toshiba-tsip.com>

This series of patches will run one LAVA job per Gitlab test job.
Accordingly the submit_lava.sh and template files are modified to
sync with the changes.

Changes in v2:
Patches sent in v1 are re-ordered to work as expected.

sai ashrith sathujoda (3):
  tests: Modify the replacable strings and increase timeouts in the
    templates
  submit_lava.sh: Modify the script to handle only one job at a time
  .gitlab-ci.yml: Break current test jobs to run one LAVA job per Gitlab
    job

 .gitlab-ci.yml                          |  80 +++++-
 scripts/submit_lava.sh                  | 336 ++++++++++--------------
 tests/templates/IEC_template.yml        |  16 +-
 tests/templates/secureboot_template.yml |  14 +-
 tests/templates/swupdate_template.yml   |  18 +-
 5 files changed, 227 insertions(+), 237 deletions(-)

Comments

Jan Kiszka June 18, 2024, 5:21 a.m. UTC | #1
On 18.06.24 06:50, Sai.Sathujoda@toshiba-tsip.com wrote:
> From: sai ashrith sathujoda <sai.sathujoda@toshiba-tsip.com>
> 
> This series of patches will run one LAVA job per Gitlab test job.
> Accordingly the submit_lava.sh and template files are modified to
> sync with the changes.
> 
> Changes in v2:
> Patches sent in v1 are re-ordered to work as expected.
> 
> sai ashrith sathujoda (3):
>   tests: Modify the replacable strings and increase timeouts in the
>     templates
>   submit_lava.sh: Modify the script to handle only one job at a time
>   .gitlab-ci.yml: Break current test jobs to run one LAVA job per Gitlab
>     job
> 
>  .gitlab-ci.yml                          |  80 +++++-
>  scripts/submit_lava.sh                  | 336 ++++++++++--------------
>  tests/templates/IEC_template.yml        |  16 +-
>  tests/templates/secureboot_template.yml |  14 +-
>  tests/templates/swupdate_template.yml   |  18 +-
>  5 files changed, 227 insertions(+), 237 deletions(-)
> 

Thanks, applied to next.

I've also addressed now the shellcheck warnings on top. Will share patch
if CI passes.

Jan
Jan Kiszka June 18, 2024, 7:41 a.m. UTC | #2
On 18.06.24 07:21, Jan Kiszka wrote:
> On 18.06.24 06:50, Sai.Sathujoda@toshiba-tsip.com wrote:
>> From: sai ashrith sathujoda <sai.sathujoda@toshiba-tsip.com>
>>
>> This series of patches will run one LAVA job per Gitlab test job.
>> Accordingly the submit_lava.sh and template files are modified to
>> sync with the changes.
>>
>> Changes in v2:
>> Patches sent in v1 are re-ordered to work as expected.
>>
>> sai ashrith sathujoda (3):
>>   tests: Modify the replacable strings and increase timeouts in the
>>     templates
>>   submit_lava.sh: Modify the script to handle only one job at a time
>>   .gitlab-ci.yml: Break current test jobs to run one LAVA job per Gitlab
>>     job
>>
>>  .gitlab-ci.yml                          |  80 +++++-
>>  scripts/submit_lava.sh                  | 336 ++++++++++--------------
>>  tests/templates/IEC_template.yml        |  16 +-
>>  tests/templates/secureboot_template.yml |  14 +-
>>  tests/templates/swupdate_template.yml   |  18 +-
>>  5 files changed, 227 insertions(+), 237 deletions(-)
>>
> 
> Thanks, applied to next.
> 
> I've also addressed now the shellcheck warnings on top. Will share patch
> if CI passes.
> 

Follow-up wish: Please make sure that the output of the DUT is
live-streamed into the gitlab CI log, like we have with xenomai-images -
one click less, avoiding to go to the lava portal for that.

Jan
Sai.Sathujoda@toshiba-tsip.com June 18, 2024, 11:21 a.m. UTC | #3
Sure Jan. I will look into how it is being done in Xenomai images project and subsequently I will send a patch for this.

Thanks and regards,
Sai Ashrith Sathujoda (T S I P)

-----Original Message-----
From: Jan Kiszka <jan.kiszka@siemens.com> 
Sent: Tuesday, June 18, 2024 1:11 PM
To: ashrith sai(TSIP) <Sai.Sathujoda@toshiba-tsip.com>; cip-dev@lists.cip-project.org
Cc: dinesh kumar(TSIP TMIEC ODG Porting) <dinesh.kumar@toshiba-tsip.com>; hayashi kazuhiro(林 和宏 DME ○DIG□MPS○MP4) <kazuhiro3.hayashi@toshiba.co.jp>
Subject: Re: [isar-cip-core v2 0/3] Split Gitlab test jobs

On 18.06.24 07:21, Jan Kiszka wrote:
> On 18.06.24 06:50, Sai.Sathujoda@toshiba-tsip.com wrote:
>> From: sai ashrith sathujoda <sai.sathujoda@toshiba-tsip.com>
>>
>> This series of patches will run one LAVA job per Gitlab test job.
>> Accordingly the submit_lava.sh and template files are modified to 
>> sync with the changes.
>>
>> Changes in v2:
>> Patches sent in v1 are re-ordered to work as expected.
>>
>> sai ashrith sathujoda (3):
>>   tests: Modify the replacable strings and increase timeouts in the
>>     templates
>>   submit_lava.sh: Modify the script to handle only one job at a time
>>   .gitlab-ci.yml: Break current test jobs to run one LAVA job per Gitlab
>>     job
>>
>>  .gitlab-ci.yml                          |  80 +++++-
>>  scripts/submit_lava.sh                  | 336 ++++++++++--------------
>>  tests/templates/IEC_template.yml        |  16 +-
>>  tests/templates/secureboot_template.yml |  14 +-
>>  tests/templates/swupdate_template.yml   |  18 +-
>>  5 files changed, 227 insertions(+), 237 deletions(-)
>>
> 
> Thanks, applied to next.
> 
> I've also addressed now the shellcheck warnings on top. Will share 
> patch if CI passes.
> 

Follow-up wish: Please make sure that the output of the DUT is live-streamed into the gitlab CI log, like we have with xenomai-images - one click less, avoiding to go to the lava portal for that.

Jan

--
Siemens AG, Technology
Linux Expert Center