| Message ID | 20240617-n-asoc-const-auto-selectable-formats-v1-0-8004f346ee38@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | ASoC: Few constifications (mostly arguments) | expand |
On Mon, Jun 17, 2024 at 03:03:18PM +0200, Krzysztof Kozlowski wrote: > Make few pointers in ASoC functions as pointers to const, so the code is > clearer to read, a bit safer and allows further constifications (e.g. > placing some data as rodata). > > Best regards, > Krzysztof > > --- > Krzysztof Kozlowski (6): > ASoC: Constify of_phandle_args in snd_soc_dai_driver > ASoC: Constify of_phandle_args in snd_soc_dai_link_component > ASoC: Constify passed data to core function > ASoC: Constify DAI passed to get_channel_map > ASoC: Constify return of snd_soc_dai_get_pcm_stream() > ALSA: Cleanup trailing white-spaces Why is this random ALSA patch which seems off topic for the rest of the series mixed in here?
On 17/06/2024 17:11, Mark Brown wrote: > On Mon, Jun 17, 2024 at 03:03:18PM +0200, Krzysztof Kozlowski wrote: >> Make few pointers in ASoC functions as pointers to const, so the code is >> clearer to read, a bit safer and allows further constifications (e.g. >> placing some data as rodata). >> >> Best regards, >> Krzysztof >> >> --- >> Krzysztof Kozlowski (6): >> ASoC: Constify of_phandle_args in snd_soc_dai_driver >> ASoC: Constify of_phandle_args in snd_soc_dai_link_component >> ASoC: Constify passed data to core function >> ASoC: Constify DAI passed to get_channel_map >> ASoC: Constify return of snd_soc_dai_get_pcm_stream() >> ALSA: Cleanup trailing white-spaces > > Why is this random ALSA patch which seems off topic for the rest of the > series mixed in here? While checking all possible references around ASoC PCM, I apparently ended up there and spotted things to improve. No dependencies, I should sent it separately. Best regards, Krzysztof
On Mon, 17 Jun 2024 15:03:18 +0200, Krzysztof Kozlowski wrote: > Make few pointers in ASoC functions as pointers to const, so the code is > clearer to read, a bit safer and allows further constifications (e.g. > placing some data as rodata). > > Best regards, > Krzysztof > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/6] ASoC: Constify of_phandle_args in snd_soc_dai_driver commit: 2fbafecb0f05818e25f6c926c6f9ad9ef597429c [2/6] ASoC: Constify of_phandle_args in snd_soc_dai_link_component commit: 020b37d06f97de289940805bc821190d5858eda0 [3/6] ASoC: Constify passed data to core function commit: f3ac3da7e4d0957b3402fb31a4ca480e739e086f [4/6] ASoC: Constify DAI passed to get_channel_map commit: 785d64c4941221044940ab199e6625af17296470 [5/6] ASoC: Constify return of snd_soc_dai_get_pcm_stream() commit: de267e7a6ea8e6fa29af2287adfc9fc9d87e6dc9 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
Make few pointers in ASoC functions as pointers to const, so the code is clearer to read, a bit safer and allows further constifications (e.g. placing some data as rodata). Best regards, Krzysztof --- Krzysztof Kozlowski (6): ASoC: Constify of_phandle_args in snd_soc_dai_driver ASoC: Constify of_phandle_args in snd_soc_dai_link_component ASoC: Constify passed data to core function ASoC: Constify DAI passed to get_channel_map ASoC: Constify return of snd_soc_dai_get_pcm_stream() ALSA: Cleanup trailing white-spaces include/sound/soc-dai.h | 26 +++++++------ include/sound/soc.h | 19 +++++----- sound/core/control_compat.c | 2 +- sound/core/device.c | 4 +- sound/core/hwdep.c | 10 ++--- sound/core/init.c | 3 +- sound/core/memalloc.c | 2 +- sound/core/memory.c | 2 +- sound/core/pcm.c | 22 +++++------ sound/core/pcm_compat.c | 2 +- sound/core/pcm_lib.c | 41 ++++++++++---------- sound/core/pcm_misc.c | 2 +- sound/core/pcm_native.c | 76 +++++++++++++++++++------------------- sound/core/seq_device.c | 2 +- sound/soc/codecs/lpass-rx-macro.c | 2 +- sound/soc/codecs/lpass-tx-macro.c | 2 +- sound/soc/codecs/lpass-va-macro.c | 2 +- sound/soc/codecs/lpass-wsa-macro.c | 2 +- sound/soc/codecs/wcd9335.c | 2 +- sound/soc/codecs/wcd934x.c | 2 +- sound/soc/intel/avs/pcm.c | 4 +- sound/soc/soc-core.c | 4 +- sound/soc/soc-dai.c | 14 +++---- sound/soc/soc-pcm.c | 26 ++++++------- sound/soc/soc-utils.c | 8 ++-- 25 files changed, 141 insertions(+), 140 deletions(-) --- base-commit: cf32e2eb8404572eaacd219dde4e703fad349299 change-id: 20240617-n-asoc-const-auto-selectable-formats-13fcc5000044 Best regards,