| Message ID | 20240617220535.359021-4-macroalpha82@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add Battery and USB Supply for AXP717 | expand |
On 18/06/2024 00:05, Chris Morgan wrote: > From: Chris Morgan <macromorgan@hotmail.com> > > Add binding information for AXP717. Also, as the driver can read > simple-battery parameters for the AXP717 and other batteries, define > the simple-battery parameter. > > Signed-off-by: Chris Morgan <m Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. For bindings, the preferred subjects are explained here: https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters acromorgan@hotmail.com> > --- > .../power/supply/x-powers,axp20x-battery-power-supply.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/power/supply/x-powers,axp20x-battery-power-supply.yaml b/Documentation/devicetree/bindings/power/supply/x-powers,axp20x-battery-power-supply.yaml > index e0b95ecbbebd..8d6b06117f6d 100644 > --- a/Documentation/devicetree/bindings/power/supply/x-powers,axp20x-battery-power-supply.yaml > +++ b/Documentation/devicetree/bindings/power/supply/x-powers,axp20x-battery-power-supply.yaml > @@ -23,11 +23,18 @@ properties: > - const: x-powers,axp202-battery-power-supply > - const: x-powers,axp209-battery-power-supply > - const: x-powers,axp221-battery-power-supply > + - const: x-powers,axp717-battery-power-supply > - items: > - const: x-powers,axp803-battery-power-supply > - const: x-powers,axp813-battery-power-supply > - const: x-powers,axp813-battery-power-supply > > + monitored-battery: > + description: | Do not need '|' unless you need to preserve formatting. > + Specifies the phandle of an optional simple-battery connected to > + this gauge. > + $ref: /schemas/types.yaml#/definitions/phandle Best regards, Krzysztof
On Mon, Jun 17, 2024 at 05:05:30PM -0500, Chris Morgan wrote: > From: Chris Morgan <macromorgan@hotmail.com> > > Add binding information for AXP717. Also, as the driver can read > simple-battery parameters for the AXP717 and other batteries, define > the simple-battery parameter. The binding should not care about whether the implementation (driver) can or cannot do something. Probably reword it like "the PMIC can be programmed with specific battery parameters". > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > --- > .../power/supply/x-powers,axp20x-battery-power-supply.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/power/supply/x-powers,axp20x-battery-power-supply.yaml b/Documentation/devicetree/bindings/power/supply/x-powers,axp20x-battery-power-supply.yaml > index e0b95ecbbebd..8d6b06117f6d 100644 > --- a/Documentation/devicetree/bindings/power/supply/x-powers,axp20x-battery-power-supply.yaml > +++ b/Documentation/devicetree/bindings/power/supply/x-powers,axp20x-battery-power-supply.yaml > @@ -23,11 +23,18 @@ properties: > - const: x-powers,axp202-battery-power-supply > - const: x-powers,axp209-battery-power-supply > - const: x-powers,axp221-battery-power-supply > + - const: x-powers,axp717-battery-power-supply > - items: > - const: x-powers,axp803-battery-power-supply > - const: x-powers,axp813-battery-power-supply > - const: x-powers,axp813-battery-power-supply > > + monitored-battery: > + description: | > + Specifies the phandle of an optional simple-battery connected to > + this gauge. > + $ref: /schemas/types.yaml#/definitions/phandle > + > required: > - compatible > > -- > 2.34.1 >
diff --git a/Documentation/devicetree/bindings/power/supply/x-powers,axp20x-battery-power-supply.yaml b/Documentation/devicetree/bindings/power/supply/x-powers,axp20x-battery-power-supply.yaml index e0b95ecbbebd..8d6b06117f6d 100644 --- a/Documentation/devicetree/bindings/power/supply/x-powers,axp20x-battery-power-supply.yaml +++ b/Documentation/devicetree/bindings/power/supply/x-powers,axp20x-battery-power-supply.yaml @@ -23,11 +23,18 @@ properties: - const: x-powers,axp202-battery-power-supply - const: x-powers,axp209-battery-power-supply - const: x-powers,axp221-battery-power-supply + - const: x-powers,axp717-battery-power-supply - items: - const: x-powers,axp803-battery-power-supply - const: x-powers,axp813-battery-power-supply - const: x-powers,axp813-battery-power-supply + monitored-battery: + description: | + Specifies the phandle of an optional simple-battery connected to + this gauge. + $ref: /schemas/types.yaml#/definitions/phandle + required: - compatible