mbox series

[v3,00/18] media: Fix the last set of coccinelle warnings

Message ID 20240527-cocci-flexarray-v3-0-cda09c535816@chromium.org (mailing list archive)
Headers show
Series media: Fix the last set of coccinelle warnings | expand

Message

Ricardo Ribalda May 27, 2024, 9:08 p.m. UTC
With this set we are done with all the cocci warning/errors.

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
Changes in v3:
- Do not rename structure fields. (Thanks Bryan)
- Link to v2: https://lore.kernel.org/r/20240507-cocci-flexarray-v2-0-7aea262cf065@chromium.org

Changes in v2:
- allegro: Replace hard coded 1 with a define. (Thanks Michael)
- Link to v1: https://lore.kernel.org/r/20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org

---
Ricardo Ribalda (18):
      media: allegro: nal-hevc: Replace array[1] with arrray[N]
      media: xilinx: Refactor struct xvip_dma
      media: dvb-frontend/mxl5xx: Refactor struct MBIN_FILE_T
      media: dvb-frontend/mxl5xx: Use flex array for MBIN_SEGMENT_T
      media: pci: cx18: Use flex arrays for struct cx18_scb
      media: siano: Refactor struct sms_msg_data
      media: siano: Remove unused structures
      media: siano: Use flex arrays for sms_firmware
      media: venus: Remove unused structs
      media: venus: Use flex array for hfi_session_release_buffer_pkt
      media: venus: Refactor struct hfi_uncompressed_plane_info
      media: venus: Refactor struct hfi_session_get_property_pkt
      media: venus: Refactor struct hfi_uncompressed_format_supported
      media: venus: Refactor hfi_session_empty_buffer_uncompressed_plane0_pkt
      media: venus: Refactor hfi_session_empty_buffer_compressed_pkt
      media: venus: Refactor hfi_sys_get_property_pkt
      media: venus: Refactor hfi_session_fill_buffer_pkt
      media: venus: Refactor hfi_buffer_alloc_mode_supported

 drivers/media/common/siano/smscoreapi.c        | 10 +++---
 drivers/media/common/siano/smscoreapi.h        | 18 ++---------
 drivers/media/common/siano/smsdvb-main.c       |  4 +--
 drivers/media/common/siano/smsendian.c         |  8 +++--
 drivers/media/dvb-frontends/mxl5xx.c           |  2 +-
 drivers/media/dvb-frontends/mxl5xx_defs.h      |  4 +--
 drivers/media/pci/cx18/cx18-scb.h              |  2 +-
 drivers/media/platform/allegro-dvt/nal-hevc.h  |  7 ++--
 drivers/media/platform/qcom/venus/hfi_cmds.c   |  8 ++---
 drivers/media/platform/qcom/venus/hfi_cmds.h   | 38 ++++------------------
 drivers/media/platform/qcom/venus/hfi_helper.h | 45 ++------------------------
 drivers/media/platform/qcom/venus/hfi_parser.c |  2 +-
 drivers/media/platform/xilinx/xilinx-dma.c     |  4 +--
 drivers/media/platform/xilinx/xilinx-dma.h     |  2 +-
 14 files changed, 39 insertions(+), 115 deletions(-)
---
base-commit: 48259b90973718d2277db27b5e510f0fe957eaa0
change-id: 20240507-cocci-flexarray-9a807a8e108e

Best regards,

Comments

Vikash Garodia June 18, 2024, 12:34 p.m. UTC | #1
Hi Ricardo,

On 5/28/2024 2:38 AM, Ricardo Ribalda wrote:
> With this set we are done with all the cocci warning/errors.
> 
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> ---
> Changes in v3:
> - Do not rename structure fields. (Thanks Bryan)
> - Link to v2: https://lore.kernel.org/r/20240507-cocci-flexarray-v2-0-7aea262cf065@chromium.org
> 
> Changes in v2:
> - allegro: Replace hard coded 1 with a define. (Thanks Michael)
> - Link to v1: https://lore.kernel.org/r/20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org
> 
> ---
> Ricardo Ribalda (18):
>       media: allegro: nal-hevc: Replace array[1] with arrray[N]
>       media: xilinx: Refactor struct xvip_dma
>       media: dvb-frontend/mxl5xx: Refactor struct MBIN_FILE_T
>       media: dvb-frontend/mxl5xx: Use flex array for MBIN_SEGMENT_T
>       media: pci: cx18: Use flex arrays for struct cx18_scb
>       media: siano: Refactor struct sms_msg_data
>       media: siano: Remove unused structures
>       media: siano: Use flex arrays for sms_firmware
>       media: venus: Remove unused structs
>       media: venus: Use flex array for hfi_session_release_buffer_pkt
>       media: venus: Refactor struct hfi_uncompressed_plane_info
>       media: venus: Refactor struct hfi_session_get_property_pkt
>       media: venus: Refactor struct hfi_uncompressed_format_supported
>       media: venus: Refactor hfi_session_empty_buffer_uncompressed_plane0_pkt
>       media: venus: Refactor hfi_session_empty_buffer_compressed_pkt
>       media: venus: Refactor hfi_sys_get_property_pkt
>       media: venus: Refactor hfi_session_fill_buffer_pkt
>       media: venus: Refactor hfi_buffer_alloc_mode_supported
> 
>  drivers/media/common/siano/smscoreapi.c        | 10 +++---
>  drivers/media/common/siano/smscoreapi.h        | 18 ++---------
>  drivers/media/common/siano/smsdvb-main.c       |  4 +--
>  drivers/media/common/siano/smsendian.c         |  8 +++--
>  drivers/media/dvb-frontends/mxl5xx.c           |  2 +-
>  drivers/media/dvb-frontends/mxl5xx_defs.h      |  4 +--
>  drivers/media/pci/cx18/cx18-scb.h              |  2 +-
>  drivers/media/platform/allegro-dvt/nal-hevc.h  |  7 ++--
>  drivers/media/platform/qcom/venus/hfi_cmds.c   |  8 ++---
>  drivers/media/platform/qcom/venus/hfi_cmds.h   | 38 ++++------------------
>  drivers/media/platform/qcom/venus/hfi_helper.h | 45 ++------------------------
>  drivers/media/platform/qcom/venus/hfi_parser.c |  2 +-
>  drivers/media/platform/xilinx/xilinx-dma.c     |  4 +--
>  drivers/media/platform/xilinx/xilinx-dma.h     |  2 +-
>  14 files changed, 39 insertions(+), 115 deletions(-)
> ---
> base-commit: 48259b90973718d2277db27b5e510f0fe957eaa0
> change-id: 20240507-cocci-flexarray-9a807a8e108e
> 
> Best regards,

Could you also mention if you have run any video usecase on any of the boards
with these changes ?

Regards,
Vikash
Ricardo Ribalda June 18, 2024, 12:36 p.m. UTC | #2
Hi Vikash

On Tue, 18 Jun 2024 at 14:34, Vikash Garodia <quic_vgarodia@quicinc.com> wrote:
>
> Hi Ricardo,
>
> On 5/28/2024 2:38 AM, Ricardo Ribalda wrote:
> > With this set we are done with all the cocci warning/errors.
> >
> > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> > ---
> > Changes in v3:
> > - Do not rename structure fields. (Thanks Bryan)
> > - Link to v2: https://lore.kernel.org/r/20240507-cocci-flexarray-v2-0-7aea262cf065@chromium.org
> >
> > Changes in v2:
> > - allegro: Replace hard coded 1 with a define. (Thanks Michael)
> > - Link to v1: https://lore.kernel.org/r/20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org
> >
> > ---
> > Ricardo Ribalda (18):
> >       media: allegro: nal-hevc: Replace array[1] with arrray[N]
> >       media: xilinx: Refactor struct xvip_dma
> >       media: dvb-frontend/mxl5xx: Refactor struct MBIN_FILE_T
> >       media: dvb-frontend/mxl5xx: Use flex array for MBIN_SEGMENT_T
> >       media: pci: cx18: Use flex arrays for struct cx18_scb
> >       media: siano: Refactor struct sms_msg_data
> >       media: siano: Remove unused structures
> >       media: siano: Use flex arrays for sms_firmware
> >       media: venus: Remove unused structs
> >       media: venus: Use flex array for hfi_session_release_buffer_pkt
> >       media: venus: Refactor struct hfi_uncompressed_plane_info
> >       media: venus: Refactor struct hfi_session_get_property_pkt
> >       media: venus: Refactor struct hfi_uncompressed_format_supported
> >       media: venus: Refactor hfi_session_empty_buffer_uncompressed_plane0_pkt
> >       media: venus: Refactor hfi_session_empty_buffer_compressed_pkt
> >       media: venus: Refactor hfi_sys_get_property_pkt
> >       media: venus: Refactor hfi_session_fill_buffer_pkt
> >       media: venus: Refactor hfi_buffer_alloc_mode_supported
> >
> >  drivers/media/common/siano/smscoreapi.c        | 10 +++---
> >  drivers/media/common/siano/smscoreapi.h        | 18 ++---------
> >  drivers/media/common/siano/smsdvb-main.c       |  4 +--
> >  drivers/media/common/siano/smsendian.c         |  8 +++--
> >  drivers/media/dvb-frontends/mxl5xx.c           |  2 +-
> >  drivers/media/dvb-frontends/mxl5xx_defs.h      |  4 +--
> >  drivers/media/pci/cx18/cx18-scb.h              |  2 +-
> >  drivers/media/platform/allegro-dvt/nal-hevc.h  |  7 ++--
> >  drivers/media/platform/qcom/venus/hfi_cmds.c   |  8 ++---
> >  drivers/media/platform/qcom/venus/hfi_cmds.h   | 38 ++++------------------
> >  drivers/media/platform/qcom/venus/hfi_helper.h | 45 ++------------------------
> >  drivers/media/platform/qcom/venus/hfi_parser.c |  2 +-
> >  drivers/media/platform/xilinx/xilinx-dma.c     |  4 +--
> >  drivers/media/platform/xilinx/xilinx-dma.h     |  2 +-
> >  14 files changed, 39 insertions(+), 115 deletions(-)
> > ---
> > base-commit: 48259b90973718d2277db27b5e510f0fe957eaa0
> > change-id: 20240507-cocci-flexarray-9a807a8e108e
> >
> > Best regards,
>
> Could you also mention if you have run any video usecase on any of the boards
> with these changes ?

I have only compile tested this series. If you have access to any of
the hardware it would be great if you could test it out :)

Regards!

>
> Regards,
> Vikash
Vikash Garodia June 18, 2024, 6:53 p.m. UTC | #3
Hi Ricardo,

On 6/18/2024 6:06 PM, Ricardo Ribalda wrote:
> Hi Vikash
> 
> On Tue, 18 Jun 2024 at 14:34, Vikash Garodia <quic_vgarodia@quicinc.com> wrote:
>>
>> Hi Ricardo,
>>
>> On 5/28/2024 2:38 AM, Ricardo Ribalda wrote:
>>> With this set we are done with all the cocci warning/errors.
>>>
>>> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
>>> ---
>>> Changes in v3:
>>> - Do not rename structure fields. (Thanks Bryan)
>>> - Link to v2: https://lore.kernel.org/r/20240507-cocci-flexarray-v2-0-7aea262cf065@chromium.org
>>>
>>> Changes in v2:
>>> - allegro: Replace hard coded 1 with a define. (Thanks Michael)
>>> - Link to v1: https://lore.kernel.org/r/20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org
>>>
>>> ---
>>> Ricardo Ribalda (18):
>>>       media: allegro: nal-hevc: Replace array[1] with arrray[N]
>>>       media: xilinx: Refactor struct xvip_dma
>>>       media: dvb-frontend/mxl5xx: Refactor struct MBIN_FILE_T
>>>       media: dvb-frontend/mxl5xx: Use flex array for MBIN_SEGMENT_T
>>>       media: pci: cx18: Use flex arrays for struct cx18_scb
>>>       media: siano: Refactor struct sms_msg_data
>>>       media: siano: Remove unused structures
>>>       media: siano: Use flex arrays for sms_firmware
>>>       media: venus: Remove unused structs
>>>       media: venus: Use flex array for hfi_session_release_buffer_pkt
>>>       media: venus: Refactor struct hfi_uncompressed_plane_info
>>>       media: venus: Refactor struct hfi_session_get_property_pkt
>>>       media: venus: Refactor struct hfi_uncompressed_format_supported
>>>       media: venus: Refactor hfi_session_empty_buffer_uncompressed_plane0_pkt
>>>       media: venus: Refactor hfi_session_empty_buffer_compressed_pkt
>>>       media: venus: Refactor hfi_sys_get_property_pkt
>>>       media: venus: Refactor hfi_session_fill_buffer_pkt
>>>       media: venus: Refactor hfi_buffer_alloc_mode_supported
>>>
>>>  drivers/media/common/siano/smscoreapi.c        | 10 +++---
>>>  drivers/media/common/siano/smscoreapi.h        | 18 ++---------
>>>  drivers/media/common/siano/smsdvb-main.c       |  4 +--
>>>  drivers/media/common/siano/smsendian.c         |  8 +++--
>>>  drivers/media/dvb-frontends/mxl5xx.c           |  2 +-
>>>  drivers/media/dvb-frontends/mxl5xx_defs.h      |  4 +--
>>>  drivers/media/pci/cx18/cx18-scb.h              |  2 +-
>>>  drivers/media/platform/allegro-dvt/nal-hevc.h  |  7 ++--
>>>  drivers/media/platform/qcom/venus/hfi_cmds.c   |  8 ++---
>>>  drivers/media/platform/qcom/venus/hfi_cmds.h   | 38 ++++------------------
>>>  drivers/media/platform/qcom/venus/hfi_helper.h | 45 ++------------------------
>>>  drivers/media/platform/qcom/venus/hfi_parser.c |  2 +-
>>>  drivers/media/platform/xilinx/xilinx-dma.c     |  4 +--
>>>  drivers/media/platform/xilinx/xilinx-dma.h     |  2 +-
>>>  14 files changed, 39 insertions(+), 115 deletions(-)
>>> ---
>>> base-commit: 48259b90973718d2277db27b5e510f0fe957eaa0
>>> change-id: 20240507-cocci-flexarray-9a807a8e108e
>>>
>>> Best regards,
>>
>> Could you also mention if you have run any video usecase on any of the boards
>> with these changes ?
> 
> I have only compile tested this series. If you have access to any of
> the hardware it would be great if you could test it out :)
I have tested the series on RB5 as well as SC7180 board and looks good. I was
looking for one round of validation on db410c (having issues with my db410c setup).

Regards,
Vikash
> 
> Regards!
> 
>>
>> Regards,
>> Vikash
> 
> 
>