| Message ID | 20240618195348.1670547-1-linux@roeck-us.net (mailing list archive) |
|---|---|
| Headers | show |
| Series | hwmon: (spd5118) Various improvements | expand |
Am 18.06.24 um 21:53 schrieb Guenter Roeck: > The first patch of this series introduces multi-page support using the > regmap infrastructure. This simplifies the code and improves regmap caching. > > The second patch introduces a spd5118-specific regmap bus to implement > SMBus accesses. This solves a problem seen with i801 I2C controllers > when writing to the chip. The I2C_FUNC_SMBUS_I2C_BLOCK support implemented > in those controllers does not work with spd5118 compatible chips, so > byte-by-byte access needs to be used explicitly. > > The third patch adds support for spd5118 compatible chips which follow > the standard literally and block access to volatile registers if not > on page 0. > > RFT: I was able to test the code on AMD systems using the piix4 I2C > controller. It needs testing with i801 controllers and with Renesas > chips. > > v2: Added patches 1 and 2; simplified patch 3 to rely on regmap > based paging. Hi, i also have an AMD system and DRAM chips without the Renesas controller, but still: Tested-by: Armin Wolf <W_Armin@gmx.de> > ---------------------------------------------------------------- > Guenter Roeck (3): > hwmon: (spd5118) Use regmap to implement paging > hwmon: (spd5118) Use spd5118 specific read/write operations > hwmon: (spd5118) Add support for Renesas/ITD SPD5118 hub controllers > > drivers/hwmon/Kconfig | 2 +- > drivers/hwmon/spd5118.c | 131 +++++++++++++++++++++++++++++++++++++----------- > 2 files changed, 102 insertions(+), 31 deletions(-)
The first patch of this series introduces multi-page support using the regmap infrastructure. This simplifies the code and improves regmap caching. The second patch introduces a spd5118-specific regmap bus to implement SMBus accesses. This solves a problem seen with i801 I2C controllers when writing to the chip. The I2C_FUNC_SMBUS_I2C_BLOCK support implemented in those controllers does not work with spd5118 compatible chips, so byte-by-byte access needs to be used explicitly. The third patch adds support for spd5118 compatible chips which follow the standard literally and block access to volatile registers if not on page 0. RFT: I was able to test the code on AMD systems using the piix4 I2C controller. It needs testing with i801 controllers and with Renesas chips. v2: Added patches 1 and 2; simplified patch 3 to rely on regmap based paging. ---------------------------------------------------------------- Guenter Roeck (3): hwmon: (spd5118) Use regmap to implement paging hwmon: (spd5118) Use spd5118 specific read/write operations hwmon: (spd5118) Add support for Renesas/ITD SPD5118 hub controllers drivers/hwmon/Kconfig | 2 +- drivers/hwmon/spd5118.c | 131 +++++++++++++++++++++++++++++++++++++----------- 2 files changed, 102 insertions(+), 31 deletions(-)