| Message ID | 20240619012509.1885974-1-drosen@google.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [f2fs-dev] dump.f2fs: Add help description for -rfyPo | expand |
On 2024/6/19 9:25, Daniel Rosenberg wrote: > These were described in man pages, but not within the help message. > > Signed-off-by: Daniel Rosenberg <drosen@google.com> Can you please check below patch? https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-tools.git/commit/?h=dev-test&id=c07b0954506a159f68358edddc09be0a4d810e61 Thanks, > --- > fsck/main.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/fsck/main.c b/fsck/main.c > index 6edc902..901fa7a 100644 > --- a/fsck/main.c > +++ b/fsck/main.c > @@ -97,6 +97,11 @@ void dump_usage() > MSG(0, " -S sparse_mode\n"); > MSG(0, " -a [SSA dump segno from #1~#2 (decimal), for all 0~-1]\n"); > MSG(0, " -b blk_addr (in 4KB)\n"); > + MSG(0, " -r Recursively dump from the root inode\n"); > + MSG(0, " -f Do not prompt before dumping\n"); > + MSG(0, " -y Alias for -f\n"); > + MSG(0, " -P Preserve mode/Owner/Group for dumped inode\n"); > + MSG(0, " -o <path> Dump inodes to the given path\n"); > MSG(0, " -V print the version number and exit\n"); > > exit(1); > > base-commit: c1a97862b05d8a736ad8719939395c61bd71c982
On Tue, Jun 18, 2024 at 6:30 PM Chao Yu <chao@kernel.org> wrote: > > On 2024/6/19 9:25, Daniel Rosenberg wrote: > > These were described in man pages, but not within the help message. > > > > Signed-off-by: Daniel Rosenberg <drosen@google.com> > > Can you please check below patch? > > https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-tools.git/commit/?h=dev-test&id=c07b0954506a159f68358edddc09be0a4d810e61 > > Thanks, > > > --- > > fsck/main.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/fsck/main.c b/fsck/main.c > > index 6edc902..901fa7a 100644 > > --- a/fsck/main.c > > +++ b/fsck/main.c > > @@ -97,6 +97,11 @@ void dump_usage() > > MSG(0, " -S sparse_mode\n"); > > MSG(0, " -a [SSA dump segno from #1~#2 (decimal), for all 0~-1]\n"); > > MSG(0, " -b blk_addr (in 4KB)\n"); > > + MSG(0, " -r Recursively dump from the root inode\n"); > > + MSG(0, " -f Do not prompt before dumping\n"); > > + MSG(0, " -y Alias for -f\n"); > > + MSG(0, " -P Preserve mode/Owner/Group for dumped inode\n"); > > + MSG(0, " -o <path> Dump inodes to the given path\n"); > > MSG(0, " -V print the version number and exit\n"); > > > > exit(1); > > > > base-commit: c1a97862b05d8a736ad8719939395c61bd71c982 > > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com. > Ah, I missed that one. That will work :)
diff --git a/fsck/main.c b/fsck/main.c index 6edc902..901fa7a 100644 --- a/fsck/main.c +++ b/fsck/main.c @@ -97,6 +97,11 @@ void dump_usage() MSG(0, " -S sparse_mode\n"); MSG(0, " -a [SSA dump segno from #1~#2 (decimal), for all 0~-1]\n"); MSG(0, " -b blk_addr (in 4KB)\n"); + MSG(0, " -r Recursively dump from the root inode\n"); + MSG(0, " -f Do not prompt before dumping\n"); + MSG(0, " -y Alias for -f\n"); + MSG(0, " -P Preserve mode/Owner/Group for dumped inode\n"); + MSG(0, " -o <path> Dump inodes to the given path\n"); MSG(0, " -V print the version number and exit\n"); exit(1);
These were described in man pages, but not within the help message. Signed-off-by: Daniel Rosenberg <drosen@google.com> --- fsck/main.c | 5 +++++ 1 file changed, 5 insertions(+) base-commit: c1a97862b05d8a736ad8719939395c61bd71c982