| Message ID | 20240618160836.945242-2-olivier.moysan@foss.st.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | iio: adc: dfsdm: add scaling support | expand |
On Tue, 2024-06-18 at 18:08 +0200, Olivier Moysan wrote: > Add iio_backend_read_raw() service to support attributes read > from an IIO backend. > > Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com> > --- Small note. With it: Reviewed-by: Nuno Sa <nuno.sa@analog.com> > drivers/iio/industrialio-backend.c | 16 ++++++++++++++++ > include/linux/iio/backend.h | 3 +++ > 2 files changed, 19 insertions(+) > > diff --git a/drivers/iio/industrialio-backend.c b/drivers/iio/industrialio- > backend.c > index 929aff4040ed..b950e30018ca 100644 > --- a/drivers/iio/industrialio-backend.c > +++ b/drivers/iio/industrialio-backend.c > @@ -357,6 +357,22 @@ int devm_iio_backend_request_buffer(struct device *dev, > } > EXPORT_SYMBOL_NS_GPL(devm_iio_backend_request_buffer, IIO_BACKEND); > > +/** > + * iio_backend_read_raw - Request a value from the backend. > + * @back: Backend device > + * @val: First element of the returned value > + * @val2: Second element of the returned value > + * @mask: Specify value to retrieve > + * > + * RETURNS: > + * 0 on success, negative error number on failure. > + */ > +int iio_backend_read_raw(struct iio_backend *back, int *val, int *val2, long mask) > +{ > + return iio_backend_op_call(back, read_raw, val, val2, mask); > +} > +EXPORT_SYMBOL_NS_GPL(iio_backend_read_raw, IIO_BACKEND); > + I would completely mimic the IIO API (only change being indio_dev -> back). Meaning that 'struct iio_chan_spec const *chan' is missing. - Nuno Sá
diff --git a/drivers/iio/industrialio-backend.c b/drivers/iio/industrialio-backend.c index 929aff4040ed..b950e30018ca 100644 --- a/drivers/iio/industrialio-backend.c +++ b/drivers/iio/industrialio-backend.c @@ -357,6 +357,22 @@ int devm_iio_backend_request_buffer(struct device *dev, } EXPORT_SYMBOL_NS_GPL(devm_iio_backend_request_buffer, IIO_BACKEND); +/** + * iio_backend_read_raw - Request a value from the backend. + * @back: Backend device + * @val: First element of the returned value + * @val2: Second element of the returned value + * @mask: Specify value to retrieve + * + * RETURNS: + * 0 on success, negative error number on failure. + */ +int iio_backend_read_raw(struct iio_backend *back, int *val, int *val2, long mask) +{ + return iio_backend_op_call(back, read_raw, val, val2, mask); +} +EXPORT_SYMBOL_NS_GPL(iio_backend_read_raw, IIO_BACKEND); + static struct iio_backend *iio_backend_from_indio_dev_parent(const struct device *dev) { struct iio_backend *back = ERR_PTR(-ENODEV), *iter; diff --git a/include/linux/iio/backend.h b/include/linux/iio/backend.h index 8099759d7242..cff486699054 100644 --- a/include/linux/iio/backend.h +++ b/include/linux/iio/backend.h @@ -81,6 +81,7 @@ enum iio_backend_sample_trigger { * @extend_chan_spec: Extend an IIO channel. * @ext_info_set: Extended info setter. * @ext_info_get: Extended info getter. + * @read_raw: Read value from a backend device **/ struct iio_backend_ops { int (*enable)(struct iio_backend *back); @@ -113,6 +114,7 @@ struct iio_backend_ops { const char *buf, size_t len); int (*ext_info_get)(struct iio_backend *back, uintptr_t private, const struct iio_chan_spec *chan, char *buf); + int (*read_raw)(struct iio_backend *back, int *val, int *val2, long mask); }; int iio_backend_chan_enable(struct iio_backend *back, unsigned int chan); @@ -141,6 +143,7 @@ ssize_t iio_backend_ext_info_set(struct iio_dev *indio_dev, uintptr_t private, const char *buf, size_t len); ssize_t iio_backend_ext_info_get(struct iio_dev *indio_dev, uintptr_t private, const struct iio_chan_spec *chan, char *buf); +int iio_backend_read_raw(struct iio_backend *back, int *val, int *val2, long mask); int iio_backend_extend_chan_spec(struct iio_dev *indio_dev, struct iio_backend *back,
Add iio_backend_read_raw() service to support attributes read from an IIO backend. Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com> --- drivers/iio/industrialio-backend.c | 16 ++++++++++++++++ include/linux/iio/backend.h | 3 +++ 2 files changed, 19 insertions(+)