Message ID | 87bk4oqerx.wl-kuninori.morimoto.gx@renesas.com (mailing list archive) |
---|---|
Headers | show |
Series | ASoC: grace time for DPCM cleanup | expand |
On Thu, May 30, 2024 at 01:17:39AM +0000, Kuninori Morimoto wrote: > As we discussed in [1], we don't need to use dpcm_playback/capture flag, > so we remove it. But we have been using it for 10 years, some driver might > get damage. The most likely case is that the device/driver can use both > playback/capture, but have only one flag, and not using xxx_only flag. > [1/3] patch indicates warning in such case. This doesn't apply against current code, please check and resend (it's simple-card and audio-graph-card2 that conflict).
Hi Mark > > As we discussed in [1], we don't need to use dpcm_playback/capture flag, > > so we remove it. But we have been using it for 10 years, some driver might > > get damage. The most likely case is that the device/driver can use both > > playback/capture, but have only one flag, and not using xxx_only flag. > > [1/3] patch indicates warning in such case. > > This doesn't apply against current code, please check and resend (it's > simple-card and audio-graph-card2 that conflict). Hmm ? I didn't get conflict on latest branch ? I'm using this commit 595265c92668cbdbd9f299c49907734d468c12e9 ("ASoC: Constify DAI ops auto_selectable_formats") Anyway, I will post v6 patch. Thank you for your help !! Best regards --- Kuninori Morimoto
Hi Mark again > > As we discussed in [1], we don't need to use dpcm_playback/capture flag, > > so we remove it. But we have been using it for 10 years, some driver might > > get damage. The most likely case is that the device/driver can use both > > playback/capture, but have only one flag, and not using xxx_only flag. > > [1/3] patch indicates warning in such case. > > This doesn't apply against current code, please check and resend (it's > simple-card and audio-graph-card2 that conflict). Ah, I guess you used "v5 original" patch-set. "v5 resend" patch-set or today's "v6" patch-set should be OK. Thank you for your help !! Best regards --- Kuninori Morimoto
On Wed, Jun 19, 2024 at 04:57:22AM +0000, Kuninori Morimoto wrote: > > This doesn't apply against current code, please check and resend (it's > > simple-card and audio-graph-card2 that conflict). > Ah, I guess you used "v5 original" patch-set. > "v5 resend" patch-set or today's "v6" patch-set should be OK. Oh, if you mark something as a resend then it sounds like it should be exactly the same as it was before, if you've rebased you should increase the version number.
Hi Mark > > > This doesn't apply against current code, please check and resend (it's > > > simple-card and audio-graph-card2 that conflict). > > > Ah, I guess you used "v5 original" patch-set. > > "v5 resend" patch-set or today's "v6" patch-set should be OK. > > Oh, if you mark something as a resend then it sounds like it should be > exactly the same as it was before, if you've rebased you should increase > the version number. Thanks, I learned it this time. Will do since next time. And now I could understand the reason that sometime maintainer get strange conflict which I don't have :) Thank you for your help !! Best regards --- Kuninori Morimoto