diff mbox series

[1/3] dt-bindings: regulator: mt6315: Document MT6319 PMIC

Message ID 20240620094746.2404753-2-wenst@chromium.org (mailing list archive)
State Accepted, archived
Headers show
Series arm64: dts: mediatek: Add MT8186 Voltorb Chromebooks | expand

Commit Message

Chen-Yu Tsai June 20, 2024, 9:47 a.m. UTC
The MT6319 is a pin-compatible drop-in replacement for MT6315 with
slightly better electrical characteristics.

It's unclear whether there are any differences, since the downstream
implementation doesn't describe the MT6319 separately. Neither does the
implementation check chip IDs, even though those are available.

Add a new compatible for the MT6319 just in case differences are
discovered later and fall back to the MT6315 compatible.

Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
 .../devicetree/bindings/regulator/mt6315-regulator.yaml     | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Conor Dooley June 20, 2024, 4:12 p.m. UTC | #1
On Thu, Jun 20, 2024 at 05:47:36PM +0800, Chen-Yu Tsai wrote:
> The MT6319 is a pin-compatible drop-in replacement for MT6315 with
> slightly better electrical characteristics.
> 
> It's unclear whether there are any differences, since the downstream
> implementation doesn't describe the MT6319 separately. Neither does the
> implementation check chip IDs, even though those are available.
> 
> Add a new compatible for the MT6319 just in case differences are
> discovered later and fall back to the MT6315 compatible.
> 
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/regulator/mt6315-regulator.yaml b/Documentation/devicetree/bindings/regulator/mt6315-regulator.yaml
index 6317daf76d1f..cd4aa27218a1 100644
--- a/Documentation/devicetree/bindings/regulator/mt6315-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/mt6315-regulator.yaml
@@ -16,7 +16,11 @@  description: |
 
 properties:
   compatible:
-    const: mediatek,mt6315-regulator
+    oneOf:
+      - items:
+          - const: mediatek,mt6319-regulator
+          - const: mediatek,mt6315-regulator
+      - const: mediatek,mt6315-regulator
 
   reg:
     maxItems: 1