| Message ID | 20240620094746.2404753-3-wenst@chromium.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | arm64: dts: mediatek: Add MT8186 Voltorb Chromebooks | expand |
On Thu, Jun 20, 2024 at 05:47:37PM +0800, Chen-Yu Tsai wrote: > Add an entry for the MT8186 based Voltorb Chromebooks, also known as the > Acer Chromebook 311 (C723/C723T). The device is a clamshell style laptop > with an optional touchscreen. > > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > --- > Documentation/devicetree/bindings/arm/mediatek.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml > index b1b09db0bd65..e7746afeb0b3 100644 > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml > @@ -301,6 +301,13 @@ properties: > - const: google,tentacruel-sku327683 > - const: google,tentacruel > - const: mediatek,mt8186 > + - description: Google Voltorb (Acer Chromebook 311 C723/C732T) > + items: > + - enum: > + - google,voltorb-sku589824 > + - google,voltorb-sku589825 This looks rather sane for a chromebook! Acked-by: Conor Dooley <conor.dooley@microchip.com> > + - const: google,voltorb > + - const: mediatek,mt8186 > - items: > - enum: > - mediatek,mt8186-evb > -- > 2.45.2.741.gdbec12cfda-goog >
On Fri, Jun 21, 2024 at 12:13 AM Conor Dooley <conor@kernel.org> wrote: > > On Thu, Jun 20, 2024 at 05:47:37PM +0800, Chen-Yu Tsai wrote: > > Add an entry for the MT8186 based Voltorb Chromebooks, also known as the > > Acer Chromebook 311 (C723/C723T). The device is a clamshell style laptop > > with an optional touchscreen. > > > > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > > --- > > Documentation/devicetree/bindings/arm/mediatek.yaml | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml > > index b1b09db0bd65..e7746afeb0b3 100644 > > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml > > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml > > @@ -301,6 +301,13 @@ properties: > > - const: google,tentacruel-sku327683 > > - const: google,tentacruel > > - const: mediatek,mt8186 > > + - description: Google Voltorb (Acer Chromebook 311 C723/C732T) > > + items: > > + - enum: > > + - google,voltorb-sku589824 > > + - google,voltorb-sku589825 > > This looks rather sane for a chromebook! It really depends on the OEM/ODM for how many combinations they end up producing... > Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks! > > + - const: google,voltorb > > + - const: mediatek,mt8186 > > - items: > > - enum: > > - mediatek,mt8186-evb > > -- > > 2.45.2.741.gdbec12cfda-goog > >
diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml index b1b09db0bd65..e7746afeb0b3 100644 --- a/Documentation/devicetree/bindings/arm/mediatek.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml @@ -301,6 +301,13 @@ properties: - const: google,tentacruel-sku327683 - const: google,tentacruel - const: mediatek,mt8186 + - description: Google Voltorb (Acer Chromebook 311 C723/C732T) + items: + - enum: + - google,voltorb-sku589824 + - google,voltorb-sku589825 + - const: google,voltorb + - const: mediatek,mt8186 - items: - enum: - mediatek,mt8186-evb
Add an entry for the MT8186 based Voltorb Chromebooks, also known as the Acer Chromebook 311 (C723/C723T). The device is a clamshell style laptop with an optional touchscreen. Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> --- Documentation/devicetree/bindings/arm/mediatek.yaml | 7 +++++++ 1 file changed, 7 insertions(+)