diff mbox series

fs: nfs: add missing MODULE_DESCRIPTION() macros

Message ID 20240527-md-fs-nfs-v1-1-64a15e9b53a6@quicinc.com (mailing list archive)
State New
Headers show
Series fs: nfs: add missing MODULE_DESCRIPTION() macros | expand

Commit Message

Jeff Johnson May 27, 2024, 5:58 p.m. UTC 
Fix the 'make W=1' warnings:
WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs_common/nfs_acl.o
WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs_common/grace.o
WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs/nfs.o
WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs/nfsv2.o
WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs/nfsv3.o
WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs/nfsv4.o

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 fs/nfs/inode.c         | 1 +
 fs/nfs/nfs2super.c     | 1 +
 fs/nfs/nfs3super.c     | 1 +
 fs/nfs/nfs4super.c     | 1 +
 fs/nfs_common/grace.c  | 1 +
 fs/nfs_common/nfsacl.c | 1 +
 6 files changed, 6 insertions(+)


---
base-commit: 2bfcfd584ff5ccc8bb7acde19b42570414bf880b
change-id: 20240527-md-fs-nfs-42f19eb60b50

Comments

Jeff Johnson June 20, 2024, 4:17 p.m. UTC | #1 
On 5/27/24 10:58, Jeff Johnson wrote:
> Fix the 'make W=1' warnings:
> WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs_common/nfs_acl.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs_common/grace.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs/nfs.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs/nfsv2.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs/nfsv3.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs/nfsv4.o
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
>   fs/nfs/inode.c         | 1 +
>   fs/nfs/nfs2super.c     | 1 +
>   fs/nfs/nfs3super.c     | 1 +
>   fs/nfs/nfs4super.c     | 1 +
>   fs/nfs_common/grace.c  | 1 +
>   fs/nfs_common/nfsacl.c | 1 +
>   6 files changed, 6 insertions(+)
> 
> diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
> index acef52ecb1bb..57c473e9d00f 100644
> --- a/fs/nfs/inode.c
> +++ b/fs/nfs/inode.c
> @@ -2538,6 +2538,7 @@ static void __exit exit_nfs_fs(void)
>   
>   /* Not quite true; I just maintain it */
>   MODULE_AUTHOR("Olaf Kirch <okir@monad.swb.de>");
> +MODULE_DESCRIPTION("NFS client support");
>   MODULE_LICENSE("GPL");
>   module_param(enable_ino64, bool, 0644);
>   
> diff --git a/fs/nfs/nfs2super.c b/fs/nfs/nfs2super.c
> index 467f21ee6a35..b1badc70bd71 100644
> --- a/fs/nfs/nfs2super.c
> +++ b/fs/nfs/nfs2super.c
> @@ -26,6 +26,7 @@ static void __exit exit_nfs_v2(void)
>   	unregister_nfs_version(&nfs_v2);
>   }
>   
> +MODULE_DESCRIPTION("NFSv2 client support");
>   MODULE_LICENSE("GPL");
>   
>   module_init(init_nfs_v2);
> diff --git a/fs/nfs/nfs3super.c b/fs/nfs/nfs3super.c
> index 8a9be9e47f76..20a80478449e 100644
> --- a/fs/nfs/nfs3super.c
> +++ b/fs/nfs/nfs3super.c
> @@ -27,6 +27,7 @@ static void __exit exit_nfs_v3(void)
>   	unregister_nfs_version(&nfs_v3);
>   }
>   
> +MODULE_DESCRIPTION("NFSv3 client support");
>   MODULE_LICENSE("GPL");
>   
>   module_init(init_nfs_v3);
> diff --git a/fs/nfs/nfs4super.c b/fs/nfs/nfs4super.c
> index 8da5a9c000f4..b29a26923ce0 100644
> --- a/fs/nfs/nfs4super.c
> +++ b/fs/nfs/nfs4super.c
> @@ -332,6 +332,7 @@ static void __exit exit_nfs_v4(void)
>   	nfs_dns_resolver_destroy();
>   }
>   
> +MODULE_DESCRIPTION("NFSv4 client support");
>   MODULE_LICENSE("GPL");
>   
>   module_init(init_nfs_v4);
> diff --git a/fs/nfs_common/grace.c b/fs/nfs_common/grace.c
> index 1479583fbb62..8f034aa8c88b 100644
> --- a/fs/nfs_common/grace.c
> +++ b/fs/nfs_common/grace.c
> @@ -139,6 +139,7 @@ exit_grace(void)
>   }
>   
>   MODULE_AUTHOR("Jeff Layton <jlayton@primarydata.com>");
> +MODULE_DESCRIPTION("lockd and nfsv4 grace period control");
>   MODULE_LICENSE("GPL");
>   module_init(init_grace)
>   module_exit(exit_grace)
> diff --git a/fs/nfs_common/nfsacl.c b/fs/nfs_common/nfsacl.c
> index 5a5bd85d08f8..ea382b75b26c 100644
> --- a/fs/nfs_common/nfsacl.c
> +++ b/fs/nfs_common/nfsacl.c
> @@ -29,6 +29,7 @@
>   #include <linux/nfs3.h>
>   #include <linux/sort.h>
>   
> +MODULE_DESCRIPTION("NFS ACL support");
>   MODULE_LICENSE("GPL");
>   
>   struct nfsacl_encode_desc {
> 
> ---
> base-commit: 2bfcfd584ff5ccc8bb7acde19b42570414bf880b
> change-id: 20240527-md-fs-nfs-42f19eb60b50
> 

Adding core fs maintainers.
Following up to see if anything else is needed to get this merged.
Jeff Layton June 20, 2024, 4:33 p.m. UTC | #2 
On Mon, 2024-05-27 at 10:58 -0700, Jeff Johnson wrote:
> Fix the 'make W=1' warnings:
> WARNING: modpost: missing MODULE_DESCRIPTION() in
> fs/nfs_common/nfs_acl.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in
> fs/nfs_common/grace.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs/nfs.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs/nfsv2.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs/nfsv3.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs/nfsv4.o
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
>  fs/nfs/inode.c         | 1 +
>  fs/nfs/nfs2super.c     | 1 +
>  fs/nfs/nfs3super.c     | 1 +
>  fs/nfs/nfs4super.c     | 1 +
>  fs/nfs_common/grace.c  | 1 +
>  fs/nfs_common/nfsacl.c | 1 +
>  6 files changed, 6 insertions(+)
> 
> diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
> index acef52ecb1bb..57c473e9d00f 100644
> --- a/fs/nfs/inode.c
> +++ b/fs/nfs/inode.c
> @@ -2538,6 +2538,7 @@ static void __exit exit_nfs_fs(void)
>  
>  /* Not quite true; I just maintain it */
>  MODULE_AUTHOR("Olaf Kirch <okir@monad.swb.de>");
> +MODULE_DESCRIPTION("NFS client support");
>  MODULE_LICENSE("GPL");
>  module_param(enable_ino64, bool, 0644);
>  
> diff --git a/fs/nfs/nfs2super.c b/fs/nfs/nfs2super.c
> index 467f21ee6a35..b1badc70bd71 100644
> --- a/fs/nfs/nfs2super.c
> +++ b/fs/nfs/nfs2super.c
> @@ -26,6 +26,7 @@ static void __exit exit_nfs_v2(void)
>  	unregister_nfs_version(&nfs_v2);
>  }
>  
> +MODULE_DESCRIPTION("NFSv2 client support");
>  MODULE_LICENSE("GPL");
>  
>  module_init(init_nfs_v2);
> diff --git a/fs/nfs/nfs3super.c b/fs/nfs/nfs3super.c
> index 8a9be9e47f76..20a80478449e 100644
> --- a/fs/nfs/nfs3super.c
> +++ b/fs/nfs/nfs3super.c
> @@ -27,6 +27,7 @@ static void __exit exit_nfs_v3(void)
>  	unregister_nfs_version(&nfs_v3);
>  }
>  
> +MODULE_DESCRIPTION("NFSv3 client support");
>  MODULE_LICENSE("GPL");
>  
>  module_init(init_nfs_v3);
> diff --git a/fs/nfs/nfs4super.c b/fs/nfs/nfs4super.c
> index 8da5a9c000f4..b29a26923ce0 100644
> --- a/fs/nfs/nfs4super.c
> +++ b/fs/nfs/nfs4super.c
> @@ -332,6 +332,7 @@ static void __exit exit_nfs_v4(void)
>  	nfs_dns_resolver_destroy();
>  }
>  
> +MODULE_DESCRIPTION("NFSv4 client support");
>  MODULE_LICENSE("GPL");
>  
>  module_init(init_nfs_v4);
> diff --git a/fs/nfs_common/grace.c b/fs/nfs_common/grace.c
> index 1479583fbb62..8f034aa8c88b 100644
> --- a/fs/nfs_common/grace.c
> +++ b/fs/nfs_common/grace.c
> @@ -139,6 +139,7 @@ exit_grace(void)
>  }
>  
>  MODULE_AUTHOR("Jeff Layton <jlayton@primarydata.com>");
> +MODULE_DESCRIPTION("lockd and nfsv4 grace period control");

This module has some code that does other things too. It's basically
some core infrastructure shared by the NFS client and server. Maybe
this should read "NFS client and server infrastructure" ?

>  MODULE_LICENSE("GPL");
>  module_init(init_grace)
>  module_exit(exit_grace)
> diff --git a/fs/nfs_common/nfsacl.c b/fs/nfs_common/nfsacl.c
> index 5a5bd85d08f8..ea382b75b26c 100644
> --- a/fs/nfs_common/nfsacl.c
> +++ b/fs/nfs_common/nfsacl.c
> @@ -29,6 +29,7 @@
>  #include <linux/nfs3.h>
>  #include <linux/sort.h>
>  
> +MODULE_DESCRIPTION("NFS ACL support");
>  MODULE_LICENSE("GPL");
>  
>  struct nfsacl_encode_desc {
> 
> ---
> base-commit: 2bfcfd584ff5ccc8bb7acde19b42570414bf880b
> change-id: 20240527-md-fs-nfs-42f19eb60b50
>
Jeff Johnson June 20, 2024, 4:51 p.m. UTC | #3 
On 6/20/2024 9:33 AM, Jeff Layton wrote:
> On Mon, 2024-05-27 at 10:58 -0700, Jeff Johnson wrote:
...
>> diff --git a/fs/nfs_common/grace.c b/fs/nfs_common/grace.c
>> index 1479583fbb62..8f034aa8c88b 100644
>> --- a/fs/nfs_common/grace.c
>> +++ b/fs/nfs_common/grace.c
>> @@ -139,6 +139,7 @@ exit_grace(void)
>>  }
>>  
>>  MODULE_AUTHOR("Jeff Layton <jlayton@primarydata.com>");
>> +MODULE_DESCRIPTION("lockd and nfsv4 grace period control");
> 
> This module has some code that does other things too. It's basically
> some core infrastructure shared by the NFS client and server. Maybe
> this should read "NFS client and server infrastructure" ?

thanks, will update in v2

/jeff
diff mbox series

Patch

diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
index acef52ecb1bb..57c473e9d00f 100644
--- a/fs/nfs/inode.c
+++ b/fs/nfs/inode.c
@@ -2538,6 +2538,7 @@  static void __exit exit_nfs_fs(void)
 
 /* Not quite true; I just maintain it */
 MODULE_AUTHOR("Olaf Kirch <okir@monad.swb.de>");
+MODULE_DESCRIPTION("NFS client support");
 MODULE_LICENSE("GPL");
 module_param(enable_ino64, bool, 0644);
 
diff --git a/fs/nfs/nfs2super.c b/fs/nfs/nfs2super.c
index 467f21ee6a35..b1badc70bd71 100644
--- a/fs/nfs/nfs2super.c
+++ b/fs/nfs/nfs2super.c
@@ -26,6 +26,7 @@  static void __exit exit_nfs_v2(void)
 	unregister_nfs_version(&nfs_v2);
 }
 
+MODULE_DESCRIPTION("NFSv2 client support");
 MODULE_LICENSE("GPL");
 
 module_init(init_nfs_v2);
diff --git a/fs/nfs/nfs3super.c b/fs/nfs/nfs3super.c
index 8a9be9e47f76..20a80478449e 100644
--- a/fs/nfs/nfs3super.c
+++ b/fs/nfs/nfs3super.c
@@ -27,6 +27,7 @@  static void __exit exit_nfs_v3(void)
 	unregister_nfs_version(&nfs_v3);
 }
 
+MODULE_DESCRIPTION("NFSv3 client support");
 MODULE_LICENSE("GPL");
 
 module_init(init_nfs_v3);
diff --git a/fs/nfs/nfs4super.c b/fs/nfs/nfs4super.c
index 8da5a9c000f4..b29a26923ce0 100644
--- a/fs/nfs/nfs4super.c
+++ b/fs/nfs/nfs4super.c
@@ -332,6 +332,7 @@  static void __exit exit_nfs_v4(void)
 	nfs_dns_resolver_destroy();
 }
 
+MODULE_DESCRIPTION("NFSv4 client support");
 MODULE_LICENSE("GPL");
 
 module_init(init_nfs_v4);
diff --git a/fs/nfs_common/grace.c b/fs/nfs_common/grace.c
index 1479583fbb62..8f034aa8c88b 100644
--- a/fs/nfs_common/grace.c
+++ b/fs/nfs_common/grace.c
@@ -139,6 +139,7 @@  exit_grace(void)
 }
 
 MODULE_AUTHOR("Jeff Layton <jlayton@primarydata.com>");
+MODULE_DESCRIPTION("lockd and nfsv4 grace period control");
 MODULE_LICENSE("GPL");
 module_init(init_grace)
 module_exit(exit_grace)
diff --git a/fs/nfs_common/nfsacl.c b/fs/nfs_common/nfsacl.c
index 5a5bd85d08f8..ea382b75b26c 100644
--- a/fs/nfs_common/nfsacl.c
+++ b/fs/nfs_common/nfsacl.c
@@ -29,6 +29,7 @@ 
 #include <linux/nfs3.h>
 #include <linux/sort.h>
 
+MODULE_DESCRIPTION("NFS ACL support");
 MODULE_LICENSE("GPL");
 
 struct nfsacl_encode_desc {