| Message ID | 20240620201731.3694593-1-quic_abhinavk@quicinc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3] drm/msm/dpu: drop validity checks for clear_pending_flush() ctl op | expand |
On Thu, Jun 20, 2024 at 01:17:30PM GMT, Abhinav Kumar wrote: > clear_pending_flush() ctl op is always assigned irrespective of the DPU > hardware revision. Hence there is no needed to check whether the op has > been assigned before calling it. > > Drop the checks across the driver for clear_pending_flush() and also > update its documentation that it is always expected to be assigned. > > changes in v2: > - instead of adding more validity checks just drop the one for clear_pending_flush > - update the documentation for clear_pending_flush() ctl op > - update the commit text reflecting these changes > > changes in v3: > - simplify the documentation of clear_pending_flush > > Fixes: d7d0e73f7de3 ("drm/msm/dpu: introduce the dpu_encoder_phys_* for writeback") > Reported-by: Dan Carpenter <dan.carpenter@linaro.org> > Closes: https://lore.kernel.org/all/464fbd84-0d1c-43c3-a40b-31656ac06456@moroto.mountain/T/ > Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 3 +-- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 3 +-- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h | 3 ++- > 3 files changed, 4 insertions(+), 5 deletions(-) > Thank you! Rob, do you plan to send another -fixes pull request? If no, I'll include this into -next.
On Thu, Jun 20, 2024 at 01:17:30PM GMT, Abhinav Kumar wrote: > clear_pending_flush() ctl op is always assigned irrespective of the DPU > hardware revision. Hence there is no needed to check whether the op has > been assigned before calling it. > > Drop the checks across the driver for clear_pending_flush() and also > update its documentation that it is always expected to be assigned. > > changes in v2: > - instead of adding more validity checks just drop the one for clear_pending_flush > - update the documentation for clear_pending_flush() ctl op > - update the commit text reflecting these changes > > changes in v3: > - simplify the documentation of clear_pending_flush > > Fixes: d7d0e73f7de3 ("drm/msm/dpu: introduce the dpu_encoder_phys_* for writeback") > Reported-by: Dan Carpenter <dan.carpenter@linaro.org> > Closes: https://lore.kernel.org/all/464fbd84-0d1c-43c3-a40b-31656ac06456@moroto.mountain/T/ > Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 3 +-- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 3 +-- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h | 3 ++- > 3 files changed, 4 insertions(+), 5 deletions(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On Thu, 20 Jun 2024 13:17:30 -0700, Abhinav Kumar wrote: > clear_pending_flush() ctl op is always assigned irrespective of the DPU > hardware revision. Hence there is no needed to check whether the op has > been assigned before calling it. > > Drop the checks across the driver for clear_pending_flush() and also > update its documentation that it is always expected to be assigned. > > [...] Applied, thanks! [1/1] drm/msm/dpu: drop validity checks for clear_pending_flush() ctl op https://gitlab.freedesktop.org/lumag/msm/-/commit/3d68e3dedd4b Best regards,
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c index 708657598cce..697ad4a64051 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c @@ -1743,8 +1743,7 @@ void dpu_encoder_trigger_kickoff_pending(struct drm_encoder *drm_enc) phys = dpu_enc->phys_encs[i]; ctl = phys->hw_ctl; - if (ctl->ops.clear_pending_flush) - ctl->ops.clear_pending_flush(ctl); + ctl->ops.clear_pending_flush(ctl); /* update only for command mode primary ctl */ if ((phys == dpu_enc->cur_master) && diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c index 356dca5e5ea9..882c717859ce 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c @@ -538,8 +538,7 @@ static void dpu_encoder_phys_wb_disable(struct dpu_encoder_phys *phys_enc) } /* reset h/w before final flush */ - if (phys_enc->hw_ctl->ops.clear_pending_flush) - phys_enc->hw_ctl->ops.clear_pending_flush(phys_enc->hw_ctl); + phys_enc->hw_ctl->ops.clear_pending_flush(phys_enc->hw_ctl); /* * New CTL reset sequence from 5.0 MDP onwards. diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h index ef56280bea93..4401fdc0f3e4 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h @@ -83,7 +83,8 @@ struct dpu_hw_ctl_ops { /** * Clear the value of the cached pending_flush_mask - * No effect on hardware + * No effect on hardware. + * Required to be implemented. * @ctx : ctl path ctx pointer */ void (*clear_pending_flush)(struct dpu_hw_ctl *ctx);
clear_pending_flush() ctl op is always assigned irrespective of the DPU hardware revision. Hence there is no needed to check whether the op has been assigned before calling it. Drop the checks across the driver for clear_pending_flush() and also update its documentation that it is always expected to be assigned. changes in v2: - instead of adding more validity checks just drop the one for clear_pending_flush - update the documentation for clear_pending_flush() ctl op - update the commit text reflecting these changes changes in v3: - simplify the documentation of clear_pending_flush Fixes: d7d0e73f7de3 ("drm/msm/dpu: introduce the dpu_encoder_phys_* for writeback") Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Closes: https://lore.kernel.org/all/464fbd84-0d1c-43c3-a40b-31656ac06456@moroto.mountain/T/ Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com> --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 3 +-- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 3 +-- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h | 3 ++- 3 files changed, 4 insertions(+), 5 deletions(-)