| Message ID | 10f621d0711c80137afd93f62a03b1b10009715c.1718921174.git.daniel@makrotopia.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | hwrng: add hwrng support for Rockchip RK3568 | expand |
Hi, https://lore.kernel.org/all/89b16ec5-f9a5-f836-f51a-8325448e4775@linaro.org/ also mentions some remarks about the subject, so if I interpreted those remarks correctly, it should be: dt-bindings: rng: rockchip: Add rk3568 TRNG On Friday, 21 June 2024 03:25:01 CEST Daniel Golle wrote: > From: Aurelien Jarno <aurelien@aurel32.net> > > Add the RNG bindings for the RK3568 SoC from Rockchip > > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net> > Signed-off-by: Daniel Golle <daniel@makrotopia.org> > --- > .../bindings/rng/rockchip,rk3568-rng.yaml | 60 +++++++++++++++++++ > MAINTAINERS | 6 ++ > 2 files changed, 66 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/rng/rockchip,rk3568-rng.yaml > > diff --git a/Documentation/devicetree/bindings/rng/rockchip,rk3568-rng.yaml > b/Documentation/devicetree/bindings/rng/rockchip,rk3568-rng.yaml new file > mode 100644 > index 000000000000..d45f03683fbe > --- /dev/null > +++ b/Documentation/devicetree/bindings/rng/rockchip,rk3568-rng.yaml > @@ -0,0 +1,61 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip TRNG > + > +description: True Random Number Generator on Rokchip RK3568 SoC I *think* that the TRNG for rk3588 is different, so shouldn't the title be: Rockchip TRNG for rk356x SoCs Cheers, Diederik PS: Heiko's name is without `memcpy_fromio` ;-P
On Friday, 21 June 2024 11:12:35 CEST Diederik de Haas wrote: > > +title: Rockchip TRNG > > + > > +description: True Random Number Generator on Rokchip RK3568 SoC > > I *think* that the TRNG for rk3588 is different, so shouldn't the title be: > > Rockchip TRNG for rk356x SoCs And I just noticed `Rokchip` in the description, so that's missing a `c`.
On 21/06/2024 03:25, Daniel Golle wrote: > From: Aurelien Jarno <aurelien@aurel32.net> > > Add the RNG bindings for the RK3568 SoC from Rockchip > > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net> > Signed-off-by: Daniel Golle <daniel@makrotopia.org> <form letter> This is a friendly reminder during the review process. It seems my or other reviewer's previous comments were not fully addressed. Maybe the feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. </form letter> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/rng/rockchip,rk3568-rng.yaml b/Documentation/devicetree/bindings/rng/rockchip,rk3568-rng.yaml new file mode 100644 index 000000000000..d45f03683fbe --- /dev/null +++ b/Documentation/devicetree/bindings/rng/rockchip,rk3568-rng.yaml @@ -0,0 +1,61 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Rockchip TRNG + +description: True Random Number Generator on Rokchip RK3568 SoC + +maintainers: + - Aurelien Jarno <aurelien@aurel32.net> + - Daniel Golle <daniel@makrotopia.org> + +properties: + compatible: + enum: + - rockchip,rk3568-rng + + reg: + maxItems: 1 + + clocks: + items: + - description: TRNG clock + - description: TRNG AHB clock + + clock-names: + items: + - const: core + - const: ahb + + resets: + maxItems: 1 + +required: + - compatible + - reg + - clocks + - clock-names + - resets + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/rk3568-cru.h> + bus { + #address-cells = <2>; + #size-cells = <2>; + + rng@fe388000 { + compatible = "rockchip,rk3568-rng"; + reg = <0x0 0xfe388000 0x0 0x4000>; + clocks = <&cru CLK_TRNG_NS>, <&cru HCLK_TRNG_NS>; + clock-names = "core", "ahb"; + resets = <&cru SRST_TRNG_NS>; + }; + }; + +... diff --git a/MAINTAINERS b/MAINTAINERS index f45881e982d2..77d449c89bf2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -19488,6 +19488,12 @@ F: Documentation/userspace-api/media/v4l/metafmt-rkisp1.rst F: drivers/media/platform/rockchip/rkisp1 F: include/uapi/linux/rkisp1-config.h +ROCKCHIP RANDOM NUMBER GENERATOR SUPPORT +M: Daniel Golle <daniel@makrotopia.org> +M: Aurelien Jarno <aurelien@aurel32.net> +S: Maintained +F: Documentation/devicetree/bindings/rng/rockchip,rk3568-rng.yaml + ROCKCHIP RASTER 2D GRAPHIC ACCELERATION UNIT DRIVER M: Jacob Chen <jacob-chen@iotwrt.com> M: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>