| Message ID | 20240620074802.852544-1-nichen@iscas.ac.cn (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] drm/panel: ltk050h3146w: add check for mipi_dsi_dcs_enter_sleep_mode | expand |
Le 20/06/2024 à 09:48, Chen Ni a écrit : > Add check for the return value of mipi_dsi_dcs_enter_sleep_mode() and > return the error if it fails in order to catch the error. > > Signed-off-by: Chen Ni <nichen@iscas.ac.cn> > --- > drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c b/drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c > index 22a14006765e..d7c9df673f35 100644 > --- a/drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c > +++ b/drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c > @@ -139,7 +139,7 @@ static int xpp055c272_unprepare(struct drm_panel *panel) > if (ret < 0) > dev_err(ctx->dev, "failed to set display off: %d\n", ret); > > - mipi_dsi_dcs_enter_sleep_mode(dsi); > + ret = mipi_dsi_dcs_enter_sleep_mode(dsi); > if (ret < 0) { > dev_err(ctx->dev, "failed to enter sleep mode: %d\n", ret); > return ret; Reviewed-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> See: https://lore.kernel.org/all/6e3a8cb3956fe94f1259c13053fddb378e7d0d82.1619878508.git.christophe.jaillet@wanadoo.fr/ which never got any feedback. CJ
On 6/20/2024 12:48 AM, Chen Ni wrote: > Add check for the return value of mipi_dsi_dcs_enter_sleep_mode() and > return the error if it fails in order to catch the error. > > Signed-off-by: Chen Ni <nichen@iscas.ac.cn> Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com> > --- > drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c b/drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c > index 22a14006765e..d7c9df673f35 100644 > --- a/drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c > +++ b/drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c > @@ -139,7 +139,7 @@ static int xpp055c272_unprepare(struct drm_panel *panel) > if (ret < 0) > dev_err(ctx->dev, "failed to set display off: %d\n", ret); > > - mipi_dsi_dcs_enter_sleep_mode(dsi); > + ret = mipi_dsi_dcs_enter_sleep_mode(dsi); > if (ret < 0) { > dev_err(ctx->dev, "failed to enter sleep mode: %d\n", ret); > return ret; > -- > 2.25.1 >
On Thu, Jun 20, 2024 at 03:48:02PM GMT, Chen Ni wrote: > Add check for the return value of mipi_dsi_dcs_enter_sleep_mode() and > return the error if it fails in order to catch the error. > > Signed-off-by: Chen Ni <nichen@iscas.ac.cn> > --- > drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Fixes: d1479d028af2 ("drm/panel: add panel driver for Xinpeng XPP055C272 panels") Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
diff --git a/drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c b/drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c index 22a14006765e..d7c9df673f35 100644 --- a/drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c +++ b/drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c @@ -139,7 +139,7 @@ static int xpp055c272_unprepare(struct drm_panel *panel) if (ret < 0) dev_err(ctx->dev, "failed to set display off: %d\n", ret); - mipi_dsi_dcs_enter_sleep_mode(dsi); + ret = mipi_dsi_dcs_enter_sleep_mode(dsi); if (ret < 0) { dev_err(ctx->dev, "failed to enter sleep mode: %d\n", ret); return ret;
Add check for the return value of mipi_dsi_dcs_enter_sleep_mode() and return the error if it fails in order to catch the error. Signed-off-by: Chen Ni <nichen@iscas.ac.cn> --- drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)