| Message ID | 20240620074720.852495-1-nichen@iscas.ac.cn (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] drm/panel: ltk050h3146w: add check for mipi_dsi_dcs_enter_sleep_mode | expand |
Le 20/06/2024 à 09:47, Chen Ni a écrit : > Add check for the return value of mipi_dsi_dcs_enter_sleep_mode() and > return the error if it fails in order to catch the error. > > Signed-off-by: Chen Ni <nichen@iscas.ac.cn> > --- > drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c > index 292aa26a456d..24bf05d0589f 100644 > --- a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c > +++ b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c > @@ -526,7 +526,7 @@ static int ltk050h3146w_unprepare(struct drm_panel *panel) > return ret; > } > > - mipi_dsi_dcs_enter_sleep_mode(dsi); > + ret = mipi_dsi_dcs_enter_sleep_mode(dsi); > if (ret < 0) { > dev_err(ctx->dev, "failed to enter sleep mode: %d\n", ret); > return ret; Reviewed-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> See: https://lore.kernel.org/all/588e8b4519487f6d33419c4b0fa7f8ea1b26cb58.1619869792.git.christophe.jaillet@wanadoo.fr/ which never got any feedback. CJ
On 6/20/2024 12:47 AM, Chen Ni wrote: > Add check for the return value of mipi_dsi_dcs_enter_sleep_mode() and > return the error if it fails in order to catch the error. > > Signed-off-by: Chen Ni <nichen@iscas.ac.cn> Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com> > --- > drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c > index 292aa26a456d..24bf05d0589f 100644 > --- a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c > +++ b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c > @@ -526,7 +526,7 @@ static int ltk050h3146w_unprepare(struct drm_panel *panel) > return ret; > } > > - mipi_dsi_dcs_enter_sleep_mode(dsi); > + ret = mipi_dsi_dcs_enter_sleep_mode(dsi); > if (ret < 0) { > dev_err(ctx->dev, "failed to enter sleep mode: %d\n", ret); > return ret; > -- > 2.25.1 >
On Thu, Jun 20, 2024 at 03:47:20PM GMT, Chen Ni wrote: > Add check for the return value of mipi_dsi_dcs_enter_sleep_mode() and > return the error if it fails in order to catch the error. > > Signed-off-by: Chen Ni <nichen@iscas.ac.cn> > --- > drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Fixes: 6ea4383b9214 ("drm/panel: add panel driver for Leadtek LTK050H3146W") Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
diff --git a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c index 292aa26a456d..24bf05d0589f 100644 --- a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c +++ b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c @@ -526,7 +526,7 @@ static int ltk050h3146w_unprepare(struct drm_panel *panel) return ret; } - mipi_dsi_dcs_enter_sleep_mode(dsi); + ret = mipi_dsi_dcs_enter_sleep_mode(dsi); if (ret < 0) { dev_err(ctx->dev, "failed to enter sleep mode: %d\n", ret); return ret;
Add check for the return value of mipi_dsi_dcs_enter_sleep_mode() and return the error if it fails in order to catch the error. Signed-off-by: Chen Ni <nichen@iscas.ac.cn> --- drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)