| Message ID | 20240617-usb-phy-gs101-v3-2-b66de9ae7424@linaro.org |
|---|---|
| State | Accepted |
| Commit | bbb28a1d733a94330f5778b4cd0dbccf6c34597d |
| Headers | show |
| Series | USB31DRD phy support for Google Tensor gs101 (HS & SS) | expand |
On 06/17/2024, André Draszik wrote: > Some versions of this IP have been integrated using separate PMU power > control registers for the HS and SS parts. One example is the Google > Tensor gs101 SoC. > > Such SoCs can now set pmu_offset_usbdrd0_phy_ss in their > exynos5_usbdrd_phy_drvdata for the SS phy to the appropriate value. > > The existing 'usbdrdphy' alias can not be used in this case because > that is meant for determining the correct PMU offset if multiple > distinct PHYs exist in the system (as opposed to one PHY with multiple > isolators). > > Signed-off-by: André Draszik <andre.draszik@linaro.org> Tested-by: Will McVicker <willmcvicker@google.com> [...] Thanks, Will
Hi André, On Mon, 17 Jun 2024 at 17:45, André Draszik <andre.draszik@linaro.org> wrote: > > Some versions of this IP have been integrated using separate PMU power > control registers for the HS and SS parts. One example is the Google > Tensor gs101 SoC. > > Such SoCs can now set pmu_offset_usbdrd0_phy_ss in their > exynos5_usbdrd_phy_drvdata for the SS phy to the appropriate value. > > The existing 'usbdrdphy' alias can not be used in this case because > that is meant for determining the correct PMU offset if multiple > distinct PHYs exist in the system (as opposed to one PHY with multiple > isolators). > > Signed-off-by: André Draszik <andre.draszik@linaro.org> > > --- Reviewed-by: Peter Griffin <peter.griffin@linaro.org> and Tested-by: Peter Griffin <peter.griffin@linaro.org> Tested using my Pixel 6 pro device. USB comes up and it is possible to use adb from the host to the phone regards, Peter [..]
diff --git a/drivers/phy/samsung/phy-exynos5-usbdrd.c b/drivers/phy/samsung/phy-exynos5-usbdrd.c index 15be966b50ae..b7e2526f4c06 100644 --- a/drivers/phy/samsung/phy-exynos5-usbdrd.c +++ b/drivers/phy/samsung/phy-exynos5-usbdrd.c @@ -186,6 +186,7 @@ struct exynos5_usbdrd_phy_drvdata { const struct exynos5_usbdrd_phy_config *phy_cfg; const struct phy_ops *phy_ops; u32 pmu_offset_usbdrd0_phy; + u32 pmu_offset_usbdrd0_phy_ss; u32 pmu_offset_usbdrd1_phy; bool has_common_clk_gate; }; @@ -1065,16 +1066,6 @@ static int exynos5_usbdrd_phy_probe(struct platform_device *pdev) if (channel < 0) dev_dbg(dev, "Not a multi-controller usbdrd phy\n"); - switch (channel) { - case 1: - pmu_offset = phy_drd->drv_data->pmu_offset_usbdrd1_phy; - break; - case 0: - default: - pmu_offset = phy_drd->drv_data->pmu_offset_usbdrd0_phy; - break; - } - /* Get Vbus regulators */ phy_drd->vbus = devm_regulator_get(dev, "vbus"); if (IS_ERR(phy_drd->vbus)) { @@ -1109,6 +1100,18 @@ static int exynos5_usbdrd_phy_probe(struct platform_device *pdev) phy_drd->phys[i].phy = phy; phy_drd->phys[i].index = i; phy_drd->phys[i].reg_pmu = reg_pmu; + switch (channel) { + case 1: + pmu_offset = drv_data->pmu_offset_usbdrd1_phy; + break; + case 0: + default: + pmu_offset = drv_data->pmu_offset_usbdrd0_phy; + if (i == EXYNOS5_DRDPHY_PIPE3 && drv_data + ->pmu_offset_usbdrd0_phy_ss) + pmu_offset = drv_data->pmu_offset_usbdrd0_phy_ss; + break; + } phy_drd->phys[i].pmu_offset = pmu_offset; phy_drd->phys[i].phy_cfg = &drv_data->phy_cfg[i]; phy_set_drvdata(phy, &phy_drd->phys[i]);
Some versions of this IP have been integrated using separate PMU power control registers for the HS and SS parts. One example is the Google Tensor gs101 SoC. Such SoCs can now set pmu_offset_usbdrd0_phy_ss in their exynos5_usbdrd_phy_drvdata for the SS phy to the appropriate value. The existing 'usbdrdphy' alias can not be used in this case because that is meant for determining the correct PMU offset if multiple distinct PHYs exist in the system (as opposed to one PHY with multiple isolators). Signed-off-by: André Draszik <andre.draszik@linaro.org> --- v3: use drv_data instead of phy_drd->drv_data for shorter lines --- drivers/phy/samsung/phy-exynos5-usbdrd.c | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-)