| Message ID | 20240612-sm4250-lpi-v4-0-a0342e47e21b@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | pinctrl: qcom: add sm4250 lpi pinctrl | expand |
On Sat, Jun 22, 2024 at 05:49:29PM GMT, Srinivas Kandagatla wrote: > Add support for sm4250 lpi pinctrl. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > --- > Changes in v4: > - update dt binding coding style > - Link to v3: https://lore.kernel.org/r/20240612-sm4250-lpi-v3-0-a8dce28f20a2@linaro.org Please keep previous changelog entries too. > > --- > Srinivas Kandagatla (2): > dt-bindings: pinctrl: qcom: Add SM4250 pinctrl > pinctrl: qcom: Introduce SM4250 LPI pinctrl driver > > .../pinctrl/qcom,sm4250-lpass-lpi-pinctrl.yaml | 118 +++++++++++ > drivers/pinctrl/qcom/Kconfig | 9 + > drivers/pinctrl/qcom/Makefile | 1 + > drivers/pinctrl/qcom/pinctrl-sm4250-lpass-lpi.c | 236 +++++++++++++++++++++ > 4 files changed, 364 insertions(+) > --- > base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0 > change-id: 20240612-sm4250-lpi-b1ab26b3b050 > > Best regards, > -- > Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >
On Sat, Jun 22, 2024 at 6:49 PM Srinivas Kandagatla <srinivas.kandagatla@linaro.org> wrote: > Add support for sm4250 lpi pinctrl. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> No major protests against v4 so patches applied! Yours, Linus Walleij
On 26/06/2024 12:04, Linus Walleij wrote: > On Sat, Jun 22, 2024 at 6:49 PM Srinivas Kandagatla > <srinivas.kandagatla@linaro.org> wrote: > >> Add support for sm4250 lpi pinctrl. >> >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > > No major protests against v4 so patches applied! There was a protest from Alexey, that driver does not probe correctly. Can you still drop it? Not sure if worth revert, though, better to fix incrementally. Best regards, Krzysztof
On 26/06/2024 14:42, Krzysztof Kozlowski wrote: > On 26/06/2024 12:04, Linus Walleij wrote: >> On Sat, Jun 22, 2024 at 6:49 PM Srinivas Kandagatla >> <srinivas.kandagatla@linaro.org> wrote: >> >>> Add support for sm4250 lpi pinctrl. >>> >>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >> >> No major protests against v4 so patches applied! > > There was a protest from Alexey, that driver does not probe correctly. > Can you still drop it? Not sure if worth revert, though, better to fix > incrementally. > Let me send out an incremental fix for this. These patches can go by itself. --srini > Best regards, > Krzysztof >
On 26.06.2024 12:04 PM, Linus Walleij wrote: > On Sat, Jun 22, 2024 at 6:49 PM Srinivas Kandagatla > <srinivas.kandagatla@linaro.org> wrote: > >> Add support for sm4250 lpi pinctrl. >> >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > > No major protests against v4 so patches applied! This was never sent to me.. We already have a driver for this SoC. 4250 and 6115 are the same (except the former is frequency-capped): pinctrl-sm6115-lpass-lpi.c Konrad
On 26/06/2024 16:07, Konrad Dybcio wrote: > > > On 26.06.2024 12:04 PM, Linus Walleij wrote: >> On Sat, Jun 22, 2024 at 6:49 PM Srinivas Kandagatla >> <srinivas.kandagatla@linaro.org> wrote: >> >>> Add support for sm4250 lpi pinctrl. >>> >>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >> >> No major protests against v4 so patches applied! > > This was never sent to me.. > seems like b4 auto-to-cc does not pick up your email ids from MAINTAINERS. > We already have a driver for this SoC. 4250 and 6115 are the same No, these are not same, here are some differences. - muxes for I2S mclk differ. - soundwire muxes are different - Slew rate offsets are different. I have verified this before sending this new driver out. --srini > (except the former is frequency-capped): pinctrl-sm6115-lpass-lpi.c > > Konrad
On Wed, Jun 26, 2024 at 3:42 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 26/06/2024 12:04, Linus Walleij wrote: > > On Sat, Jun 22, 2024 at 6:49 PM Srinivas Kandagatla > > <srinivas.kandagatla@linaro.org> wrote: > > > >> Add support for sm4250 lpi pinctrl. > >> > >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > > > > No major protests against v4 so patches applied! > > There was a protest from Alexey, that driver does not probe correctly. > Can you still drop it? Not sure if worth revert, though, better to fix > incrementally. Alexey sent a patch so I just applied that. Yours, Linus Walleij
On 26-Jun-24 17:18, Srinivas Kandagatla wrote: > > > On 26/06/2024 16:07, Konrad Dybcio wrote: >> >> >> On 26.06.2024 12:04 PM, Linus Walleij wrote: >>> On Sat, Jun 22, 2024 at 6:49 PM Srinivas Kandagatla >>> <srinivas.kandagatla@linaro.org> wrote: >>> >>>> Add support for sm4250 lpi pinctrl. >>>> >>>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >>> >>> No major protests against v4 so patches applied! >> >> This was never sent to me.. >> > seems like b4 auto-to-cc does not pick up your email ids from MAINTAINERS. > >> We already have a driver for this SoC. 4250 and 6115 are the same > No, these are not same, here are some differences. > - muxes for I2S mclk differ. > - soundwire muxes are different > - Slew rate offsets are different. > > I have verified this before sending this new driver out. I can't find anything to support what you're saying here Konrad
Add support for sm4250 lpi pinctrl. Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> --- Changes in v4: - update dt binding coding style - Link to v3: https://lore.kernel.org/r/20240612-sm4250-lpi-v3-0-a8dce28f20a2@linaro.org --- Srinivas Kandagatla (2): dt-bindings: pinctrl: qcom: Add SM4250 pinctrl pinctrl: qcom: Introduce SM4250 LPI pinctrl driver .../pinctrl/qcom,sm4250-lpass-lpi-pinctrl.yaml | 118 +++++++++++ drivers/pinctrl/qcom/Kconfig | 9 + drivers/pinctrl/qcom/Makefile | 1 + drivers/pinctrl/qcom/pinctrl-sm4250-lpass-lpi.c | 236 +++++++++++++++++++++ 4 files changed, 364 insertions(+) --- base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0 change-id: 20240612-sm4250-lpi-b1ab26b3b050 Best regards,