| Message ID | 20240624015612.341983-1-victor.liu@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RESEND] drm/panel: simple: Add missing display timing flags for KOE TX26D202VM0BWA | expand |
On 24/06/2024 03:56, Liu Ying wrote: > KOE TX26D202VM0BWA panel spec indicates the DE signal is active high in > timing chart, so add DISPLAY_FLAGS_DE_HIGH flag in display timing flags. > This aligns display_timing with panel_desc. > > Fixes: 8a07052440c2 ("drm/panel: simple: Add support for KOE TX26D202VM0BWA panel") > Signed-off-by: Liu Ying <victor.liu@nxp.com> > --- > drivers/gpu/drm/panel/panel-simple.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 20e3df1c59d4..7b70606e5760 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -2704,6 +2704,7 @@ static const struct display_timing koe_tx26d202vm0bwa_timing = { > .vfront_porch = { 3, 5, 10 }, > .vback_porch = { 2, 5, 10 }, > .vsync_len = { 5, 5, 5 }, > + .flags = DISPLAY_FLAGS_DE_HIGH, > }; > > static const struct panel_desc koe_tx26d202vm0bwa = { Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
On 6/23/2024 6:56 PM, Liu Ying wrote: > KOE TX26D202VM0BWA panel spec indicates the DE signal is active high in > timing chart, so add DISPLAY_FLAGS_DE_HIGH flag in display timing flags. > This aligns display_timing with panel_desc. > > Fixes: 8a07052440c2 ("drm/panel: simple: Add support for KOE TX26D202VM0BWA panel") > Signed-off-by: Liu Ying <victor.liu@nxp.com> Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com> > --- > drivers/gpu/drm/panel/panel-simple.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 20e3df1c59d4..7b70606e5760 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -2704,6 +2704,7 @@ static const struct display_timing koe_tx26d202vm0bwa_timing = { > .vfront_porch = { 3, 5, 10 }, > .vback_porch = { 2, 5, 10 }, > .vsync_len = { 5, 5, 5 }, > + .flags = DISPLAY_FLAGS_DE_HIGH, > }; > > static const struct panel_desc koe_tx26d202vm0bwa = { > -- > 2.34.1 >
Hi, On Mon, 24 Jun 2024 09:56:12 +0800, Liu Ying wrote: > KOE TX26D202VM0BWA panel spec indicates the DE signal is active high in > timing chart, so add DISPLAY_FLAGS_DE_HIGH flag in display timing flags. > This aligns display_timing with panel_desc. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-fixes) [1/1] drm/panel: simple: Add missing display timing flags for KOE TX26D202VM0BWA https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/37ce99b77762256ec9fda58d58fd613230151456
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 20e3df1c59d4..7b70606e5760 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -2704,6 +2704,7 @@ static const struct display_timing koe_tx26d202vm0bwa_timing = { .vfront_porch = { 3, 5, 10 }, .vback_porch = { 2, 5, 10 }, .vsync_len = { 5, 5, 5 }, + .flags = DISPLAY_FLAGS_DE_HIGH, }; static const struct panel_desc koe_tx26d202vm0bwa = {
KOE TX26D202VM0BWA panel spec indicates the DE signal is active high in timing chart, so add DISPLAY_FLAGS_DE_HIGH flag in display timing flags. This aligns display_timing with panel_desc. Fixes: 8a07052440c2 ("drm/panel: simple: Add support for KOE TX26D202VM0BWA panel") Signed-off-by: Liu Ying <victor.liu@nxp.com> --- drivers/gpu/drm/panel/panel-simple.c | 1 + 1 file changed, 1 insertion(+)