[net,0/4] vrf: fix source address selection with route leak

Message

Nicolas Dichtel June 24, 2024, 1:07 p.m. UTC

For patch 1 and 2, I didn't find the exact commit that introduced this bug, but
I suspect it has been here since the first version. I arbitrarily choose one.

 include/net/ip6_route.h                          | 19 +++++++-----
 net/ipv4/fib_semantics.c                         | 11 +++++--
 net/ipv6/addrconf.c                              |  3 +-
 net/ipv6/ip6_output.c                            |  1 +
 net/ipv6/route.c                                 |  2 +-
 tools/testing/selftests/net/vrf_route_leaking.sh | 38 ++++++++++++++++++++++--
 6 files changed, 61 insertions(+), 13 deletions(-)

Comments are welcome.

Regards,
Nicolas

Comments

Jakub Kicinski June 24, 2024, 8:30 p.m. UTC | #1

On Mon, 24 Jun 2024 15:07:52 +0200 Nicolas Dichtel wrote:
> For patch 1 and 2, I didn't find the exact commit that introduced this bug, but
> I suspect it has been here since the first version. I arbitrarily choose one.

I think this breaks fcnal:

https://netdev-3.bots.linux.dev/vmksft-net/results/654201/1-fcnal-test-sh/stdout

Nicolas Dichtel June 24, 2024, 9:37 p.m. UTC | #2

Le 24/06/2024 à 22:30, Jakub Kicinski a écrit :
> On Mon, 24 Jun 2024 15:07:52 +0200 Nicolas Dichtel wrote:
>> For patch 1 and 2, I didn't find the exact commit that introduced this bug, but
>> I suspect it has been here since the first version. I arbitrarily choose one.
> 
> I think this breaks fcnal:
> 
> https://netdev-3.bots.linux.dev/vmksft-net/results/654201/1-fcnal-test-sh/stdout
Thanks, I will have a look.