mbox series

[0/2] nfsd: proper fix for NULL deref in svc_pool_stats_start()

Message ID 20240624230734.17084-1-neilb@suse.de (mailing list archive)
Headers show
Series nfsd: proper fix for NULL deref in svc_pool_stats_start() | expand

Message

NeilBrown June 24, 2024, 11:04 p.m. UTC 
A recent patch attempted to fix a NULL pointer deref but introduced a
different NULL pointer deref and a possible unbalance unlock.

This series fixes the bug correctly and reverts the faulty fix.

(Sorry for not reviewing this patch earlier)

NeilBrown

 [PATCH 1/2] nfsd: initialise nfsd_info.mutex early.
 [PATCH 2/2] Revert "nfsd: fix oops when reading pool_stats before

Comments

Jeff Layton June 25, 2024, 10:16 a.m. UTC | #1 
On Tue, 2024-06-25 at 09:04 +1000, NeilBrown wrote:
> A recent patch attempted to fix a NULL pointer deref but introduced a
> different NULL pointer deref and a possible unbalance unlock.
> 
> This series fixes the bug correctly and reverts the faulty fix.
> 
> (Sorry for not reviewing this patch earlier)
> 
> NeilBrown
> 
>  [PATCH 1/2] nfsd: initialise nfsd_info.mutex early.
>  [PATCH 2/2] Revert "nfsd: fix oops when reading pool_stats before

Yes, this looks like a superior fix. Thanks, Neil!

Reviewed-by: Jeff Layton <jlayton@kernel.org>
Chuck Lever June 25, 2024, 2:22 p.m. UTC | #2 
On Tue, Jun 25, 2024 at 09:04:55AM +1000, NeilBrown wrote:
> A recent patch attempted to fix a NULL pointer deref but introduced a
> different NULL pointer deref and a possible unbalance unlock.
> 
> This series fixes the bug correctly and reverts the faulty fix.
> 
> (Sorry for not reviewing this patch earlier)
> 
> NeilBrown
> 
>  [PATCH 1/2] nfsd: initialise nfsd_info.mutex early.
>  [PATCH 2/2] Revert "nfsd: fix oops when reading pool_stats before

Applied to nfsd-fixes (for 6.10-rc). Thanks!