| Message ID | 20240624-b4-sc7180-camss-v3-0-89ece6471431@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add sc7180 camss subsys support | expand |
On 24/06/2024 13:13, George Chan via B4 Relay wrote:
> - Add RFT tag to all patches, since no tested-by at all.
Have you not tested this updated series ?
---
bod
On Mon, Jun 24, 2024 at 9:50 PM Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote: > > On 24/06/2024 13:13, George Chan via B4 Relay wrote: > > - Add RFT tag to all patches, since no tested-by at all. > > Have you not tested this updated series ? > > --- > bod Do you wanna add my tested-by too? It just feels weird to add my tested-by that way. Tested: Linus tree 5f583a3162ffd9f7999af76b8ab634ce2dac9f90 + 20240522154659.510-1-quic_grosikop@quicinc.com with mine patches Not test: linux-next + 20240522154659.510-1-quic_grosikop@quicinc.com + mine Just for reference, last month i pushed grosikop's patch with mine to below: https://github.com/99degree/linux/tree/camss-working
On 24.06.2024 5:03 PM, george chan wrote: > On Mon, Jun 24, 2024 at 9:50 PM Bryan O'Donoghue > <bryan.odonoghue@linaro.org> wrote: >> >> On 24/06/2024 13:13, George Chan via B4 Relay wrote: >>> - Add RFT tag to all patches, since no tested-by at all. >> >> Have you not tested this updated series ? >> >> --- >> bod > > Do you wanna add my tested-by too? It just feels weird to add my > tested-by that way. "RFT" means "I didn't actually test this" or "please provide more testing", not "there have not been tested-by's from others" Konrad
On 25/06/2024 17:57, Konrad Dybcio wrote: > On 24.06.2024 5:03 PM, george chan wrote: >> On Mon, Jun 24, 2024 at 9:50 PM Bryan O'Donoghue >> <bryan.odonoghue@linaro.org> wrote: >>> >>> On 24/06/2024 13:13, George Chan via B4 Relay wrote: >>>> - Add RFT tag to all patches, since no tested-by at all. >>> >>> Have you not tested this updated series ? >>> >>> --- >>> bod >> >> Do you wanna add my tested-by too? It just feels weird to add my >> tested-by that way. > > "RFT" means "I didn't actually test this" or "please provide more testing", > not "there have not been tested-by's from others" > > Konrad Exactly, RFT says to me "someone else needs to add testing here". In your next drop with the changes and RBs please drop RFT - unless you want someone else to test it for you. I don't think that's required right now since the set seems straight-forward enough and TBH the bit of 7180 hardware I have sits in a box unopened and will likely stay that way for the next few months at least. I think your example video is proof enough the thing works ;) --- bod
On Wed, Jun 26, 2024 at 7:44 AM Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote: > > On 25/06/2024 17:57, Konrad Dybcio wrote: > > On 24.06.2024 5:03 PM, george chan wrote: > >> On Mon, Jun 24, 2024 at 9:50 PM Bryan O'Donoghue > >> <bryan.odonoghue@linaro.org> wrote: > >>> > >>> On 24/06/2024 13:13, George Chan via B4 Relay wrote: > >>>> - Add RFT tag to all patches, since no tested-by at all. > >>> > >>> Have you not tested this updated series ? > >>> > >>> --- > >>> bod > >> > >> Do you wanna add my tested-by too? It just feels weird to add my > >> tested-by that way. > > > > "RFT" means "I didn't actually test this" or "please provide more testing", > > not "there have not been tested-by's from others" > > > > Konrad > > Exactly, RFT says to me "someone else needs to add testing here". > gotcha. > In your next drop with the changes and RBs please drop RFT - unless you > want someone else to test it for you. > If the test result on sm7125 is convincing then I have no problem. > I don't think that's required right now since the set seems > straight-forward enough and TBH the bit of 7180 hardware I have sits in > a box unopened and will likely stay that way for the next few months at > least. > > I think your example video is proof enough the thing works ;) Nice to hear. > > --- > bod
SM7125 is the SoC found in the Xiaomi Redmi Note 9 Pro(joyeuse) cellphone. This series adds support to bring up the CSIPHY, CSID, VFE/RDI interfaces. Since SM7125 is a low-speed variant of SC7180, SC7180 testers please take a look and have a test as well. sc7180 provides - 2 x VFE - 1 x VFE Lite - 2 x CSID - 1 x CSID Lite - 4 x CSI PHY The sc7180-camss binding should be comaptible with sdm845 yaml. I've copied a new yaml from sdm845-camss.yaml, strip all _src clk and put new maintainer information. If this is not desirable then i can add binding to existing sdm845 yaml instead. In addition, a bootable tree of sm7125/joyeuse is availble at: https://github.com/99degree/linux/tree/camss Signed-off-by: George Chan <gchan9527@gmail.com> --- Changes in v3: - Rebased on 20240522154659.510-1-quic_grosikop@quicinc.com - Bryan - Align email title to sc8280xp series - krzk - Line-up dt-binding example ordering to same as qcom,sm8250-camss.yaml - krzk - Drop non-related patches #5 #6 #7, I will send follow-up patches later - Add RFT tag to all patches, since no tested-by at all. - Drop required-opps node from dt - Link to v2: https://lore.kernel.org/r/20240624-b4-sc7180-camss-v2-0-0dfecdc50073@gmail.com Changes in v2: - Revised dt-binding title - krzk - Revised dt-binding maintainers - krzk - Drop all dt-binding minItems - krzk - Drops "|" symbol postfixed to description - krzk - Accending order of dt-binding required list - krzk - Added dt-binding item power-domain-name - Bryan - Reformat dt-binding example - krzk - Move reg as 2nd property - krzk - Move reg-names as 3nd property - krzk - Reduce iommus maxItems to 3 - rob's bot - Reduce clocks maxItems to 24 - rob's bot - Combine patch #2 and #3 - krzk and Bryan - Split eror-print log for clk name from #5 - Konrad - Reformat dt-node - krzk - Corrected phy init sequence for v1.2.2 - Bryan - Added 3 more debug info for missing clk and low clk-rate issue. - Adding port info to ports sub-node - Adding required-opps node to dt - Link to v1: https://lore.kernel.org/r/20240621-b4-sc7180-camss-v1-0-14937929f30e@gmail.com --- George Chan (5): dt-bindings: media: camss: Add qcom,sc7180-camss media: camss: csiphy-3ph: Add Gen2 v1.2.2 two-phase MIPI CSI-2 DPHY init media: qcom: camss: Add sc7180 support media: qcom: camss: Add sc7180 resources arm64: dts: qcom: sc7180: camss: Add CAMSS block definition .../bindings/media/qcom,sc7180-camss.yaml | 328 +++++++++++++++++++++ arch/arm64/boot/dts/qcom/sc7180.dtsi | 133 +++++++++ .../platform/qcom/camss/camss-csiphy-3ph-1-0.c | 135 +++++++++ drivers/media/platform/qcom/camss/camss-vfe.c | 2 + drivers/media/platform/qcom/camss/camss.c | 251 ++++++++++++++++ drivers/media/platform/qcom/camss/camss.h | 1 + 6 files changed, 850 insertions(+) --- base-commit: 28f69d2ea67db489d4a94e7d04c21b14e5aa6535 change-id: 20240621-b4-sc7180-camss-cddc6b60a9b4 Best regards,