| Message ID | 20240625-pm8916-tz-v1-1-a4c1f61e92dd@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | arm64: dts: qcom: pm8916: add temp-alarm thermal zone | expand |
On 25/06/2024 21:16, Dmitry Baryshkov wrote: > Define the themal zones using the temperature values in stage1 for this > platform so that the spmi-temp-alarm driver becomes active. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > arch/arm64/boot/dts/qcom/pm8916.dtsi | 31 ++++++++++++++++++++++++++++++- > 1 file changed, 30 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/pm8916.dtsi b/arch/arm64/boot/dts/qcom/pm8916.dtsi > index 4b2e8fb47d2d..2def48f2d101 100644 > --- a/arch/arm64/boot/dts/qcom/pm8916.dtsi > +++ b/arch/arm64/boot/dts/qcom/pm8916.dtsi > @@ -4,8 +4,37 @@ > #include <dt-bindings/interrupt-controller/irq.h> > #include <dt-bindings/spmi/spmi.h> > > -&spmi_bus { > +/ { > + thermal-zones { > + pm8150-thermal { > + polling-delay-passive = <100>; > + > + thermal-sensors = <&pm8916_temp>; > + > + trips { > + trip0 { > + temperature = <105000>; > + hysteresis = <0>; > + type = "passive"; > + }; > + > + trip1 { > + temperature = <125000>; > + hysteresis = <0>; > + type = "hot"; > + }; > + > + trip2 { > + temperature = <145000>; > + hysteresis = <0>; > + type = "critical"; > + }; > + }; > + }; > + }; > +}; 145 c seemed amazingly hot to me but apparently this is the more conservative of the possible set. https://git.codelinaro.org/clo/la/kernel/msm-3.10/-/blob/LA.BR.1.2.9.c26/Documentation/devicetree/bindings/thermal/qpnp-temp-alarm.txt?ref_type=heads#L28 Heating up even typing this email.. Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
On Tue, 25 Jun 2024 23:16:18 +0300, Dmitry Baryshkov wrote: > Define the themal zones using the temperature values in stage1 for this > platform so that the spmi-temp-alarm driver becomes active. > > Applied, thanks! [1/1] arm64: dts: qcom: pm8916: add temp-alarm thermal zone commit: b7a28d8a7b80dd5630a72d8d8cb9f2d1bde6a1ad Best regards,
On 25.06.2024 10:16 PM, Dmitry Baryshkov wrote: > Define the themal zones using the temperature values in stage1 for this > platform so that the spmi-temp-alarm driver becomes active. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > arch/arm64/boot/dts/qcom/pm8916.dtsi | 31 ++++++++++++++++++++++++++++++- > 1 file changed, 30 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/pm8916.dtsi b/arch/arm64/boot/dts/qcom/pm8916.dtsi > index 4b2e8fb47d2d..2def48f2d101 100644 > --- a/arch/arm64/boot/dts/qcom/pm8916.dtsi > +++ b/arch/arm64/boot/dts/qcom/pm8916.dtsi hmm > @@ -4,8 +4,37 @@ > #include <dt-bindings/interrupt-controller/irq.h> > #include <dt-bindings/spmi/spmi.h> > > -&spmi_bus { > +/ { > + thermal-zones { > + pm8150-thermal { hmm Konrad
On Wed, 26 Jun 2024 at 12:40, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > On 25.06.2024 10:16 PM, Dmitry Baryshkov wrote: > > Define the themal zones using the temperature values in stage1 for this > > platform so that the spmi-temp-alarm driver becomes active. > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > --- > > arch/arm64/boot/dts/qcom/pm8916.dtsi | 31 ++++++++++++++++++++++++++++++- > > 1 file changed, 30 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/pm8916.dtsi b/arch/arm64/boot/dts/qcom/pm8916.dtsi > > index 4b2e8fb47d2d..2def48f2d101 100644 > > --- a/arch/arm64/boot/dts/qcom/pm8916.dtsi > > +++ b/arch/arm64/boot/dts/qcom/pm8916.dtsi > > hmm > > > @@ -4,8 +4,37 @@ > > #include <dt-bindings/interrupt-controller/irq.h> > > #include <dt-bindings/spmi/spmi.h> > > > > -&spmi_bus { > > +/ { > > + thermal-zones { > > + pm8150-thermal { > > hmm Will fix in v2.. > > Konrad
diff --git a/arch/arm64/boot/dts/qcom/pm8916.dtsi b/arch/arm64/boot/dts/qcom/pm8916.dtsi index 4b2e8fb47d2d..2def48f2d101 100644 --- a/arch/arm64/boot/dts/qcom/pm8916.dtsi +++ b/arch/arm64/boot/dts/qcom/pm8916.dtsi @@ -4,8 +4,37 @@ #include <dt-bindings/interrupt-controller/irq.h> #include <dt-bindings/spmi/spmi.h> -&spmi_bus { +/ { + thermal-zones { + pm8150-thermal { + polling-delay-passive = <100>; + + thermal-sensors = <&pm8916_temp>; + + trips { + trip0 { + temperature = <105000>; + hysteresis = <0>; + type = "passive"; + }; + + trip1 { + temperature = <125000>; + hysteresis = <0>; + type = "hot"; + }; + + trip2 { + temperature = <145000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + }; +}; +&spmi_bus { pm8916_0: pmic@0 { compatible = "qcom,pm8916", "qcom,spmi-pmic"; reg = <0x0 SPMI_USID>;
Define the themal zones using the temperature values in stage1 for this platform so that the spmi-temp-alarm driver becomes active. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- arch/arm64/boot/dts/qcom/pm8916.dtsi | 31 ++++++++++++++++++++++++++++++- 1 file changed, 30 insertions(+), 1 deletion(-) --- base-commit: 62c97045b8f720c2eac807a5f38e26c9ed512371 change-id: 20240625-pm8916-tz-c8dd606940dc Best regards,