| Message ID | 20240602114439.1611-1-quic_jkona@quicinc.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add support for videocc and camcc on SM8650 | expand |
On Sun, 02 Jun 2024 17:14:31 +0530, Jagadeesh Kona wrote: > Add support for video and camera clock controllers on Qualcomm SM8650 > platform. > > Changes in V4: > [PATCH 1/8]: Updated commit text. Replaced :: with : in SM8450 videocc > YAML file as Krzysztof's comment in V3 > [PATCH 5/8]: Replaced :: with : in SM8450 camcc YAML file. Updated commit > text and dropped Fixes tag as per Johan's comments in V3 > Added R-By tags received till V3 > > [...] Applied, thanks! [8/8] arm64: dts: qcom: sm8650: Add video and camera clock controllers commit: 0bdb730e63f6628b0f8deb3f11991b1d10f9bca5 Best regards,
On 26/06/2024 06:30, Bjorn Andersson wrote: > > On Sun, 02 Jun 2024 17:14:31 +0530, Jagadeesh Kona wrote: >> Add support for video and camera clock controllers on Qualcomm SM8650 >> platform. >> >> Changes in V4: >> [PATCH 1/8]: Updated commit text. Replaced :: with : in SM8450 videocc >> YAML file as Krzysztof's comment in V3 >> [PATCH 5/8]: Replaced :: with : in SM8450 camcc YAML file. Updated commit >> text and dropped Fixes tag as per Johan's comments in V3 >> Added R-By tags received till V3 >> >> [...] > > Applied, thanks! > > [8/8] arm64: dts: qcom: sm8650: Add video and camera clock controllers > commit: 0bdb730e63f6628b0f8deb3f11991b1d10f9bca5 That's the only message I have that something here was applied, but it seems entire patchset was applied. Patchset ended on your branch on 25th of June with HEAD 09ea421652a8 ("clk: qcom: camcc-sm8650: Add SM8650 camera clock controller driver") and it does not compile. Really, this HEAD does not compile. This means: 1. This branch has code which was never built by you, 2. This branch has code which was never built by robots, 3. Or none above - so it was built - but reports were ignored. In case of 1 and 2, can we please check if your tree receives proper LKP emails about build failures and successes? Or do you build (or anyone else) your branches? Later this branch (or head) was sent to arm-soc, so basically for 2-3 weeks this had build failure, which went to upstream maintainer. Best regards, Krzysztof
Add support for video and camera clock controllers on Qualcomm SM8650 platform. Changes in V4: [PATCH 1/8]: Updated commit text. Replaced :: with : in SM8450 videocc YAML file as Krzysztof's comment in V3 [PATCH 5/8]: Replaced :: with : in SM8450 camcc YAML file. Updated commit text and dropped Fixes tag as per Johan's comments in V3 Added R-By tags received till V3 Changes in V3: [PATCH 1/8]: Split incorrect header file name in SM8450 videocc bindings into a separate patch and added fixes tag [PATCH 2/8]: Added new header file for SM8650 videocc to define the extra clocks and resets on top of SM8450 videocc bindings, Dropped Krzysztof R-By tag due to these changes [PATCH 3/8]: Updated SM8550 videocc driver to use new SM8650 videocc header file, added Dmitry and Konrad R-By tags [PATCH 4/8]: Updated offset variable name to sleep_clk_offset in probe and added Dmitry R-By tag [PATCH 5/8]: This patch is newly added to fix the incorrect order for SC8280XP camcc header file in bindings [PATCH 6/8]: Fixed the incorrect alphabetical order for SM8650 camcc compatible and header files, added Krzysztof R-By tag and Vladimir Acked-By tags [PATCH 7/8]: No changes, added R-By tags received till V2 series [PATCH 8/8]: Dropped required-opps property in videocc and camcc nodes and updated DT file to use new SM8650 videocc header file, added Vladimir R-By tag Changes in V2: - Updated commit text for videocc dt-bindings patch as Krzysztof suggested - Moved videocc XO clk ares to a separate patch and added fixes tag as per review comments - Inverted the logic in videocc probe to add new SM8650 specific videocc clocks based on SM8650 compatible string as Dmitry suggested - Used module_platform_driver() for SM8650 camcc driver - Updated driver name from cam_cc-sm8650 to camcc-sm8650 as Bryan suggested - Used qcom_branch_set_clk_en() helper to enable clocks in camcc sm8650 probe - Added Krzysztof and Bryan Reviewed-by tags to dt-bindings and camcc patches received in V1 Previous series: V3: https://lore.kernel.org/all/20240430142757.16872-1-quic_jkona@quicinc.com/ V2 RESEND: https://lore.kernel.org/all/20240321092529.13362-1-quic_jkona@quicinc.com/ V2: https://lore.kernel.org/all/20240220135121.22578-1-quic_jkona@quicinc.com/ V1: https://lore.kernel.org/linux-kernel/20240206113145.31096-1-quic_jkona@quicinc.com/T/ Jagadeesh Kona (8): dt-bindings: clock: qcom: Update SM8450 videocc header file name dt-bindings: clock: qcom: Add SM8650 video clock controller clk: qcom: videocc-sm8550: Add support for videocc XO clk ares clk: qcom: videocc-sm8550: Add SM8650 video clock controller dt-bindings: clock: qcom: Update the order of SC8280XP camcc header dt-bindings: clock: qcom: Add SM8650 camera clock controller clk: qcom: camcc-sm8650: Add SM8650 camera clock controller driver arm64: dts: qcom: sm8650: Add video and camera clock controllers .../bindings/clock/qcom,sm8450-camcc.yaml | 7 +- .../bindings/clock/qcom,sm8450-videocc.yaml | 6 +- arch/arm64/boot/dts/qcom/sm8650.dtsi | 26 + drivers/clk/qcom/Kconfig | 8 + drivers/clk/qcom/Makefile | 1 + drivers/clk/qcom/camcc-sm8650.c | 3591 +++++++++++++++++ drivers/clk/qcom/videocc-sm8550.c | 156 +- include/dt-bindings/clock/qcom,sm8650-camcc.h | 195 + .../dt-bindings/clock/qcom,sm8650-videocc.h | 23 + 9 files changed, 4005 insertions(+), 8 deletions(-) create mode 100644 drivers/clk/qcom/camcc-sm8650.c create mode 100644 include/dt-bindings/clock/qcom,sm8650-camcc.h create mode 100644 include/dt-bindings/clock/qcom,sm8650-videocc.h