| Message ID | 20240622110929.3115714-2-a-bhatia1@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/bridge: cdns-dsi: Fix the color-shift issue | expand |
Hi, On 22/06/2024 14:09, Aradhya Bhatia wrote: > Fix the OF node pointer passed to the of_drm_find_bridge() call to find > the next bridge in the display chain. > > To find the next bridge in the pipeline, we need to pass "np" - the OF > node pointer of the next entity in the devicetree chain. Passing > "of_node" to of_drm_find_bridge will make the function try to fetch the > bridge for the cdns-dsi which is not what's required. > > Fix that. The code looks fine, but I'd write the subject and desc from a different perspective. The subject could be something like "Fix connecting to a sink bridge", and the desc could first say that connecting the sink to a DSI panel works, but connecting to a bridge fails, as wrong OF node is passed to of_drm_find_bridge(). Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Tomi > Fixes: e19233955d9e ("drm/bridge: Add Cadence DSI driver") > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Signed-off-by: Aradhya Bhatia <a-bhatia1@ti.com> > --- > drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c > index 7457d38622b0..b016f2ba06bb 100644 > --- a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c > +++ b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c > @@ -952,7 +952,7 @@ static int cdns_dsi_attach(struct mipi_dsi_host *host, > bridge = drm_panel_bridge_add_typed(panel, > DRM_MODE_CONNECTOR_DSI); > } else { > - bridge = of_drm_find_bridge(dev->dev.of_node); > + bridge = of_drm_find_bridge(np); > if (!bridge) > bridge = ERR_PTR(-EINVAL); > }
diff --git a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c index 7457d38622b0..b016f2ba06bb 100644 --- a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c +++ b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c @@ -952,7 +952,7 @@ static int cdns_dsi_attach(struct mipi_dsi_host *host, bridge = drm_panel_bridge_add_typed(panel, DRM_MODE_CONNECTOR_DSI); } else { - bridge = of_drm_find_bridge(dev->dev.of_node); + bridge = of_drm_find_bridge(np); if (!bridge) bridge = ERR_PTR(-EINVAL); }
Fix the OF node pointer passed to the of_drm_find_bridge() call to find the next bridge in the display chain. To find the next bridge in the pipeline, we need to pass "np" - the OF node pointer of the next entity in the devicetree chain. Passing "of_node" to of_drm_find_bridge will make the function try to fetch the bridge for the cdns-dsi which is not what's required. Fix that. Fixes: e19233955d9e ("drm/bridge: Add Cadence DSI driver") Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Signed-off-by: Aradhya Bhatia <a-bhatia1@ti.com> --- drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)