Message ID | 20240626143302.810632-5-quic_devipriy@quicinc.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | Add NSS clock controller support for IPQ9574 | expand |
On Wed, 26 Jun 2024 20:02:59 +0530, Devi Priya wrote: > Add NSSCC clock and reset definitions for ipq9574. > > Signed-off-by: Devi Priya <quic_devipriy@quicinc.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Changes in V5: > - Dropped interconnects and added interconnect-cells to NSS > clock provider so that it can be used as icc provider. > > .../bindings/clock/qcom,ipq9574-nsscc.yaml | 74 +++++++++ > .../dt-bindings/clock/qcom,ipq9574-nsscc.h | 152 ++++++++++++++++++ > .../dt-bindings/reset/qcom,ipq9574-nsscc.h | 134 +++++++++++++++ > 3 files changed, 360 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml > create mode 100644 include/dt-bindings/clock/qcom,ipq9574-nsscc.h > create mode 100644 include/dt-bindings/reset/qcom,ipq9574-nsscc.h > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Error: Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.example.dts:26.26-27 syntax error FATAL ERROR: Unable to parse input tree make[2]: *** [scripts/Makefile.lib:427: Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.example.dtb] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2 make: *** [Makefile:240: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240626143302.810632-5-quic_devipriy@quicinc.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Wed, Jun 26, 2024 at 09:35:20AM -0600, Rob Herring (Arm) wrote: > > On Wed, 26 Jun 2024 20:02:59 +0530, Devi Priya wrote: > > Add NSSCC clock and reset definitions for ipq9574. > > > > Signed-off-by: Devi Priya <quic_devipriy@quicinc.com> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Changes in V5: > > - Dropped interconnects and added interconnect-cells to NSS > > clock provider so that it can be used as icc provider. > > > > .../bindings/clock/qcom,ipq9574-nsscc.yaml | 74 +++++++++ > > .../dt-bindings/clock/qcom,ipq9574-nsscc.h | 152 ++++++++++++++++++ > > .../dt-bindings/reset/qcom,ipq9574-nsscc.h | 134 +++++++++++++++ > > 3 files changed, 360 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml > > create mode 100644 include/dt-bindings/clock/qcom,ipq9574-nsscc.h > > create mode 100644 include/dt-bindings/reset/qcom,ipq9574-nsscc.h > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Error: Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.example.dts:26.26-27 syntax error > FATAL ERROR: Unable to parse input tree Hi Devi Version 4 of these patches had the same exact problem. There was not an email explaining it is a false positive etc, so i have to assume it is a real error. So why has it not been fixed? Qualcomm patches are under a microscope at the moment because of how bad things went a couple of months ago with patches. You cannot ignore things like this, because the damage to Qualcomm reputation is going to make it impossible to get patches merged soon. Andrew
On 6/26/2024 10:56 PM, Andrew Lunn wrote: > On Wed, Jun 26, 2024 at 09:35:20AM -0600, Rob Herring (Arm) wrote: >> >> On Wed, 26 Jun 2024 20:02:59 +0530, Devi Priya wrote: >>> Add NSSCC clock and reset definitions for ipq9574. >>> >>> Signed-off-by: Devi Priya <quic_devipriy@quicinc.com> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> --- >>> Changes in V5: >>> - Dropped interconnects and added interconnect-cells to NSS >>> clock provider so that it can be used as icc provider. >>> >>> .../bindings/clock/qcom,ipq9574-nsscc.yaml | 74 +++++++++ >>> .../dt-bindings/clock/qcom,ipq9574-nsscc.h | 152 ++++++++++++++++++ >>> .../dt-bindings/reset/qcom,ipq9574-nsscc.h | 134 +++++++++++++++ >>> 3 files changed, 360 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml >>> create mode 100644 include/dt-bindings/clock/qcom,ipq9574-nsscc.h >>> create mode 100644 include/dt-bindings/reset/qcom,ipq9574-nsscc.h >>> >> >> My bot found errors running 'make dt_binding_check' on your patch: >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> Error: Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.example.dts:26.26-27 syntax error >> FATAL ERROR: Unable to parse input tree > > Hi Devi > > Version 4 of these patches had the same exact problem. There was not > an email explaining it is a false positive etc, so i have to assume it > is a real error. So why has it not been fixed? > > Qualcomm patches are under a microscope at the moment because of how > bad things went a couple of months ago with patches. You cannot ignore > things like this, because the damage to Qualcomm reputation is going > to make it impossible to get patches merged soon. > Hi Andrew, Very sorry for the inconvenience. I had run dt_binding_check locally on V4 patches and did not face any errors. I somehow missed to notice the binding check error that was reported on V4. Thus I went ahead and posted the same in V5. Will ensure such things are not repeated henceforth. Thanks, Devi Priya > Andrew
On 27/06/2024 07:25, Devi Priya wrote: > > > On 6/26/2024 10:56 PM, Andrew Lunn wrote: >> On Wed, Jun 26, 2024 at 09:35:20AM -0600, Rob Herring (Arm) wrote: >>> >>> On Wed, 26 Jun 2024 20:02:59 +0530, Devi Priya wrote: >>>> Add NSSCC clock and reset definitions for ipq9574. >>>> >>>> Signed-off-by: Devi Priya <quic_devipriy@quicinc.com> >>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>> --- >>>> Changes in V5: >>>> - Dropped interconnects and added interconnect-cells to NSS >>>> clock provider so that it can be used as icc provider. >>>> >>>> .../bindings/clock/qcom,ipq9574-nsscc.yaml | 74 +++++++++ >>>> .../dt-bindings/clock/qcom,ipq9574-nsscc.h | 152 ++++++++++++++++++ >>>> .../dt-bindings/reset/qcom,ipq9574-nsscc.h | 134 +++++++++++++++ >>>> 3 files changed, 360 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml >>>> create mode 100644 include/dt-bindings/clock/qcom,ipq9574-nsscc.h >>>> create mode 100644 include/dt-bindings/reset/qcom,ipq9574-nsscc.h >>>> >>> >>> My bot found errors running 'make dt_binding_check' on your patch: >>> >>> yamllint warnings/errors: >>> >>> dtschema/dtc warnings/errors: >>> Error: Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.example.dts:26.26-27 syntax error >>> FATAL ERROR: Unable to parse input tree >> >> Hi Devi >> >> Version 4 of these patches had the same exact problem. There was not >> an email explaining it is a false positive etc, so i have to assume it >> is a real error. So why has it not been fixed? >> >> Qualcomm patches are under a microscope at the moment because of how >> bad things went a couple of months ago with patches. You cannot ignore >> things like this, because the damage to Qualcomm reputation is going >> to make it impossible to get patches merged soon. >> > Hi Andrew, > Very sorry for the inconvenience. > I had run dt_binding_check locally on V4 patches and did not face any > errors. I somehow missed to notice the binding check error that was > reported on V4. Thus I went ahead and posted the same in V5. > Will ensure such things are not repeated henceforth. If the warning is expected, e.g. due to missing patches, it's beneficial to mention this in the changelog (---). Otherwise all maintainers my ignore your patch because you have issues reported by automation. Anyway, up to you. Best regards, Krzysztof
On 6/27/2024 1:12 PM, Krzysztof Kozlowski wrote: > On 27/06/2024 07:25, Devi Priya wrote: >> >> >> On 6/26/2024 10:56 PM, Andrew Lunn wrote: >>> On Wed, Jun 26, 2024 at 09:35:20AM -0600, Rob Herring (Arm) wrote: >>>> >>>> On Wed, 26 Jun 2024 20:02:59 +0530, Devi Priya wrote: >>>>> Add NSSCC clock and reset definitions for ipq9574. >>>>> >>>>> Signed-off-by: Devi Priya <quic_devipriy@quicinc.com> >>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>>> --- >>>>> Changes in V5: >>>>> - Dropped interconnects and added interconnect-cells to NSS >>>>> clock provider so that it can be used as icc provider. >>>>> >>>>> .../bindings/clock/qcom,ipq9574-nsscc.yaml | 74 +++++++++ >>>>> .../dt-bindings/clock/qcom,ipq9574-nsscc.h | 152 ++++++++++++++++++ >>>>> .../dt-bindings/reset/qcom,ipq9574-nsscc.h | 134 +++++++++++++++ >>>>> 3 files changed, 360 insertions(+) >>>>> create mode 100644 Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml >>>>> create mode 100644 include/dt-bindings/clock/qcom,ipq9574-nsscc.h >>>>> create mode 100644 include/dt-bindings/reset/qcom,ipq9574-nsscc.h >>>>> >>>> >>>> My bot found errors running 'make dt_binding_check' on your patch: >>>> >>>> yamllint warnings/errors: >>>> >>>> dtschema/dtc warnings/errors: >>>> Error: Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.example.dts:26.26-27 syntax error >>>> FATAL ERROR: Unable to parse input tree >>> >>> Hi Devi >>> >>> Version 4 of these patches had the same exact problem. There was not >>> an email explaining it is a false positive etc, so i have to assume it >>> is a real error. So why has it not been fixed? >>> >>> Qualcomm patches are under a microscope at the moment because of how >>> bad things went a couple of months ago with patches. You cannot ignore >>> things like this, because the damage to Qualcomm reputation is going >>> to make it impossible to get patches merged soon. >>> >> Hi Andrew, >> Very sorry for the inconvenience. >> I had run dt_binding_check locally on V4 patches and did not face any >> errors. I somehow missed to notice the binding check error that was >> reported on V4. Thus I went ahead and posted the same in V5. >> Will ensure such things are not repeated henceforth. > > If the warning is expected, e.g. due to missing patches, it's beneficial > to mention this in the changelog (---). Otherwise all maintainers my > ignore your patch because you have issues reported by automation. > Sure, got it Thanks, Devi Priya > Anyway, up to you. > > Best regards, > Krzysztof >
On 6/26/2024 9:05 PM, Rob Herring (Arm) wrote: > > On Wed, 26 Jun 2024 20:02:59 +0530, Devi Priya wrote: >> Add NSSCC clock and reset definitions for ipq9574. >> >> Signed-off-by: Devi Priya <quic_devipriy@quicinc.com> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> Changes in V5: >> - Dropped interconnects and added interconnect-cells to NSS >> clock provider so that it can be used as icc provider. >> >> .../bindings/clock/qcom,ipq9574-nsscc.yaml | 74 +++++++++ >> .../dt-bindings/clock/qcom,ipq9574-nsscc.h | 152 ++++++++++++++++++ >> .../dt-bindings/reset/qcom,ipq9574-nsscc.h | 134 +++++++++++++++ >> 3 files changed, 360 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml >> create mode 100644 include/dt-bindings/clock/qcom,ipq9574-nsscc.h >> create mode 100644 include/dt-bindings/reset/qcom,ipq9574-nsscc.h >> > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Error: Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.example.dts:26.26-27 syntax error > FATAL ERROR: Unable to parse input tree > make[2]: *** [scripts/Makefile.lib:427: Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.example.dtb] Error 1 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2 > make: *** [Makefile:240: __sub-make] Error 2 > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240626143302.810632-5-quic_devipriy@quicinc.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > Hi Rob, We tried running dt_binding_check on linux-next and we do not face any sort of errors. However in case of v6.10-rc1, patch[1] failed to apply as the dependent patch[2] is not available on rc1. [1] https://patchwork.kernel.org/project/linux-arm-msm/patch/20240626143302.810632-3-quic_devipriy@quicinc.com/ [2] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20240531&id=475beea0b9f631656b5cc39429a39696876af613 Patch [2] does not hold any functional dependency on this series but has a patch rebase dependency. The Bot has went ahead and tried running the dt_binding_check on patch https://patchwork.kernel.org/project/linux-arm-msm/patch/20240626143302.810632-5-quic_devipriy@quicinc.com/ which is dependent on patch [1] and hence the issue was reported. Is this the expected behaviour? Thanks & Regards, Devi Priya >
On 02/07/2024 14:13, Devi Priya wrote: > > > On 6/26/2024 9:05 PM, Rob Herring (Arm) wrote: >> >> On Wed, 26 Jun 2024 20:02:59 +0530, Devi Priya wrote: >>> Add NSSCC clock and reset definitions for ipq9574. >>> >>> Signed-off-by: Devi Priya <quic_devipriy@quicinc.com> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> --- >>> Changes in V5: >>> - Dropped interconnects and added interconnect-cells to NSS >>> clock provider so that it can be used as icc provider. >>> >>> .../bindings/clock/qcom,ipq9574-nsscc.yaml | 74 +++++++++ >>> .../dt-bindings/clock/qcom,ipq9574-nsscc.h | 152 ++++++++++++++++++ >>> .../dt-bindings/reset/qcom,ipq9574-nsscc.h | 134 +++++++++++++++ >>> 3 files changed, 360 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml >>> create mode 100644 include/dt-bindings/clock/qcom,ipq9574-nsscc.h >>> create mode 100644 include/dt-bindings/reset/qcom,ipq9574-nsscc.h >>> >> >> My bot found errors running 'make dt_binding_check' on your patch: >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> Error: Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.example.dts:26.26-27 syntax error >> FATAL ERROR: Unable to parse input tree >> make[2]: *** [scripts/Makefile.lib:427: Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.example.dtb] Error 1 >> make[2]: *** Waiting for unfinished jobs.... >> make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2 >> make: *** [Makefile:240: __sub-make] Error 2 >> >> doc reference errors (make refcheckdocs): >> >> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240626143302.810632-5-quic_devipriy@quicinc.com >> >> The base for the series is generally the latest rc1. A different dependency >> should be noted in *this* patch. >> >> If you already ran 'make dt_binding_check' and didn't see the above >> error(s), then make sure 'yamllint' is installed and dt-schema is up to >> date: >> >> pip3 install dtschema --upgrade >> >> Please check and re-submit after running the above command yourself. Note >> that DT_SCHEMA_FILES can be set to your schema file to speed up checking >> your schema. However, it must be unset to test all examples with your schema. >> Hi Rob, > > We tried running dt_binding_check on linux-next and we do not face any > sort of errors. > > However in case of v6.10-rc1, patch[1] failed to apply as the dependent > patch[2] is not available on rc1. > > [1] > https://patchwork.kernel.org/project/linux-arm-msm/patch/20240626143302.810632-3-quic_devipriy@quicinc.com/ > > [2] > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20240531&id=475beea0b9f631656b5cc39429a39696876af613 > > Patch [2] does not hold any functional dependency on this series but has > a patch rebase dependency. > > The Bot has went ahead and tried running the dt_binding_check on patch > https://patchwork.kernel.org/project/linux-arm-msm/patch/20240626143302.810632-5-quic_devipriy@quicinc.com/ > which is dependent on patch [1] and hence the issue was reported. > > Is this the expected behaviour? If you expect your patch not to be ignored after such feedback, explain briefly missing dependency in changelog. I think Rob told it many times already. Otherwise you will get this message *every time* and maintainers might ignore your patch, due to unresolved reports from automation. Best regards, Krzysztof
On 7/2/2024 6:44 PM, Krzysztof Kozlowski wrote: > On 02/07/2024 14:13, Devi Priya wrote: >> >> >> On 6/26/2024 9:05 PM, Rob Herring (Arm) wrote: >>> >>> On Wed, 26 Jun 2024 20:02:59 +0530, Devi Priya wrote: >>>> Add NSSCC clock and reset definitions for ipq9574. >>>> >>>> Signed-off-by: Devi Priya <quic_devipriy@quicinc.com> >>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>> --- >>>> Changes in V5: >>>> - Dropped interconnects and added interconnect-cells to NSS >>>> clock provider so that it can be used as icc provider. >>>> >>>> .../bindings/clock/qcom,ipq9574-nsscc.yaml | 74 +++++++++ >>>> .../dt-bindings/clock/qcom,ipq9574-nsscc.h | 152 ++++++++++++++++++ >>>> .../dt-bindings/reset/qcom,ipq9574-nsscc.h | 134 +++++++++++++++ >>>> 3 files changed, 360 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml >>>> create mode 100644 include/dt-bindings/clock/qcom,ipq9574-nsscc.h >>>> create mode 100644 include/dt-bindings/reset/qcom,ipq9574-nsscc.h >>>> >>> >>> My bot found errors running 'make dt_binding_check' on your patch: >>> >>> yamllint warnings/errors: >>> >>> dtschema/dtc warnings/errors: >>> Error: Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.example.dts:26.26-27 syntax error >>> FATAL ERROR: Unable to parse input tree >>> make[2]: *** [scripts/Makefile.lib:427: Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.example.dtb] Error 1 >>> make[2]: *** Waiting for unfinished jobs.... >>> make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2 >>> make: *** [Makefile:240: __sub-make] Error 2 >>> >>> doc reference errors (make refcheckdocs): >>> >>> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240626143302.810632-5-quic_devipriy@quicinc.com >>> >>> The base for the series is generally the latest rc1. A different dependency >>> should be noted in *this* patch. >>> >>> If you already ran 'make dt_binding_check' and didn't see the above >>> error(s), then make sure 'yamllint' is installed and dt-schema is up to >>> date: >>> >>> pip3 install dtschema --upgrade >>> >>> Please check and re-submit after running the above command yourself. Note >>> that DT_SCHEMA_FILES can be set to your schema file to speed up checking >>> your schema. However, it must be unset to test all examples with your schema. >>> Hi Rob, >> >> We tried running dt_binding_check on linux-next and we do not face any >> sort of errors. >> >> However in case of v6.10-rc1, patch[1] failed to apply as the dependent >> patch[2] is not available on rc1. >> >> [1] >> https://patchwork.kernel.org/project/linux-arm-msm/patch/20240626143302.810632-3-quic_devipriy@quicinc.com/ >> >> [2] >> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20240531&id=475beea0b9f631656b5cc39429a39696876af613 >> >> Patch [2] does not hold any functional dependency on this series but has >> a patch rebase dependency. >> >> The Bot has went ahead and tried running the dt_binding_check on patch >> https://patchwork.kernel.org/project/linux-arm-msm/patch/20240626143302.810632-5-quic_devipriy@quicinc.com/ >> which is dependent on patch [1] and hence the issue was reported. >> >> Is this the expected behaviour? > > If you expect your patch not to be ignored after such feedback, explain > briefly missing dependency in changelog. I think Rob told it many times > already. > > Otherwise you will get this message *every time* and maintainers might > ignore your patch, due to unresolved reports from automation. Hi Krzysztof, We posted our patches based on linux-next and the bot was trying to run the dt_binding_checks on rc1 wherein patch [1] failed to apply as patch [2] was missing on rc1 but was available on linux-next. The patch application failure on rc1 was the reason behind the binding error and there were no dependencies on linux-next. Thanks & Regards, Devi Priya > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml b/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml new file mode 100644 index 000000000000..5a6a097b3036 --- /dev/null +++ b/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml @@ -0,0 +1,74 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/clock/qcom,ipq9574-nsscc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm Networking Sub System Clock & Reset Controller on IPQ9574 + +maintainers: + - Bjorn Andersson <andersson@kernel.org> + - Anusha Rao <quic_anusha@quicinc.com> + +description: | + Qualcomm networking sub system clock control module provides the clocks, + resets and power domains on IPQ9574 + + See also:: + include/dt-bindings/clock/qcom,ipq9574-nsscc.h + include/dt-bindings/reset/qcom,ipq9574-nsscc.h + +properties: + compatible: + const: qcom,ipq9574-nsscc + + clocks: + items: + - description: Board XO source + - description: Bias PLL cc clock source + - description: Bias PLL nss noc clock source + - description: Bias PLL ubi nc clock source + - description: GCC GPLL0 OUT AUX clock source + - description: Uniphy0 NSS Rx clock source + - description: Uniphy0 NSS Tx clock source + - description: Uniphy1 NSS Rx clock source + - description: Uniphy1 NSS Tx clock source + - description: Uniphy2 NSS Rx clock source + - description: Uniphy2 NSS Tx clock source + - description: GCC NSSCC clock source + + '#interconnect-cells': + const: 1 + +required: + - compatible + - clocks + +allOf: + - $ref: qcom,gcc.yaml# + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/clock/qcom,ipq9574-gcc.h> + clock-controller@39b00000 { + compatible = "qcom,ipq9574-nsscc"; + reg = <0x39b00000 0x80000>; + clocks = <&xo_board_clk>, + <&bias_pll_cc_clk>, + <&bias_pll_nss_noc_clk>, + <&bias_pll_ubi_nc_clk>, + <&gcc GPLL0_OUT_AUX>, + <&uniphy 0>, + <&uniphy 1>, + <&uniphy 2>, + <&uniphy 3>, + <&uniphy 4>, + <&uniphy 5>, + <&gcc GCC_NSSCC_CLK>; + #clock-cells = <1>; + #reset-cells = <1>; + #power-domain-cells = <1>; + }; +... diff --git a/include/dt-bindings/clock/qcom,ipq9574-nsscc.h b/include/dt-bindings/clock/qcom,ipq9574-nsscc.h new file mode 100644 index 000000000000..59d57d9c788c --- /dev/null +++ b/include/dt-bindings/clock/qcom,ipq9574-nsscc.h @@ -0,0 +1,152 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ +/* + * Copyright (c) 2023, The Linux Foundation. All rights reserved. + */ + +#ifndef _DT_BINDINGS_CLOCK_IPQ_NSSCC_9574_H +#define _DT_BINDINGS_CLOCK_IPQ_NSSCC_9574_H + +#define NSS_CC_CE_APB_CLK 0 +#define NSS_CC_CE_AXI_CLK 1 +#define NSS_CC_CE_CLK_SRC 2 +#define NSS_CC_CFG_CLK_SRC 3 +#define NSS_CC_CLC_AXI_CLK 4 +#define NSS_CC_CLC_CLK_SRC 5 +#define NSS_CC_CRYPTO_CLK 6 +#define NSS_CC_CRYPTO_CLK_SRC 7 +#define NSS_CC_CRYPTO_PPE_CLK 8 +#define NSS_CC_HAQ_AHB_CLK 9 +#define NSS_CC_HAQ_AXI_CLK 10 +#define NSS_CC_HAQ_CLK_SRC 11 +#define NSS_CC_IMEM_AHB_CLK 12 +#define NSS_CC_IMEM_CLK_SRC 13 +#define NSS_CC_IMEM_QSB_CLK 14 +#define NSS_CC_INT_CFG_CLK_SRC 15 +#define NSS_CC_NSS_CSR_CLK 16 +#define NSS_CC_NSSNOC_CE_APB_CLK 17 +#define NSS_CC_NSSNOC_CE_AXI_CLK 18 +#define NSS_CC_NSSNOC_CLC_AXI_CLK 19 +#define NSS_CC_NSSNOC_CRYPTO_CLK 20 +#define NSS_CC_NSSNOC_HAQ_AHB_CLK 21 +#define NSS_CC_NSSNOC_HAQ_AXI_CLK 22 +#define NSS_CC_NSSNOC_IMEM_AHB_CLK 23 +#define NSS_CC_NSSNOC_IMEM_QSB_CLK 24 +#define NSS_CC_NSSNOC_NSS_CSR_CLK 25 +#define NSS_CC_NSSNOC_PPE_CFG_CLK 26 +#define NSS_CC_NSSNOC_PPE_CLK 27 +#define NSS_CC_NSSNOC_UBI32_AHB0_CLK 28 +#define NSS_CC_NSSNOC_UBI32_AXI0_CLK 29 +#define NSS_CC_NSSNOC_UBI32_INT0_AHB_CLK 30 +#define NSS_CC_NSSNOC_UBI32_NC_AXI0_1_CLK 31 +#define NSS_CC_NSSNOC_UBI32_NC_AXI0_CLK 32 +#define NSS_CC_PORT1_MAC_CLK 33 +#define NSS_CC_PORT1_RX_CLK 34 +#define NSS_CC_PORT1_RX_CLK_SRC 35 +#define NSS_CC_PORT1_RX_DIV_CLK_SRC 36 +#define NSS_CC_PORT1_TX_CLK 37 +#define NSS_CC_PORT1_TX_CLK_SRC 38 +#define NSS_CC_PORT1_TX_DIV_CLK_SRC 39 +#define NSS_CC_PORT2_MAC_CLK 40 +#define NSS_CC_PORT2_RX_CLK 41 +#define NSS_CC_PORT2_RX_CLK_SRC 42 +#define NSS_CC_PORT2_RX_DIV_CLK_SRC 43 +#define NSS_CC_PORT2_TX_CLK 44 +#define NSS_CC_PORT2_TX_CLK_SRC 45 +#define NSS_CC_PORT2_TX_DIV_CLK_SRC 46 +#define NSS_CC_PORT3_MAC_CLK 47 +#define NSS_CC_PORT3_RX_CLK 48 +#define NSS_CC_PORT3_RX_CLK_SRC 49 +#define NSS_CC_PORT3_RX_DIV_CLK_SRC 50 +#define NSS_CC_PORT3_TX_CLK 51 +#define NSS_CC_PORT3_TX_CLK_SRC 52 +#define NSS_CC_PORT3_TX_DIV_CLK_SRC 53 +#define NSS_CC_PORT4_MAC_CLK 54 +#define NSS_CC_PORT4_RX_CLK 55 +#define NSS_CC_PORT4_RX_CLK_SRC 56 +#define NSS_CC_PORT4_RX_DIV_CLK_SRC 57 +#define NSS_CC_PORT4_TX_CLK 58 +#define NSS_CC_PORT4_TX_CLK_SRC 59 +#define NSS_CC_PORT4_TX_DIV_CLK_SRC 60 +#define NSS_CC_PORT5_MAC_CLK 61 +#define NSS_CC_PORT5_RX_CLK 62 +#define NSS_CC_PORT5_RX_CLK_SRC 63 +#define NSS_CC_PORT5_RX_DIV_CLK_SRC 64 +#define NSS_CC_PORT5_TX_CLK 65 +#define NSS_CC_PORT5_TX_CLK_SRC 66 +#define NSS_CC_PORT5_TX_DIV_CLK_SRC 67 +#define NSS_CC_PORT6_MAC_CLK 68 +#define NSS_CC_PORT6_RX_CLK 69 +#define NSS_CC_PORT6_RX_CLK_SRC 70 +#define NSS_CC_PORT6_RX_DIV_CLK_SRC 71 +#define NSS_CC_PORT6_TX_CLK 72 +#define NSS_CC_PORT6_TX_CLK_SRC 73 +#define NSS_CC_PORT6_TX_DIV_CLK_SRC 74 +#define NSS_CC_PPE_CLK_SRC 75 +#define NSS_CC_PPE_EDMA_CFG_CLK 76 +#define NSS_CC_PPE_EDMA_CLK 77 +#define NSS_CC_PPE_SWITCH_BTQ_CLK 78 +#define NSS_CC_PPE_SWITCH_CFG_CLK 79 +#define NSS_CC_PPE_SWITCH_CLK 80 +#define NSS_CC_PPE_SWITCH_IPE_CLK 81 +#define NSS_CC_UBI0_CLK_SRC 82 +#define NSS_CC_UBI0_DIV_CLK_SRC 83 +#define NSS_CC_UBI1_CLK_SRC 84 +#define NSS_CC_UBI1_DIV_CLK_SRC 85 +#define NSS_CC_UBI2_CLK_SRC 86 +#define NSS_CC_UBI2_DIV_CLK_SRC 87 +#define NSS_CC_UBI32_AHB0_CLK 88 +#define NSS_CC_UBI32_AHB1_CLK 89 +#define NSS_CC_UBI32_AHB2_CLK 90 +#define NSS_CC_UBI32_AHB3_CLK 91 +#define NSS_CC_UBI32_AXI0_CLK 92 +#define NSS_CC_UBI32_AXI1_CLK 93 +#define NSS_CC_UBI32_AXI2_CLK 94 +#define NSS_CC_UBI32_AXI3_CLK 95 +#define NSS_CC_UBI32_CORE0_CLK 96 +#define NSS_CC_UBI32_CORE1_CLK 97 +#define NSS_CC_UBI32_CORE2_CLK 98 +#define NSS_CC_UBI32_CORE3_CLK 99 +#define NSS_CC_UBI32_INTR0_AHB_CLK 100 +#define NSS_CC_UBI32_INTR1_AHB_CLK 101 +#define NSS_CC_UBI32_INTR2_AHB_CLK 102 +#define NSS_CC_UBI32_INTR3_AHB_CLK 103 +#define NSS_CC_UBI32_NC_AXI0_CLK 104 +#define NSS_CC_UBI32_NC_AXI1_CLK 105 +#define NSS_CC_UBI32_NC_AXI2_CLK 106 +#define NSS_CC_UBI32_NC_AXI3_CLK 107 +#define NSS_CC_UBI32_UTCM0_CLK 108 +#define NSS_CC_UBI32_UTCM1_CLK 109 +#define NSS_CC_UBI32_UTCM2_CLK 110 +#define NSS_CC_UBI32_UTCM3_CLK 111 +#define NSS_CC_UBI3_CLK_SRC 112 +#define NSS_CC_UBI3_DIV_CLK_SRC 113 +#define NSS_CC_UBI_AXI_CLK_SRC 114 +#define NSS_CC_UBI_NC_AXI_BFDCD_CLK_SRC 115 +#define NSS_CC_UNIPHY_PORT1_RX_CLK 116 +#define NSS_CC_UNIPHY_PORT1_TX_CLK 117 +#define NSS_CC_UNIPHY_PORT2_RX_CLK 118 +#define NSS_CC_UNIPHY_PORT2_TX_CLK 119 +#define NSS_CC_UNIPHY_PORT3_RX_CLK 120 +#define NSS_CC_UNIPHY_PORT3_TX_CLK 121 +#define NSS_CC_UNIPHY_PORT4_RX_CLK 122 +#define NSS_CC_UNIPHY_PORT4_TX_CLK 123 +#define NSS_CC_UNIPHY_PORT5_RX_CLK 124 +#define NSS_CC_UNIPHY_PORT5_TX_CLK 125 +#define NSS_CC_UNIPHY_PORT6_RX_CLK 126 +#define NSS_CC_UNIPHY_PORT6_TX_CLK 127 +#define NSS_CC_XGMAC0_PTP_REF_CLK 128 +#define NSS_CC_XGMAC0_PTP_REF_DIV_CLK_SRC 129 +#define NSS_CC_XGMAC1_PTP_REF_CLK 130 +#define NSS_CC_XGMAC1_PTP_REF_DIV_CLK_SRC 131 +#define NSS_CC_XGMAC2_PTP_REF_CLK 132 +#define NSS_CC_XGMAC2_PTP_REF_DIV_CLK_SRC 133 +#define NSS_CC_XGMAC3_PTP_REF_CLK 134 +#define NSS_CC_XGMAC3_PTP_REF_DIV_CLK_SRC 135 +#define NSS_CC_XGMAC4_PTP_REF_CLK 136 +#define NSS_CC_XGMAC4_PTP_REF_DIV_CLK_SRC 137 +#define NSS_CC_XGMAC5_PTP_REF_CLK 138 +#define NSS_CC_XGMAC5_PTP_REF_DIV_CLK_SRC 139 +#define UBI32_PLL 140 +#define UBI32_PLL_MAIN 141 + +#endif diff --git a/include/dt-bindings/reset/qcom,ipq9574-nsscc.h b/include/dt-bindings/reset/qcom,ipq9574-nsscc.h new file mode 100644 index 000000000000..6910db0cff51 --- /dev/null +++ b/include/dt-bindings/reset/qcom,ipq9574-nsscc.h @@ -0,0 +1,134 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ +/* + * Copyright (c) 2023, The Linux Foundation. All rights reserved. + */ + +#ifndef _DT_BINDINGS_RESET_IPQ_NSSCC_9574_H +#define _DT_BINDINGS_RESET_IPQ_NSSCC_9574_H + +#define EDMA_HW_RESET 0 +#define NSS_CC_CE_BCR 1 +#define NSS_CC_CLC_BCR 2 +#define NSS_CC_EIP197_BCR 3 +#define NSS_CC_HAQ_BCR 4 +#define NSS_CC_IMEM_BCR 5 +#define NSS_CC_MAC_BCR 6 +#define NSS_CC_PPE_BCR 7 +#define NSS_CC_UBI_BCR 8 +#define NSS_CC_UNIPHY_BCR 9 +#define UBI3_CLKRST_CLAMP_ENABLE 10 +#define UBI3_CORE_CLAMP_ENABLE 11 +#define UBI2_CLKRST_CLAMP_ENABLE 12 +#define UBI2_CORE_CLAMP_ENABLE 13 +#define UBI1_CLKRST_CLAMP_ENABLE 14 +#define UBI1_CORE_CLAMP_ENABLE 15 +#define UBI0_CLKRST_CLAMP_ENABLE 16 +#define UBI0_CORE_CLAMP_ENABLE 17 +#define NSSNOC_NSS_CSR_ARES 18 +#define NSS_CSR_ARES 19 +#define PPE_BTQ_ARES 20 +#define PPE_IPE_ARES 21 +#define PPE_ARES 22 +#define PPE_CFG_ARES 23 +#define PPE_EDMA_ARES 24 +#define PPE_EDMA_CFG_ARES 25 +#define CRY_PPE_ARES 26 +#define NSSNOC_PPE_ARES 27 +#define NSSNOC_PPE_CFG_ARES 28 +#define PORT1_MAC_ARES 29 +#define PORT2_MAC_ARES 30 +#define PORT3_MAC_ARES 31 +#define PORT4_MAC_ARES 32 +#define PORT5_MAC_ARES 33 +#define PORT6_MAC_ARES 34 +#define XGMAC0_PTP_REF_ARES 35 +#define XGMAC1_PTP_REF_ARES 36 +#define XGMAC2_PTP_REF_ARES 37 +#define XGMAC3_PTP_REF_ARES 38 +#define XGMAC4_PTP_REF_ARES 39 +#define XGMAC5_PTP_REF_ARES 40 +#define HAQ_AHB_ARES 41 +#define HAQ_AXI_ARES 42 +#define NSSNOC_HAQ_AHB_ARES 43 +#define NSSNOC_HAQ_AXI_ARES 44 +#define CE_APB_ARES 45 +#define CE_AXI_ARES 46 +#define NSSNOC_CE_APB_ARES 47 +#define NSSNOC_CE_AXI_ARES 48 +#define CRYPTO_ARES 49 +#define NSSNOC_CRYPTO_ARES 50 +#define NSSNOC_NC_AXI0_1_ARES 51 +#define UBI0_CORE_ARES 52 +#define UBI1_CORE_ARES 53 +#define UBI2_CORE_ARES 54 +#define UBI3_CORE_ARES 55 +#define NC_AXI0_ARES 56 +#define UTCM0_ARES 57 +#define NC_AXI1_ARES 58 +#define UTCM1_ARES 59 +#define NC_AXI2_ARES 60 +#define UTCM2_ARES 61 +#define NC_AXI3_ARES 62 +#define UTCM3_ARES 63 +#define NSSNOC_NC_AXI0_ARES 64 +#define AHB0_ARES 65 +#define INTR0_AHB_ARES 66 +#define AHB1_ARES 67 +#define INTR1_AHB_ARES 68 +#define AHB2_ARES 69 +#define INTR2_AHB_ARES 70 +#define AHB3_ARES 71 +#define INTR3_AHB_ARES 72 +#define NSSNOC_AHB0_ARES 73 +#define NSSNOC_INT0_AHB_ARES 74 +#define AXI0_ARES 75 +#define AXI1_ARES 76 +#define AXI2_ARES 77 +#define AXI3_ARES 78 +#define NSSNOC_AXI0_ARES 79 +#define IMEM_QSB_ARES 80 +#define NSSNOC_IMEM_QSB_ARES 81 +#define IMEM_AHB_ARES 82 +#define NSSNOC_IMEM_AHB_ARES 83 +#define UNIPHY_PORT1_RX_ARES 84 +#define UNIPHY_PORT1_TX_ARES 85 +#define UNIPHY_PORT2_RX_ARES 86 +#define UNIPHY_PORT2_TX_ARES 87 +#define UNIPHY_PORT3_RX_ARES 88 +#define UNIPHY_PORT3_TX_ARES 89 +#define UNIPHY_PORT4_RX_ARES 90 +#define UNIPHY_PORT4_TX_ARES 91 +#define UNIPHY_PORT5_RX_ARES 92 +#define UNIPHY_PORT5_TX_ARES 93 +#define UNIPHY_PORT6_RX_ARES 94 +#define UNIPHY_PORT6_TX_ARES 95 +#define PORT1_RX_ARES 96 +#define PORT1_TX_ARES 97 +#define PORT2_RX_ARES 98 +#define PORT2_TX_ARES 99 +#define PORT3_RX_ARES 100 +#define PORT3_TX_ARES 101 +#define PORT4_RX_ARES 102 +#define PORT4_TX_ARES 103 +#define PORT5_RX_ARES 104 +#define PORT5_TX_ARES 105 +#define PORT6_RX_ARES 106 +#define PORT6_TX_ARES 107 +#define PPE_FULL_RESET 108 +#define UNIPHY0_SOFT_RESET 109 +#define UNIPHY1_SOFT_RESET 110 +#define UNIPHY2_SOFT_RESET 111 +#define UNIPHY_PORT1_ARES 112 +#define UNIPHY_PORT2_ARES 113 +#define UNIPHY_PORT3_ARES 114 +#define UNIPHY_PORT4_ARES 115 +#define UNIPHY_PORT5_ARES 116 +#define UNIPHY_PORT6_ARES 117 +#define NSSPORT1_RESET 118 +#define NSSPORT2_RESET 119 +#define NSSPORT3_RESET 120 +#define NSSPORT4_RESET 121 +#define NSSPORT5_RESET 122 +#define NSSPORT6_RESET 123 + +#endif