| Message ID | 20240622-rk809-fixes-v2-1-c0db420d3639@collabora.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | DT fixes for Rockchip RK809 audio codec support | expand |
On Sat, Jun 22, 2024 at 12:57:18AM +0300, Cristian Ciocaltea wrote: > Ensure 'clocks' property does not allow more than one item and add the > missing reference to dai-common schema. > > While at it, move 'clocks*' and '#sound-dai-cells' properties to keep > the list ordered alphabetically. > > Additionally, drop all useless/redundant descriptions. > > Fixes: 6c38ca03406e ("dt-bindings: mfd: rk808: Convert bindings to yaml") > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> I'd argue that these should not all be the same commit, but w/e. Acked-by: Conor Dooley <conor.dooley@microchip.com>
On Sat, 22 Jun 2024, Conor Dooley wrote: > On Sat, Jun 22, 2024 at 12:57:18AM +0300, Cristian Ciocaltea wrote: > > Ensure 'clocks' property does not allow more than one item and add the > > missing reference to dai-common schema. > > > > While at it, move 'clocks*' and '#sound-dai-cells' properties to keep > > the list ordered alphabetically. > > > > Additionally, drop all useless/redundant descriptions. > > > > Fixes: 6c38ca03406e ("dt-bindings: mfd: rk808: Convert bindings to yaml") > > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> > > I'd argue that these should not all be the same commit, but w/e. Are you arguing that, or not? :) > Acked-by: Conor Dooley <conor.dooley@microchip.com>
On Wed, Jun 26, 2024 at 04:44:46PM +0100, Lee Jones wrote: > On Sat, 22 Jun 2024, Conor Dooley wrote: > > > On Sat, Jun 22, 2024 at 12:57:18AM +0300, Cristian Ciocaltea wrote: > > > Ensure 'clocks' property does not allow more than one item and add the > > > missing reference to dai-common schema. > > > > > > While at it, move 'clocks*' and '#sound-dai-cells' properties to keep > > > the list ordered alphabetically. > > > > > > Additionally, drop all useless/redundant descriptions. > > > > > > Fixes: 6c38ca03406e ("dt-bindings: mfd: rk808: Convert bindings to yaml") > > > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> > > > > I'd argue that these should not all be the same commit, but w/e. > > Are you arguing that, or not? :) I said w/e and acked it, you can apply it! > > > Acked-by: Conor Dooley <conor.dooley@microchip.com>
diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml index 8c2fd0fabb92..d70b4307ac77 100644 --- a/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml @@ -32,6 +32,13 @@ properties: minimum: 0 maximum: 1 + clocks: + maxItems: 1 + + clock-names: + items: + - const: mclk + clock-output-names: description: From common clock binding to override the default output clock name. @@ -42,6 +49,9 @@ properties: description: Telling whether or not this PMIC is controlling the system power. + '#sound-dai-cells': + const: 0 + system-power-controller: true wakeup-source: @@ -94,26 +104,7 @@ properties: $ref: /schemas/regulator/regulator.yaml# unevaluatedProperties: false - clocks: - description: - The input clock for the audio codec. - - clock-names: - description: - The clock name for the codec clock. - items: - - const: mclk - - '#sound-dai-cells': - description: - Needed for the interpretation of sound dais. - const: 0 - codec: - description: | - The child node for the codec to hold additional properties. If no - additional properties are required for the codec, this node can be - omitted. type: object additionalProperties: false properties: @@ -123,9 +114,6 @@ properties: Describes if the microphone uses differential mode. charger: - description: | - The child node for the charger to hold additional properties. If a - battery is not in use, this node can be omitted. type: object $ref: /schemas/power/supply/power-supply.yaml @@ -168,6 +156,7 @@ properties: additionalProperties: false allOf: + - $ref: /schemas/sound/dai-common.yaml# - if: properties: '#clock-cells':
Ensure 'clocks' property does not allow more than one item and add the missing reference to dai-common schema. While at it, move 'clocks*' and '#sound-dai-cells' properties to keep the list ordered alphabetically. Additionally, drop all useless/redundant descriptions. Fixes: 6c38ca03406e ("dt-bindings: mfd: rk808: Convert bindings to yaml") Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> --- .../devicetree/bindings/mfd/rockchip,rk817.yaml | 33 ++++++++-------------- 1 file changed, 11 insertions(+), 22 deletions(-)