| Message ID | 20240630034649.173229-1-marex@denx.de (mailing list archive) |
|---|---|
| State | Under Review |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | [1/2] ARM: dts: renesas: Drop ethernet-phy-ieee802.3-c22 from PHY compatible string on all RZ boards | expand |
On Sun, Jun 30, 2024 at 05:46:17AM +0200, Marek Vasut wrote: > The rtl82xx DT bindings do not require ethernet-phy-ieee802.3-c22 > as the fallback compatible string. There are fewer users of the > Realtek PHY compatible string with fallback compatible string than > there are users without fallback compatible string, so drop the > fallback compatible string from the few remaining users: > > $ git grep -ho ethernet-phy-id001c....... | sort | uniq -c > 1 ethernet-phy-id001c.c816", > 2 ethernet-phy-id001c.c915", > 2 ethernet-phy-id001c.c915"; > 5 ethernet-phy-id001c.c916", > 13 ethernet-phy-id001c.c916"; > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202406290316.YvZdvLxu-lkp@intel.com/ > Signed-off-by: Marek Vasut <marex@denx.de> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
Hi Marek, Thanks for your patch! On Sun, Jun 30, 2024 at 5:47 AM Marek Vasut <marex@denx.de> wrote: > The rtl82xx DT bindings do not require ethernet-phy-ieee802.3-c22 > as the fallback compatible string. There are fewer users of the Why not? > Realtek PHY compatible string with fallback compatible string than > there are users without fallback compatible string, so drop the > fallback compatible string from the few remaining users: Ah, the self-fulfilling collection of patches ;-) Let's move the discussion to the actual patch that causes this https://lore.kernel.org/all/20240625184359.153423-1-marex@denx.de/ > $ git grep -ho ethernet-phy-id001c....... | sort | uniq -c > 1 ethernet-phy-id001c.c816", > 2 ethernet-phy-id001c.c915", > 2 ethernet-phy-id001c.c915"; > 5 ethernet-phy-id001c.c916", > 13 ethernet-phy-id001c.c916"; > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202406290316.YvZdvLxu-lkp@intel.com/ Hmm, nothing about r7s9210-rza2mevb in that report. > Signed-off-by: Marek Vasut <marex@denx.de> > --- > Cc: Conor Dooley <conor+dt@kernel.org> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: Khuong Dinh <khuong@os.amperecomputing.com> > Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> > Cc: Magnus Damm <magnus.damm@gmail.com> > Cc: Rob Herring <robh@kernel.org> > Cc: devicetree@vger.kernel.org > Cc: linux-renesas-soc@vger.kernel.org > --- > Note: this closes only part of the report Please do not use the "Closes" tag if it does not fix everything in the report. "Link" (pointing to the correct report!) is fine, though. > --- a/arch/arm/boot/dts/renesas/r7s9210-rza2mevb.dts > +++ b/arch/arm/boot/dts/renesas/r7s9210-rza2mevb.dts > @@ -95,8 +95,7 @@ ðer1 { > renesas,no-ether-link; > phy-handle = <&phy1>; > phy1: ethernet-phy@1 { > - compatible = "ethernet-phy-id001c.c816", > - "ethernet-phy-ieee802.3-c22"; > + compatible = "ethernet-phy-id001c.c816"; > reg = <0>; > }; > }; Gr{oetje,eeting}s, Geert
diff --git a/arch/arm/boot/dts/renesas/r7s9210-rza2mevb.dts b/arch/arm/boot/dts/renesas/r7s9210-rza2mevb.dts index cd2324b8e8ffb..41b1dbcfba100 100644 --- a/arch/arm/boot/dts/renesas/r7s9210-rza2mevb.dts +++ b/arch/arm/boot/dts/renesas/r7s9210-rza2mevb.dts @@ -95,8 +95,7 @@ ðer1 { renesas,no-ether-link; phy-handle = <&phy1>; phy1: ethernet-phy@1 { - compatible = "ethernet-phy-id001c.c816", - "ethernet-phy-ieee802.3-c22"; + compatible = "ethernet-phy-id001c.c816"; reg = <0>; }; };
The rtl82xx DT bindings do not require ethernet-phy-ieee802.3-c22 as the fallback compatible string. There are fewer users of the Realtek PHY compatible string with fallback compatible string than there are users without fallback compatible string, so drop the fallback compatible string from the few remaining users: $ git grep -ho ethernet-phy-id001c....... | sort | uniq -c 1 ethernet-phy-id001c.c816", 2 ethernet-phy-id001c.c915", 2 ethernet-phy-id001c.c915"; 5 ethernet-phy-id001c.c916", 13 ethernet-phy-id001c.c916"; Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202406290316.YvZdvLxu-lkp@intel.com/ Signed-off-by: Marek Vasut <marex@denx.de> --- Cc: Conor Dooley <conor+dt@kernel.org> Cc: Geert Uytterhoeven <geert+renesas@glider.be> Cc: Khuong Dinh <khuong@os.amperecomputing.com> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> Cc: Magnus Damm <magnus.damm@gmail.com> Cc: Rob Herring <robh@kernel.org> Cc: devicetree@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org --- Note: this closes only part of the report --- arch/arm/boot/dts/renesas/r7s9210-rza2mevb.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)