mbox series

[0/4] Drop ifdef for macOS versions older than 12.0

Message ID 20240629-macos-v1-0-6e70a6b700a0@daynix.com (mailing list archive)
Headers show
Series Drop ifdef for macOS versions older than 12.0 | expand

Message

Akihiko Odaki June 29, 2024, 6:24 a.m. UTC
macOS versions older than 12.0 are no longer supported.

docs/about/build-platforms.rst says:
> Support for the previous major version will be dropped 2 years after
> the new major version is released or when the vendor itself drops
> support, whichever comes first.

macOS 12.0 was released 2021:
https://www.apple.com/newsroom/2021/10/macos-monterey-is-now-available/

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
Akihiko Odaki (4):
      hvf: Drop ifdef for macOS versions older than 12.0
      audio: Drop ifdef for macOS versions older than 12.0
      block/file-posix: Drop ifdef for macOS versions older than 12.0
      net/vmnet: Drop ifdef for macOS versions older than 12.0

 accel/hvf/hvf-all.c   |  3 ---
 block/file-posix.c    |  5 -----
 net/vmnet-host.c      | 24 +-----------------------
 net/vmnet-shared.c    | 13 -------------
 target/i386/hvf/hvf.c | 23 +----------------------
 audio/coreaudio.m     |  5 -----
 net/vmnet-bridged.m   | 13 +------------
 net/vmnet-common.m    |  3 ---
 8 files changed, 3 insertions(+), 86 deletions(-)
---
base-commit: 046a64b9801343e2e89eef10c7a48eec8d8c0d4f
change-id: 20240628-macos-d194d420f01a

Best regards,

Comments

Peter Maydell July 1, 2024, 11:43 a.m. UTC | #1
On Sat, 29 Jun 2024 at 07:26, Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
>
> macOS versions older than 12.0 are no longer supported.
>
> docs/about/build-platforms.rst says:
> > Support for the previous major version will be dropped 2 years after
> > the new major version is released or when the vendor itself drops
> > support, whichever comes first.
>
> macOS 12.0 was released 2021:
> https://www.apple.com/newsroom/2021/10/macos-monterey-is-now-available/


Further, we have already dropped support for macos < 12
in the ui/cocoa.m code in commit 2d27c91e2b72ac.

For the whole series:
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>

PS: you don't need to put a signed-off-by line on the cover
letter, only in the individual patches.

thanks
-- PMM
Akihiko Odaki July 1, 2024, noon UTC | #2
On 2024/07/01 20:43, Peter Maydell wrote:
> On Sat, 29 Jun 2024 at 07:26, Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
>>
>> macOS versions older than 12.0 are no longer supported.
>>
>> docs/about/build-platforms.rst says:
>>> Support for the previous major version will be dropped 2 years after
>>> the new major version is released or when the vendor itself drops
>>> support, whichever comes first.
>>
>> macOS 12.0 was released 2021:
>> https://www.apple.com/newsroom/2021/10/macos-monterey-is-now-available/
> 
> 
> Further, we have already dropped support for macos < 12
> in the ui/cocoa.m code in commit 2d27c91e2b72ac.
> 
> For the whole series:
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> 
>> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> 
> PS: you don't need to put a signed-off-by line on the cover
> letter, only in the individual patches.

I have been using b4 (https://b4.docs.kernel.org/en/latest/) these days 
and it automatically appends Signed-off-by to the cover letter.

Regards,
Akihiko Odaki
Konstantin Ryabitsev July 1, 2024, 3:07 p.m. UTC | #3
On Mon, Jul 01, 2024 at 09:00:48PM GMT, Akihiko Odaki wrote:
> > > Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> > 
> > PS: you don't need to put a signed-off-by line on the cover
> > letter, only in the individual patches.
> 
> I have been using b4 (https://b4.docs.kernel.org/en/latest/) these days and
> it automatically appends Signed-off-by to the cover letter.

Many subsystems use cover letters as templates for merge commits, which is why
b4 puts the Signed-off-by there. It has no impact on subsystems that don't do
that.

-K
Peter Maydell July 1, 2024, 3:11 p.m. UTC | #4
On Mon, 1 Jul 2024 at 16:07, Konstantin Ryabitsev
<konstantin@linuxfoundation.org> wrote:
>
> On Mon, Jul 01, 2024 at 09:00:48PM GMT, Akihiko Odaki wrote:
> > > > Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> > >
> > > PS: you don't need to put a signed-off-by line on the cover
> > > letter, only in the individual patches.
> >
> > I have been using b4 (https://b4.docs.kernel.org/en/latest/) these days and
> > it automatically appends Signed-off-by to the cover letter.
>
> Many subsystems use cover letters as templates for merge commits, which is why
> b4 puts the Signed-off-by there. It has no impact on subsystems that don't do
> that.

...well, except that it sends the implicit signal "this person
or tool doesn't know how QEMU's patch workflow works, maybe
check more closely", which is slightly unfortunate.

-- PMM
Philippe Mathieu-Daudé July 1, 2024, 3:39 p.m. UTC | #5
On 29/6/24 08:24, Akihiko Odaki wrote:
> macOS versions older than 12.0 are no longer supported.

> Akihiko Odaki (4):
>        hvf: Drop ifdef for macOS versions older than 12.0
>        audio: Drop ifdef for macOS versions older than 12.0
>        block/file-posix: Drop ifdef for macOS versions older than 12.0
>        net/vmnet: Drop ifdef for macOS versions older than 12.0

Series queued, thanks!