| Message ID | 20240701070454.106083-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/4] drm/amd/display: Fix warning comparing pointer to 0 | expand |
Applied the series. Thanks! Alex On Mon, Jul 1, 2024 at 3:15 AM Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote: > > Avoid pointer type value compared with 0 to make code clear. > > ./drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_factory.c:14:12-13: WARNING comparing pointer to 0. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9458 > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > .../amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_factory.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_factory.c b/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_factory.c > index 1a0da8c6df5a..f56abe9ab919 100644 > --- a/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_factory.c > +++ b/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_factory.c > @@ -11,7 +11,7 @@ bool dml2_core_create(enum dml2_project_id project_id, struct dml2_core_instance > { > bool result = false; > > - if (out == 0) > + if (!out) > return false; > > memset(out, 0, sizeof(struct dml2_core_instance)); > -- > 2.20.1.7.g153144c >
diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_factory.c b/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_factory.c index 1a0da8c6df5a..f56abe9ab919 100644 --- a/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_factory.c +++ b/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_factory.c @@ -11,7 +11,7 @@ bool dml2_core_create(enum dml2_project_id project_id, struct dml2_core_instance { bool result = false; - if (out == 0) + if (!out) return false; memset(out, 0, sizeof(struct dml2_core_instance));
Avoid pointer type value compared with 0 to make code clear. ./drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_factory.c:14:12-13: WARNING comparing pointer to 0. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9458 Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- .../amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_factory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)