Message ID | 20240629171100.20285-1-marex@denx.de (mailing list archive) |
---|---|
State | New |
Headers | show |
Series | ARM: dts: stm32: Add ethernet MAC nvmem cells to DH STM32MP13xx DHCOR DHSBC board | expand |
On Sat, 29 Jun 2024 19:10:30 +0200, Marek Vasut wrote: > Describe ethernet MAC address nvmem cells in DH STM32MP13xx DHCOR DHSBC > board DT. The MAC address can be fused in BSEC OTP fuses and used to set > up MAC address for both ethernet MACs on this board. > > Signed-off-by: Marek Vasut <marex@denx.de> > --- > Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> > Cc: Christophe Roullier <christophe.roullier@foss.st.com> > Cc: Conor Dooley <conor+dt@kernel.org> > Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> > Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> > Cc: Rob Herring <robh@kernel.org> > Cc: devicetree@vger.kernel.org > Cc: kernel@dh-electronics.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-stm32@st-md-mailman.stormreply.com > --- > arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dts | 4 ++++ > 1 file changed, 4 insertions(+) > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y st/stm32mp135f-dhcor-dhsbc.dtb' for 20240629171100.20285-1-marex@denx.de: arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dtb: ethernet@5800a000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts-extended', 'mdio', 'nvmem-cell-names', 'nvmem-cells', 'phy-handle', 'phy-mode', 'snps,axi-config', 'snps,mixed-burst', 'snps,pbl', 'snps,tso', 'stmmac-axi-config' were unexpected) from schema $id: http://devicetree.org/schemas/net/stm32-dwmac.yaml# arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dtb: ethernet@5800e000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts-extended', 'mdio', 'nvmem-cell-names', 'nvmem-cells', 'phy-handle', 'phy-mode', 'snps,axi-config', 'snps,mixed-burst', 'snps,pbl', 'snps,tso', 'stmmac-axi-config' were unexpected) from schema $id: http://devicetree.org/schemas/net/stm32-dwmac.yaml#
On 7/1/24 8:10 PM, Rob Herring (Arm) wrote: > > On Sat, 29 Jun 2024 19:10:30 +0200, Marek Vasut wrote: >> Describe ethernet MAC address nvmem cells in DH STM32MP13xx DHCOR DHSBC >> board DT. The MAC address can be fused in BSEC OTP fuses and used to set >> up MAC address for both ethernet MACs on this board. >> >> Signed-off-by: Marek Vasut <marex@denx.de> >> --- >> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> >> Cc: Christophe Roullier <christophe.roullier@foss.st.com> >> Cc: Conor Dooley <conor+dt@kernel.org> >> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> >> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> >> Cc: Rob Herring <robh@kernel.org> >> Cc: devicetree@vger.kernel.org >> Cc: kernel@dh-electronics.com >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-stm32@st-md-mailman.stormreply.com >> --- >> arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dts | 4 ++++ >> 1 file changed, 4 insertions(+) >> > > > My bot found new DTB warnings on the .dts files added or changed in this > series. > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. > > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: > > pip3 install dtschema --upgrade > > > New warnings running 'make CHECK_DTBS=y st/stm32mp135f-dhcor-dhsbc.dtb' for 20240629171100.20285-1-marex@denx.de: > > arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dtb: ethernet@5800a000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts-extended', 'mdio', 'nvmem-cell-names', 'nvmem-cells', 'phy-handle', 'phy-mode', 'snps,axi-config', 'snps,mixed-burst', 'snps,pbl', 'snps,tso', 'stmmac-axi-config' were unexpected) > from schema $id: http://devicetree.org/schemas/net/stm32-dwmac.yaml# > arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dtb: ethernet@5800e000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts-extended', 'mdio', 'nvmem-cell-names', 'nvmem-cells', 'phy-handle', 'phy-mode', 'snps,axi-config', 'snps,mixed-burst', 'snps,pbl', 'snps,tso', 'stmmac-axi-config' were unexpected) > from schema $id: http://devicetree.org/schemas/net/stm32-dwmac.yaml# I can't seem to be able to reproduce it locally , even with dtschema/master updated right now . Looking at the bindings, net/stm32-dwmac.yaml does have allof-ref to snps,dwmac.yaml which has allof-ref to ethernet-controller.yaml , which does list the nvmem-cells/nvmem-cell-names properties . What am I missing here ?
Hi Marek, Rob On 7/2/24 04:43, Marek Vasut wrote: > On 7/1/24 8:10 PM, Rob Herring (Arm) wrote: >> >> On Sat, 29 Jun 2024 19:10:30 +0200, Marek Vasut wrote: >>> Describe ethernet MAC address nvmem cells in DH STM32MP13xx DHCOR DHSBC >>> board DT. The MAC address can be fused in BSEC OTP fuses and used to set >>> up MAC address for both ethernet MACs on this board. >>> >>> Signed-off-by: Marek Vasut <marex@denx.de> >>> --- >>> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> >>> Cc: Christophe Roullier <christophe.roullier@foss.st.com> >>> Cc: Conor Dooley <conor+dt@kernel.org> >>> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> >>> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> >>> Cc: Rob Herring <robh@kernel.org> >>> Cc: devicetree@vger.kernel.org >>> Cc: kernel@dh-electronics.com >>> Cc: linux-arm-kernel@lists.infradead.org >>> Cc: linux-stm32@st-md-mailman.stormreply.com >>> --- >>> arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dts | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >> >> >> My bot found new DTB warnings on the .dts files added or changed in this >> series. >> >> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings >> are fixed by another series. Ultimately, it is up to the platform >> maintainer whether these warnings are acceptable or not. No need to reply >> unless the platform maintainer has comments. >> >> If you already ran DT checks and didn't see these error(s), then >> make sure dt-schema is up to date: >> >> pip3 install dtschema --upgrade >> >> >> New warnings running 'make CHECK_DTBS=y >> st/stm32mp135f-dhcor-dhsbc.dtb' for 20240629171100.20285-1-marex@denx.de: >> >> arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dtb: ethernet@5800a000: >> Unevaluated properties are not allowed ('interrupt-names', >> 'interrupts-extended', 'mdio', 'nvmem-cell-names', 'nvmem-cells', >> 'phy-handle', 'phy-mode', 'snps,axi-config', 'snps,mixed-burst', >> 'snps,pbl', 'snps,tso', 'stmmac-axi-config' were unexpected) >> from schema $id: http://devicetree.org/schemas/net/stm32-dwmac.yaml# >> arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dtb: ethernet@5800e000: >> Unevaluated properties are not allowed ('interrupt-names', >> 'interrupts-extended', 'mdio', 'nvmem-cell-names', 'nvmem-cells', >> 'phy-handle', 'phy-mode', 'snps,axi-config', 'snps,mixed-burst', >> 'snps,pbl', 'snps,tso', 'stmmac-axi-config' were unexpected) >> from schema $id: http://devicetree.org/schemas/net/stm32-dwmac.yaml# > > I can't seem to be able to reproduce it locally , even with > dtschema/master updated right now . > > Looking at the bindings, net/stm32-dwmac.yaml does have allof-ref to > snps,dwmac.yaml which has allof-ref to ethernet-controller.yaml , which > does list the nvmem-cells/nvmem-cell-names properties . > > What am I missing here ? I'm also not able to reproduce this issue even after updated the schemas. Rob, can you please double check on your side ? Marek, I think I'll take this patch later for v6.12 cycle. regards Alex
On 7/5/24 9:30 AM, Alexandre TORGUE wrote: Hi, >>> arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dtb: ethernet@5800a000: >>> Unevaluated properties are not allowed ('interrupt-names', >>> 'interrupts-extended', 'mdio', 'nvmem-cell-names', 'nvmem-cells', >>> 'phy-handle', 'phy-mode', 'snps,axi-config', 'snps,mixed-burst', >>> 'snps,pbl', 'snps,tso', 'stmmac-axi-config' were unexpected) >>> from schema $id: http://devicetree.org/schemas/net/stm32-dwmac.yaml# >>> arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dtb: ethernet@5800e000: >>> Unevaluated properties are not allowed ('interrupt-names', >>> 'interrupts-extended', 'mdio', 'nvmem-cell-names', 'nvmem-cells', >>> 'phy-handle', 'phy-mode', 'snps,axi-config', 'snps,mixed-burst', >>> 'snps,pbl', 'snps,tso', 'stmmac-axi-config' were unexpected) >>> from schema $id: http://devicetree.org/schemas/net/stm32-dwmac.yaml# >> >> I can't seem to be able to reproduce it locally , even with >> dtschema/master updated right now . >> >> Looking at the bindings, net/stm32-dwmac.yaml does have allof-ref to >> snps,dwmac.yaml which has allof-ref to ethernet-controller.yaml , >> which does list the nvmem-cells/nvmem-cell-names properties . >> >> What am I missing here ? > > I'm also not able to reproduce this issue even after updated the schemas. > Rob, can you please double check on your side ? > Marek, I think I'll take this patch later for v6.12 cycle. That's just fine, no worries.
diff --git a/arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dts b/arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dts index bacb70b4256bc..3cc9ad88d61bc 100644 --- a/arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dts +++ b/arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dts @@ -75,6 +75,8 @@ channel@12 { }; ðernet1 { + nvmem-cell-names = "mac-address"; + nvmem-cells = <ðernet_mac1_address>; phy-handle = <ðphy1>; phy-mode = "rgmii-id"; pinctrl-0 = <ð1_rgmii_pins_a>; @@ -102,6 +104,8 @@ ethphy1: ethernet-phy@1 { }; ðernet2 { + nvmem-cell-names = "mac-address"; + nvmem-cells = <ðernet_mac2_address>; phy-handle = <ðphy2>; phy-mode = "rgmii-id"; pinctrl-0 = <ð2_rgmii_pins_a>;
Describe ethernet MAC address nvmem cells in DH STM32MP13xx DHCOR DHSBC board DT. The MAC address can be fused in BSEC OTP fuses and used to set up MAC address for both ethernet MACs on this board. Signed-off-by: Marek Vasut <marex@denx.de> --- Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> Cc: Christophe Roullier <christophe.roullier@foss.st.com> Cc: Conor Dooley <conor+dt@kernel.org> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> Cc: Rob Herring <robh@kernel.org> Cc: devicetree@vger.kernel.org Cc: kernel@dh-electronics.com Cc: linux-arm-kernel@lists.infradead.org Cc: linux-stm32@st-md-mailman.stormreply.com --- arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dts | 4 ++++ 1 file changed, 4 insertions(+)