| Message ID | 20240701062304.42844-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/stm: Remove unnecessary .owner for lvds_platform_driver | expand |
Hi Jiapeng, On 7/1/24 08:23, Jiapeng Chong wrote: > Remove .owner field if calls are used which set it automatically. > > ./drivers/gpu/drm/stm/lvds.c:1213:3-8: No need to set .owner here. The core will do it. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9457 > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > drivers/gpu/drm/stm/lvds.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/stm/lvds.c b/drivers/gpu/drm/stm/lvds.c > index 2fa2c81784e9..06f2d7a56cc9 100644 > --- a/drivers/gpu/drm/stm/lvds.c > +++ b/drivers/gpu/drm/stm/lvds.c > @@ -1210,7 +1210,6 @@ static struct platform_driver lvds_platform_driver = { > .remove = lvds_remove, > .driver = { > .name = "stm32-display-lvds", > - .owner = THIS_MODULE, > .of_match_table = lvds_dt_ids, > }, > }; Indeed, platform_driver_register() overrides the value of the owner. Acked-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com> Thanks, Raphaël
On 7/1/24 08:23, Jiapeng Chong wrote: > Remove .owner field if calls are used which set it automatically. > > ./drivers/gpu/drm/stm/lvds.c:1213:3-8: No need to set .owner here. The core will do it. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9457 > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > drivers/gpu/drm/stm/lvds.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/stm/lvds.c b/drivers/gpu/drm/stm/lvds.c > index 2fa2c81784e9..06f2d7a56cc9 100644 > --- a/drivers/gpu/drm/stm/lvds.c > +++ b/drivers/gpu/drm/stm/lvds.c > @@ -1210,7 +1210,6 @@ static struct platform_driver lvds_platform_driver = { > .remove = lvds_remove, > .driver = { > .name = "stm32-display-lvds", > - .owner = THIS_MODULE, > .of_match_table = lvds_dt_ids, > }, > }; Hi Jiapeng, Applied on drm-misc-next. Many thanks, Philippe :-)
diff --git a/drivers/gpu/drm/stm/lvds.c b/drivers/gpu/drm/stm/lvds.c index 2fa2c81784e9..06f2d7a56cc9 100644 --- a/drivers/gpu/drm/stm/lvds.c +++ b/drivers/gpu/drm/stm/lvds.c @@ -1210,7 +1210,6 @@ static struct platform_driver lvds_platform_driver = { .remove = lvds_remove, .driver = { .name = "stm32-display-lvds", - .owner = THIS_MODULE, .of_match_table = lvds_dt_ids, }, };
Remove .owner field if calls are used which set it automatically. ./drivers/gpu/drm/stm/lvds.c:1213:3-8: No need to set .owner here. The core will do it. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9457 Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/gpu/drm/stm/lvds.c | 1 - 1 file changed, 1 deletion(-)