| Message ID | 20240701195607.228852-1-thorsten.blum@toblux.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RESEND] drm/managed: Simplify if condition | expand |
On Mon, Jul 01, 2024 at 09:56:08PM GMT, Thorsten Blum wrote: > The if condition !A || A && B can be simplified to !A || B. > > Fixes the following Coccinelle/coccicheck warning reported by > excluded_middle.cocci: > > WARNING !A || A && B is equivalent to !A || B > > Compile-tested only. > > Acked-by: Thomas Zimmermann <tzimmermann@suse.de> > Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com> > --- > drivers/gpu/drm/drm_managed.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Merged into drm-misc-next Am 01.07.24 um 21:56 schrieb Thorsten Blum: > The if condition !A || A && B can be simplified to !A || B. > > Fixes the following Coccinelle/coccicheck warning reported by > excluded_middle.cocci: > > WARNING !A || A && B is equivalent to !A || B > > Compile-tested only. > > Acked-by: Thomas Zimmermann <tzimmermann@suse.de> > Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com> > --- > drivers/gpu/drm/drm_managed.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_managed.c b/drivers/gpu/drm/drm_managed.c > index 7646f67bda4e..79ce86a5bd67 100644 > --- a/drivers/gpu/drm/drm_managed.c > +++ b/drivers/gpu/drm/drm_managed.c > @@ -197,7 +197,7 @@ void drmm_release_action(struct drm_device *dev, > spin_lock_irqsave(&dev->managed.lock, flags); > list_for_each_entry_reverse(dr, &dev->managed.resources, node.entry) { > if (dr->node.release == action) { > - if (!data || (data && *(void **)dr->data == data)) { > + if (!data || *(void **)dr->data == data) { > dr_match = dr; > del_dr(dev, dr_match); > break;
diff --git a/drivers/gpu/drm/drm_managed.c b/drivers/gpu/drm/drm_managed.c index 7646f67bda4e..79ce86a5bd67 100644 --- a/drivers/gpu/drm/drm_managed.c +++ b/drivers/gpu/drm/drm_managed.c @@ -197,7 +197,7 @@ void drmm_release_action(struct drm_device *dev, spin_lock_irqsave(&dev->managed.lock, flags); list_for_each_entry_reverse(dr, &dev->managed.resources, node.entry) { if (dr->node.release == action) { - if (!data || (data && *(void **)dr->data == data)) { + if (!data || *(void **)dr->data == data) { dr_match = dr; del_dr(dev, dr_match); break;