| Message ID | 20240702121737.522878-1-thuth@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/fbdev-dma: Fix framebuffer mode for big endian devices | expand |
Hi Am 02.07.24 um 14:17 schrieb Thomas Huth: > The drm_mode_legacy_fb_format() function only generates formats suitable > for little endian devices. switch to drm_driver_legacy_fb_format() here > instead to take the device endianness into consideration, too. > > Suggested-by: Thomas Zimmermann <tzimmermann@suse.de> > Signed-off-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> Thank you for taking the time to make the patch for fbdev-dma. I'll take care of merging both patches into the correct branches. Best regards Thomas > --- > Note: Patch has only been compile-tested since I lack an environment > for testing it. But it's the same fix as I required for the > drm_mode_legacy_fb_format() in drm_fbdev_generic.c / drm_fbdev_ttm.c > so I think this should be fine. > > drivers/gpu/drm/drm_fbdev_dma.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_fbdev_dma.c b/drivers/gpu/drm/drm_fbdev_dma.c > index 97ef6300d47e..fdef4a2f883f 100644 > --- a/drivers/gpu/drm/drm_fbdev_dma.c > +++ b/drivers/gpu/drm/drm_fbdev_dma.c > @@ -101,7 +101,8 @@ static int drm_fbdev_dma_helper_fb_probe(struct drm_fb_helper *fb_helper, > sizes->surface_width, sizes->surface_height, > sizes->surface_bpp); > > - format = drm_mode_legacy_fb_format(sizes->surface_bpp, sizes->surface_depth); > + format = drm_driver_legacy_fb_format(dev, sizes->surface_bpp, > + sizes->surface_depth); > buffer = drm_client_framebuffer_create(client, sizes->surface_width, > sizes->surface_height, format); > if (IS_ERR(buffer))
Thomas Huth <thuth@redhat.com> writes: Hello Thomas, > The drm_mode_legacy_fb_format() function only generates formats suitable > for little endian devices. switch to drm_driver_legacy_fb_format() here > instead to take the device endianness into consideration, too. > > Suggested-by: Thomas Zimmermann <tzimmermann@suse.de> > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > Note: Patch has only been compile-tested since I lack an environment > for testing it. But it's the same fix as I required for the > drm_mode_legacy_fb_format() in drm_fbdev_generic.c / drm_fbdev_ttm.c > so I think this should be fine. > > drivers/gpu/drm/drm_fbdev_dma.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_fbdev_dma.c b/drivers/gpu/drm/drm_fbdev_dma.c > index 97ef6300d47e..fdef4a2f883f 100644 > --- a/drivers/gpu/drm/drm_fbdev_dma.c > +++ b/drivers/gpu/drm/drm_fbdev_dma.c > @@ -101,7 +101,8 @@ static int drm_fbdev_dma_helper_fb_probe(struct drm_fb_helper *fb_helper, > sizes->surface_width, sizes->surface_height, > sizes->surface_bpp); > > - format = drm_mode_legacy_fb_format(sizes->surface_bpp, sizes->surface_depth); > + format = drm_driver_legacy_fb_format(dev, sizes->surface_bpp, > + sizes->surface_depth); > buffer = drm_client_framebuffer_create(client, sizes->surface_width, > sizes->surface_height, format); > if (IS_ERR(buffer)) Makes sense to me. Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Hi, I've added a Fixes tag and merged the patch into drm-misc-next-fixes. Best regards Thomas Am 02.07.24 um 14:17 schrieb Thomas Huth: > The drm_mode_legacy_fb_format() function only generates formats suitable > for little endian devices. switch to drm_driver_legacy_fb_format() here > instead to take the device endianness into consideration, too. > > Suggested-by: Thomas Zimmermann <tzimmermann@suse.de> > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > Note: Patch has only been compile-tested since I lack an environment > for testing it. But it's the same fix as I required for the > drm_mode_legacy_fb_format() in drm_fbdev_generic.c / drm_fbdev_ttm.c > so I think this should be fine. > > drivers/gpu/drm/drm_fbdev_dma.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_fbdev_dma.c b/drivers/gpu/drm/drm_fbdev_dma.c > index 97ef6300d47e..fdef4a2f883f 100644 > --- a/drivers/gpu/drm/drm_fbdev_dma.c > +++ b/drivers/gpu/drm/drm_fbdev_dma.c > @@ -101,7 +101,8 @@ static int drm_fbdev_dma_helper_fb_probe(struct drm_fb_helper *fb_helper, > sizes->surface_width, sizes->surface_height, > sizes->surface_bpp); > > - format = drm_mode_legacy_fb_format(sizes->surface_bpp, sizes->surface_depth); > + format = drm_driver_legacy_fb_format(dev, sizes->surface_bpp, > + sizes->surface_depth); > buffer = drm_client_framebuffer_create(client, sizes->surface_width, > sizes->surface_height, format); > if (IS_ERR(buffer))
diff --git a/drivers/gpu/drm/drm_fbdev_dma.c b/drivers/gpu/drm/drm_fbdev_dma.c index 97ef6300d47e..fdef4a2f883f 100644 --- a/drivers/gpu/drm/drm_fbdev_dma.c +++ b/drivers/gpu/drm/drm_fbdev_dma.c @@ -101,7 +101,8 @@ static int drm_fbdev_dma_helper_fb_probe(struct drm_fb_helper *fb_helper, sizes->surface_width, sizes->surface_height, sizes->surface_bpp); - format = drm_mode_legacy_fb_format(sizes->surface_bpp, sizes->surface_depth); + format = drm_driver_legacy_fb_format(dev, sizes->surface_bpp, + sizes->surface_depth); buffer = drm_client_framebuffer_create(client, sizes->surface_width, sizes->surface_height, format); if (IS_ERR(buffer))
The drm_mode_legacy_fb_format() function only generates formats suitable for little endian devices. switch to drm_driver_legacy_fb_format() here instead to take the device endianness into consideration, too. Suggested-by: Thomas Zimmermann <tzimmermann@suse.de> Signed-off-by: Thomas Huth <thuth@redhat.com> --- Note: Patch has only been compile-tested since I lack an environment for testing it. But it's the same fix as I required for the drm_mode_legacy_fb_format() in drm_fbdev_generic.c / drm_fbdev_ttm.c so I think this should be fine. drivers/gpu/drm/drm_fbdev_dma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)