| Message ID | 20240702131506.91493-1-r.smirnov@omp.ru (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d36983e032e98545c3d90154b1d94605c73170c2 |
| Headers | show |
| Series | [BlueZ,v1] gatt: add return value check of io_get_fd() to sock_io_read() | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=867554 ---Test result--- Test Summary: CheckPatch PASS 0.40 seconds GitLint PASS 0.28 seconds BuildEll PASS 25.74 seconds BluezMake PASS 1788.64 seconds MakeCheck PASS 13.65 seconds MakeDistcheck PASS 181.35 seconds CheckValgrind PASS 261.30 seconds CheckSmatch PASS 365.14 seconds bluezmakeextell PASS 123.96 seconds IncrementalBuild PASS 1533.21 seconds ScanBuild PASS 1052.76 seconds --- Regards, Linux Bluetooth
Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Tue, 2 Jul 2024 16:15:06 +0300 you wrote: > It is necessary to add a return value check. > > Found with the SVACE static analysis tool. > --- > src/gatt-database.c | 5 +++++ > 1 file changed, 5 insertions(+) Here is the summary with links: - [BlueZ,v1] gatt: add return value check of io_get_fd() to sock_io_read() https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=d36983e032e9 You are awesome, thank you!
diff --git a/src/gatt-database.c b/src/gatt-database.c index 5756eb9d1..8472aac59 100644 --- a/src/gatt-database.c +++ b/src/gatt-database.c @@ -2598,6 +2598,11 @@ static bool sock_io_read(struct io *io, void *user_data) int fd = io_get_fd(io); ssize_t bytes_read; + if (fd < 0) { + error("io_get_fd() returned %d\n", fd); + return false; + } + bytes_read = read(fd, buf, sizeof(buf)); if (bytes_read <= 0) return false;